A script problem

loretta0493 · April 30, 2022, 12:58pm

This is my first post. Tell me if something is wrong!

You can write your topic however you want, but you need to answer these questions:

What do you want to achieve? Keep it simple and clear!
I want to make this script work for R6, also there is a bug, it resets “Race” if player resets
What is the issue? Include screenshots / videos if possible!
Player changes back to their normal size and Gui stops displaying “Race”.
What solutions have you tried so far? Did you look for solutions on the Developer Hub?
I tried activating “ChangeBody()” and “Change()” after player resets. (i am new to scripting)
this is an example of how i tried to fix it:

Humanoid.Died:Connect(function()
ChangeBody()
Change()

It didn’t work since those functions reset after player respawns.
The code that i need to change (it has some notes):

local DataSaving = game:GetService("DataStoreService"):GetDataStore("Saving001")

game.Players.PlayerAdded:Connect(function(Player) 
	local Character = Player.Character or Player.CharacterAdded:Wait() 
	local Humanoid = Character:WaitForChild("Humanoid") 
	local PlayerGui = Player:WaitForChild("PlayerGui") 
	
	
	local Races = {
		Human = 60, 
		Demon = 5,
		Elf = 20,
		Giant = 40;
	}

	local sum = 0
	for _,Values in pairs(Races) do
		sum = sum + Values
	end

	local function getRandomItem()
		local RaceValue = Random.new():NextNumber(0, sum)
		for item, value in pairs(Races) do
			RaceValue = RaceValue - value
			if RaceValue < 0 then
				return item
			end
		end
	end
			-- the function below changes the size of the players body (but in r15)

	local function ChangeBody()
		local RaceNames = Player.DataFolder.Race.Value

		local Parts = Character:GetChildren()
		
		
		local BodySizeParts = {
			Humanoid.HeadScale,
			Humanoid.BodyDepthScale,
			Humanoid.BodyWidthScale,
			Humanoid.BodyHeightScale,
		}
		

		if RaceNames == "Giant" then
			for _,v in pairs(BodySizeParts) do
				v.Value = 2    	 -- scale
			end
		elseif RaceNames == "Elf" then
			for _,v in pairs(BodySizeParts) do
				v.Value = 0.6
			end
		elseif RaceNames == "Demon" then
			for _,v in ipairs(Parts) do
				if v:IsA("BasePart") then
					v.BrickColor = BrickColor.new("Really black")
				end
			end
		end

	end

	local DataFolder = Instance.new('Folder',Player)
	DataFolder.Name = "DataFolder"

	local Race = Instance.new("StringValue", DataFolder)
	Race.Name = "Race"

	local function Change() 		--changes text in StarterGui > RaceDisplay > TextButton > TextButton (i think, not quite sure, line 75)
		PlayerGui.RaceDisplay.TextButton.TextButton.Text = "Race: "..Race.Value
	end

	local Success, Value = pcall(function()
		return DataSaving:GetAsync(Player.UserId)
	end)

	if Success then
		if Value then
			Race.Value = Value[1]
		else
			Race.Value = tostring(getRandomItem())
		end
	else
		Race.Value = tostring(getRandomItem())
	end
	
	ChangeBody() 	 -- activates functions
	Change()
		

	end)
	


game.Players.PlayerRemoving:Connect(function(Player) 
	local Success, Err = pcall(function()
		DataSaving:SetAsync(Player.UserId, {Player.DataFolder:WaitForChild('Race').Value})
	end)
end)

game:BindToClose(function()
	for i, player in pairs(game.Players:GetPlayers()) do
		local Success, Err = pcall(function()
			DataSaving:SetAsync(player.UserId, {player.DataFolder:WaitForChild('Race').Value})
		end)
	end
end)

Everything would be very helpful! (I scripted it using a tutorial since i am new)

SeargentAUS · April 30, 2022, 1:09pm

Try putting it all in this:


game.Players.PlayerAdded:Connect(function(Player) 
	local Humanoid = Character:WaitForChild("Humanoid") 
	local PlayerGui = Player:WaitForChild("PlayerGui") 
	
    Player.CharacterAdded:Connect(function()
    local Character = Player.Character
	local Races = {
		Human = 60, 
		Demon = 5,
		Elf = 20,
		Giant = 40;
	}

	local sum = 0
	for _,Values in pairs(Races) do
		sum = sum + Values
	end

	local function getRandomItem()
		local RaceValue = Random.new():NextNumber(0, sum)
		for item, value in pairs(Races) do
			RaceValue = RaceValue - value
			if RaceValue < 0 then
				return item
			end
		end
	end
			-- the function below changes the size of the players body (but in r15)

	local function ChangeBody()
		local RaceNames = Player.DataFolder.Race.Value

		local Parts = Character:GetChildren()
		
		
		local BodySizeParts = {
			Humanoid.HeadScale,
			Humanoid.BodyDepthScale,
			Humanoid.BodyWidthScale,
			Humanoid.BodyHeightScale,
		}
		

		if RaceNames == "Giant" then
			for _,v in pairs(BodySizeParts) do
				v.Value = 2    	 -- scale
			end
		elseif RaceNames == "Elf" then
			for _,v in pairs(BodySizeParts) do
				v.Value = 0.6
			end
		elseif RaceNames == "Demon" then
			for _,v in ipairs(Parts) do
				if v:IsA("BasePart") then
					v.BrickColor = BrickColor.new("Really black")
				end
			end
		end

	end

	local DataFolder = Instance.new('Folder',Player)
	DataFolder.Name = "DataFolder"

	local Race = Instance.new("StringValue", DataFolder)
	Race.Name = "Race"

	local function Change() 		--changes text in StarterGui > RaceDisplay > TextButton > TextButton (i think, not quite sure, line 75)
		PlayerGui.RaceDisplay.TextButton.TextButton.Text = "Race: "..Race.Value
	end

	local Success, Value = pcall(function()
		return DataSaving:GetAsync(Player.UserId)
	end)

	if Success then
		if Value then
			Race.Value = Value[1]
		else
			Race.Value = tostring(getRandomItem())
		end
	else
		Race.Value = tostring(getRandomItem())
	end
	
	ChangeBody() 	 -- activates functions
	Change()
		

	end)
end)

I made it so it fires everytime the player respawns, so it shouldn’ matter if they reset

loretta0493 · April 30, 2022, 1:27pm

Thanks, but the script didn’t work, (it was missing some variables that I put back, but it still didn’t do anything). Thanks anyway! I also tried combining this with the first script just to be sure.

SeargentAUS · April 30, 2022, 1:27pm

What variables did you put back? Some of them HAD to be in the bit I added

loretta0493 · April 30, 2022, 1:28pm

i put back a Character Variable, and thats all

SeargentAUS · April 30, 2022, 1:28pm

Put it back inside the area I added. It has to be inside

loretta0493 · April 30, 2022, 1:31pm

I tried it, but it came with an error on the line 2

SeargentAUS · April 30, 2022, 1:32pm

What is the error??? I can’t help you debug if you don’t provide the error

loretta0493 · April 30, 2022, 1:33pm

‘ServerScriptService.Race1 (server script)’, Line 2 - Studio - Race1 (server script):2
23:30:55.902 Stack End - Studio
this is what came out

SeargentAUS · April 30, 2022, 1:33pm

I don’t think that’s the entire error. Can you please screenshot the output

loretta0493 · April 30, 2022, 1:35pm

23:34:15.508 ServerScriptService.Race1 (server script):2: attempt to index nil with ‘WaitForChild’ - Server - Race1 (server script):2
23:34:15.508 Stack Begin - Studio
23:34:15.508 Script ‘ServerScriptService.Race1 (server script)’, Line 2 - Studio - Race1 (server script):2
23:34:15.508 Stack End - Studio

Also there is in the script analysis that says unknown global character

SeargentAUS · April 30, 2022, 1:36pm

Can you please move local Humanoid = Character:WaitForChild("Humanoid") after the local character = bit within the bit I added

loretta0493 · April 30, 2022, 1:41pm

Ok, i put it where you said i need to put it,

game.Players.PlayerAdded:Connect(function(Player) 
	local Character = Player.Character
	local Humanoid = Character:WaitForChild("Humanoid") 
	local PlayerGui = Player:WaitForChild("PlayerGui")

but there still an error, the same error

23:39:02.713 ServerScriptService.Race1 (server script):5: attempt to index nil with ‘WaitForChild’ - Server - Race1 (server script):5
23:39:02.713 Stack Begin - Studio
23:39:02.713 Script ‘ServerScriptService.Race1 (server script)’, Line 5 - Studio - Race1 (server script):5
23:39:02.713 Stack End - Studio

SeargentAUS · April 30, 2022, 1:42pm

You moved them all out of the bit I added again…

SeargentAUS · April 30, 2022, 1:42pm

local DataSaving = game:GetService("DataStoreService"):GetDataStore("Saving001")

game.Players.PlayerAdded:Connect(function(Player) 
Player.CharacterAdded:Connect(function()
	local Character = Player.Character
	local Humanoid = Character:WaitForChild("Humanoid") 
	local PlayerGui = Player:WaitForChild("PlayerGui") 
	
	
	local Races = {
		Human = 60, 
		Demon = 5,
		Elf = 20,
		Giant = 40;
	}

	local sum = 0
	for _,Values in pairs(Races) do
		sum = sum + Values
	end

	local function getRandomItem()
		local RaceValue = Random.new():NextNumber(0, sum)
		for item, value in pairs(Races) do
			RaceValue = RaceValue - value
			if RaceValue < 0 then
				return item
			end
		end
	end
			-- the function below changes the size of the players body (but in r15)

	local function ChangeBody()
		local RaceNames = Player.DataFolder.Race.Value

		local Parts = Character:GetChildren()
		
		
		local BodySizeParts = {
			Humanoid.HeadScale,
			Humanoid.BodyDepthScale,
			Humanoid.BodyWidthScale,
			Humanoid.BodyHeightScale,
		}
		

		if RaceNames == "Giant" then
			for _,v in pairs(BodySizeParts) do
				v.Value = 2    	 -- scale
			end
		elseif RaceNames == "Elf" then
			for _,v in pairs(BodySizeParts) do
				v.Value = 0.6
			end
		elseif RaceNames == "Demon" then
			for _,v in ipairs(Parts) do
				if v:IsA("BasePart") then
					v.BrickColor = BrickColor.new("Really black")
				end
			end
		end

	end

	local DataFolder = Instance.new('Folder',Player)
	DataFolder.Name = "DataFolder"

	local Race = Instance.new("StringValue", DataFolder)
	Race.Name = "Race"

	local function Change() 		--changes text in StarterGui > RaceDisplay > TextButton > TextButton (i think, not quite sure, line 75)
		PlayerGui.RaceDisplay.TextButton.TextButton.Text = "Race: "..Race.Value
	end

	local Success, Value = pcall(function()
		return DataSaving:GetAsync(Player.UserId)
	end)

	if Success then
		if Value then
			Race.Value = Value[1]
		else
			Race.Value = tostring(getRandomItem())
		end
	else
		Race.Value = tostring(getRandomItem())
	end
	
	ChangeBody() 	 -- activates functions
	Change()
		

	end)
end)


game.Players.PlayerRemoving:Connect(function(Player) 
	local Success, Err = pcall(function()
		DataSaving:SetAsync(Player.UserId, {Player.DataFolder:WaitForChild('Race').Value})
	end)
end)

game:BindToClose(function()
	for i, player in pairs(game.Players:GetPlayers()) do
		local Success, Err = pcall(function()
			DataSaving:SetAsync(player.UserId, {player.DataFolder:WaitForChild('Race').Value})
		end)
	end
end)

loretta0493 · April 30, 2022, 1:46pm

Ohhh, i needed to put them in this… well i just tested it
it kinda works. (i am starting to feel bad for wasting your time) so after player respawns they were given a diffrent “Race”, but i think i know how to fix it, ty!

SeargentAUS · April 30, 2022, 1:46pm

If the answer is satisfactory, please ensure to mark it as the solution