Better way to do this?

Help and Feedback Code Review
#1

image
image521×650 49.6 KB

is there a better way to do this, this code is really ugly and I want to change it.

#2

I think making dictionary for this one like

local dict = {
  [100]  = { -- this is the value of the TotalTurns
       IndustrialEra = false;
       EraName = "IndustrialEra"
  }
}

and run loop in the function

sorry i wrote this on mobile so it could be confusing

1 Like
#3

can you give me a example? ------

#4

I don’t really understand ------------

#5

Might look like this

local dict = {
	{ Max = 145, Value = false, Name = "ModernEra" },
	{ Max = 100, Value = false, Name = "Industrial" }
	-- Descending order
}

for _, Object in pairs(dict) do
	if TotalTurns.Value >= Object.Max and Object.Value == false then
		Object.Value = true
		EraModule.ChangeEra(Object.Name)
	end
end
4 Likes