Cannot stop animations with module script

Help and Feedback Scripting Support
,
1

I have made a module for my project which should easily handle player animations; however no matter what I try I cannot get any looped animations to stop.

Here is the full script:

local moduleAnimator = {}

function moduleAnimator:retrieveAnimator(player)
	local animator
	if player:IsA("Player") then
		animator = player.Character.Humanoid.Animator
	else
		animator = player.Humanoid.Animator
	end
	return animator
end

function moduleAnimator:playAnimation(player,animationTrack)
	local animator = moduleAnimator:retrieveAnimator(player)
	local animTrack = animator:LoadAnimation(animationTrack)
	animTrack:Play()
	animTrack:AdjustSpeed(1)
end

function moduleAnimator:stopAnimation(player,animationTrack)
	local animator = moduleAnimator:retrieveAnimator(player)
	local anim = animator:LoadAnimation(animationTrack)
	anim:Destroy()
end

return moduleAnimator

I’ve tried a multitude of things however I cannot reach a conclusion, all of the other posts experiencing the same problem never seem to solve the issue either (even ones marked as solved).

Thank you.

1 Like
2

Did you try using anim:Stop() then :Destroy() ?

Edit:
For further details the way I would do this is store all the data in a table like

local PlayersAnimations = {
 ["McGamerNick"] = {
  walk = animTrackVariable,
  dance1 = animTrackVariableFromplayAnimation
 }
}

then you can just index it

if PlayersAnimation[player.Name] then
 moduleAnimator:playAnimation(player, PlayersAnimation[player.Name].dance1)
end

It’s how I do it in my games, since it’s easier to reference everything, then just set the entry to nil when you are done with it and destroy it from the character’s animator.

3

Yeah, what I have here is just the result of a bunch of trial and error :sob:

That doesn’t seem to work for some strange reason.

4

First off, Animator:LoadAnimation creates a new track, it does not get a track.

You can use Animator:GetPlayingAnimationTracks which returns an array of AnimationTracks currently playing. Loop through them and check the name against a name you pass.

i.e moduleAnimator:stopAnimation(player, "Idle") to stop the idle animation.
EDIT #2
You need to update your code to actually work with this.

function moduleAnimator:stopAnimation(player, trackName: string)
    -- get your animator here
    for _, v in Animator:GetPlayingAnimationTracks() do
        if v.Name == trackName then
            v:Stop()
            return
        end
    end

end

EDIT #3
You should also look into some OOP programming.

Creating an object to handle animations is better than a general purpose module.

Resources (edited in):

2 Likes
5

This is horrible practice and does not align with what the OP actually wants.

6

I did not know that built in function exists! Going to swap to that now actually :sunglasses:

My apologies. I do know it’s horrible practice but I didn’t know about :GetPlayingAnimationTracks(). Learn something new every morning

1 Like
7

This worked, thank you!

(I actually did this before, using this code)
function moduleAnimator:stopAnimation(player,animationTrack)

local animator = moduleAnimator:retrieveAnimator(player)
local anim = animationTrack.Name
for _,v in pairs(animator:GetPlayingAnimationTracks()) do
	if v.Name == anim then
		v:Stop()
		return
	end
end

end

But I marked “v” as anim … :stuck_out_tongue:
1 Like
8

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.