Code subtracting more then it should from a value

Help and Feedback Scripting Support
1

I have made a revolver with a limited amount of bullets in it, and whenever you reload, its supposed to subtract 6 from the ammo. But instead every time the revolver reloads, it subtracts more than its last reload. Here is my code:

if script.Parent.Parent.GranderAmmo.Value>0 then
				script.Parent.Parent.Enabled=false
				script.Parent.Parent.Handle.Reload:Play()
				script.Parent.Parent.Handle.Reload.Ended:Connect(function(sound)
					script.Parent.Parent.Enabled=true
					script.Parent.Parent.Ammo.Value=6
					script.Parent.Parent.GranderAmmo.Value=script.Parent.Parent.GranderAmmo.Value-6
				end)
			else
				script.Parent.Parent.Handle.Empty:Play()
			end

Some info:
Ammo is the revolvers currently loaded ammo. GreaterAmmo is the bullets the revolver has left.

1 Like
2

By the way, this is an alt account I’m posting from.

3

For troubleshooting things like this use prints

if script.Parent.Parent.GranderAmmo.Value>0 then
    print("GranderAmmo = " ... script.Parent.Parent.GranderAmmo.Value)
    print("Ammo = " ... script.Parent.Parent.Ammo.Value)
	script.Parent.Parent.Enabled=false
	script.Parent.Parent.Handle.Reload:Play()
	script.Parent.Parent.Handle.Reload.Ended:Connect(function(sound)
		script.Parent.Parent.Enabled=true
		script.Parent.Parent.Ammo.Value=6
		script.Parent.Parent.GranderAmmo.Value=script.Parent.Parent.GranderAmmo.Value-6
	end)
else
	script.Parent.Parent.Handle.Empty:Play()
end

Your script looks ok to me, but my print statements will let you know what the values are when this if segment of code runs. If the prints give a different value than you expect the calculations are skewed by something outside of this segment of code.

4

Maybe try

if script.Parent.Parent.GranderAmmo.Value >= 6 then
2 Likes
5

Try putting the

Outside of the if statement. It may be that the connection is getting replicated every time it is called.

6

Just Found Something Out:
Every time the revolver reloads, it increases the amount that it executes the function that happens after the reload.
I used print to find this.
First reload, it printed Subtraction Executed, but second reload, it printed Subtraction Executed (x2)

7

Hey, your issue is probably that your Reload.Ended event is duplicating. Basically, everytime your script runs, it will read that line, and it will connect the event again and again everytime it reads, while the previous ones are still connected.

One solution you can apply is to disconnect the event after each use so that it can be reconnected later on when needed, and not duplicated.

This is your current part of the script that causes the problem.

script.Parent.Parent.Handle.Reload.Ended:Connect(function(sound)
					script.Parent.Parent.Enabled=true
					script.Parent.Parent.Ammo.Value=6
					script.Parent.Parent.GranderAmmo.Value=script.Parent.Parent.GranderAmmo.Value-6
				end)

You can replace it with the following:

local event

event = script.Parent.Parent.Handle.Reload.Ended:Connect(function(sound)
					script.Parent.Parent.Enabled=true
					script.Parent.Parent.Ammo.Value=6
					script.Parent.Parent.GranderAmmo.Value=script.Parent.Parent.GranderAmmo.Value-6
event:Disconnect()
				end)

Something like that should do the trick

Also one little shortcut you can use is that instead of writing

script.Parent.Parent.GranderAmmo.Value=script.Parent.Parent.GranderAmmo.Value-6

You can instead write it this way

script.Parent.Parent.GranderAmmo.Value -= 6

It makes the code shorter and easier to read. It also works with +=, /= and *=

1 Like
8

I think if you just replace the :Connect( with :Once( it will be fixed. It’s just like connecting an event, except that it automatically disconnects it after running once.

But moving that event outside of this code block like others have suggested would be better, so you don’t unnecessarily reconnect and disconnect the same event again and again.

9

Thanks! This Helped! The Revolver Is Now Working!

10

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.