Custom animation script issues

the_sus7 · February 11, 2023, 10:57pm

I’m making a custom animation script (with accurate footsteps) and it has some issues that i don’t how how to solve.

What do you want to achieve? I want to create a simple animation script with accurate footstep sounds to give me easier access to changing animations (Hope that makes sense.)
What is the issue? The animations don’t play, nor does the default animation script delete itself like I want it to.
What solutions have you tried so far? I looked for solutions on more topics, and took many glances and changed my script, but nothing I tried worked.

Here’s the script (sorry if it’s messy):

local plr = game:GetService("Players").LocalPlayer
local char = plr.Character or plr.CharacterAdded:Wait()
local hum = char:WaitForChild("Humanoid")
local root = char:WaitForChild("HumanoidRootPart")

local step = script.Sound

local runanim = script.run
local walkanim = script.walk
local jumpanim = script.jump
local fallanim = script.fall

local run = hum:LoadAnimation(runanim)
local walk = hum:LoadAnimation(walkanim)
local jump = hum:LoadAnimation(jumpanim)
local fall = hum:LoadAnimation(fallanim)

while true do
	char:WaitForChild("Animate"):Destroy()
	if hum.WalkSpeed <= 14 then
		if hum:GetState() == Enum.HumanoidStateType.Running then
			walk:Play()
			walk:GetMarkerReachedSignal("Left"):Connect(foot())
			walk:GetMarkerReachedSignal("Right"):Connect(foot())
		else
			walk:Stop()
		end
	elseif hum.WalkSpeed >= 14 then
		if hum:GetState() == Enum.HumanoidStateType.Running then
			run:Play()
			run:GetMarkerReachedSignal("Left"):Connect(foot())
			run:GetMarkerReachedSignal("Right"):Connect(foot())
		else
			run:Stop()
		end
	end
end

function foot()
	step:Play()
end

If you have any info I could use, or pieces of a script then please tell me

Note: the game is in R6, and I do not know much about scripting, so please use detail.

Edit: I forgot to mention that the script is a LocalScript in StarterCharacterScripts

GooberOnTheForums · February 12, 2023, 4:44am

It looks like your code is an infinite loop, which will instantly crash studio. It is a much better idea to use RunService.RenderStepped() instead. It also looks like the foot() function you made isnt being used in the code snippet. You can make accurate footsteps by making animation events on the frame where the player’s foot touches the ground. You can then check if you’ve reached the animation marker/event by using Track:GetMarkerReachedSignal(“MarkerName”)

the_sus7 · February 12, 2023, 9:45pm

thanks! i’ll try this right now!

GooberOnTheForums · February 12, 2023, 9:55pm

I had just realized that this part is in the loop, which will throw an error since the default Animate script no longer exists. You should put this line outside of the loop.

the_sus7 · February 12, 2023, 9:57pm

Thank you, but now the animations and the step sounds just play constantly in a loop, do you have any idea on how i could fix that?

GooberOnTheForums · February 12, 2023, 10:01pm

What is the script you are currently using right now?

the_sus7 · February 12, 2023, 10:02pm

local runserv = game:GetService("RunService")

local plr = game:GetService("Players").LocalPlayer
local char = plr.Character or plr.CharacterAdded:Wait()
char:WaitForChild("Animate"):Destroy()
local hum = char:WaitForChild("Humanoid")
local root = char:WaitForChild("HumanoidRootPart")

local step = script.Sound

local runanim = script.run
local walkanim = script.walk
local jumpanim = script.jump
local fallanim = script.fall

local run = hum:LoadAnimation(runanim)
local walk = hum:LoadAnimation(walkanim)
local jump = hum:LoadAnimation(jumpanim)
local fall = hum:LoadAnimation(fallanim)

function foot()
	step:Play()
end

runserv.RenderStepped:Connect(function()
	if hum.WalkSpeed <= 14 then
		if hum:GetState() == Enum.HumanoidStateType.Running then
			walk:Play()
			walk:GetMarkerReachedSignal("Left"):Connect(foot())
			walk:GetMarkerReachedSignal("Right"):Connect(foot())
		else hum:GetState() == Enum.HumanoidStateType.
			walk:Stop()
		end
	elseif hum.WalkSpeed >= 14 then
		if hum:GetState() == Enum.HumanoidStateType.Running then
			run:Play()
			run:GetMarkerReachedSignal("Left"):Connect(foot())
			run:GetMarkerReachedSignal("Right"):Connect(foot())
		else
			run:Stop()
		end
	end
end)

GooberOnTheForums · February 12, 2023, 10:02pm

Is the footstep sound you are using looped?

the_sus7 · February 12, 2023, 10:03pm

im pretty sure it isnt?

GooberOnTheForums · February 12, 2023, 10:08pm

Try using destroying the sound after it is played using Sound.Ended(). Also make sure to clone the sound and play the sound clone instead.

function foot()
    local Sound = step:Clone()
    Sound.Parent = root
    Sound:Play()
    task.spawn(function()
		Sound.Ended:Wait()
		Sound:Destroy()
	end)
end

the_sus7 · February 12, 2023, 10:11pm

its still looping the animation and sound? i don’t understand what’s wrong

local runserv = game:GetService("RunService")

local plr = game:GetService("Players").LocalPlayer
local char = plr.Character or plr.CharacterAdded:Wait()
char:WaitForChild("Animate"):Destroy()
local hum = char:WaitForChild("Humanoid")
local root = char:WaitForChild("HumanoidRootPart")

local step = script.Sound

local runanim = script.run
local walkanim = script.walk
local jumpanim = script.jump
local fallanim = script.fall

local run = hum:LoadAnimation(runanim)
local walk = hum:LoadAnimation(walkanim)
local jump = hum:LoadAnimation(jumpanim)
local fall = hum:LoadAnimation(fallanim)

function foot()
	local Sound = step:Clone()
	Sound.Parent = root
	Sound:Play()
	task.spawn(function()
		Sound.Ended:Wait()
		Sound:Destroy()
	end)
end

runserv.RenderStepped:Connect(function()
	if hum.WalkSpeed <= 14 then
		if hum:GetState() == Enum.HumanoidStateType.Running then
			walk:Play()
			walk:GetMarkerReachedSignal("Left"):Connect(foot())
			walk:GetMarkerReachedSignal("Right"):Connect(foot())
		else
			walk:Stop()
		end
	elseif hum.WalkSpeed >= 14 then
		if hum:GetState() == Enum.HumanoidStateType.Running then
			run:Play()
			run:GetMarkerReachedSignal("Left"):Connect(foot())
			run:GetMarkerReachedSignal("Right"):Connect(foot())
		else
			run:Stop()
		end
	end
end)

GooberOnTheForums · February 12, 2023, 10:16pm

function foot()
	local Sound = Instance.new("Sound")
	Sound.Parent = root
    Sound.SoundId = "rbxassetid://" -- Your id here
    Sound.Volume = 0.5
   -- Do keep in mind in order for the sound to lose volume the further away it is it needs to be parented to a part
    Sound.RollOffMinDistance = 10 -- This is the minimum amount of distance you need to be from the sound's origin for it to start to lose volume
    Sound.RollOffMaxDistance = 50 -- This is the maximum distance you can hear the sound before you cant hear it
	Sound:Play()
	task.spawn(function()
		Sound.Ended:Wait()
		Sound:Destroy()
	end)
end

Does this work?

GooberOnTheForums · February 12, 2023, 10:19pm

Ah, I see the problem now

the_sus7:

runserv.RenderStepped:Connect(function()
	if hum.WalkSpeed <= 14 then
		if hum:GetState() == Enum.HumanoidStateType.Running then
			walk:Play()
			walk:GetMarkerReachedSignal("Left"):Connect(foot())
			walk:GetMarkerReachedSignal("Right"):Connect(foot())
		else
			walk:Stop()
		end
	elseif hum.WalkSpeed >= 14 then
		if hum:GetState() == Enum.HumanoidStateType.Running then
			run:Play()
			run:GetMarkerReachedSignal("Left"):Connect(foot())
			run:GetMarkerReachedSignal("Right"):Connect(foot())
		else
			run:Stop()
		end
	end
end)

You are playing the animation and restarting it every frame. You can avoid this by checking if the animation is not playing using Animation.IsPlaying in an if statement.

runserv.RenderStepped:Connect(function()
	if hum.WalkSpeed <= 14 then
		if hum:GetState() == Enum.HumanoidStateType.Running and not walk.IsPlaying then
			if run.IsPlaying then run:Stop() end -- Stops the running animation
            walk:Play()
			walk:GetMarkerReachedSignal("Left"):Connect(foot())
			walk:GetMarkerReachedSignal("Right"):Connect(foot())
		end
	elseif hum.WalkSpeed >= 14 then
		if hum:GetState() == Enum.HumanoidStateType.Running and not run.IsPlaying then
			if walk.IsPlaying then walk:Stop() end -- Stops the walking animation
            run:Play()
			run:GetMarkerReachedSignal("Left"):Connect(foot())
			run:GetMarkerReachedSignal("Right"):Connect(foot())
		end
	end
end)

the_sus7 · February 12, 2023, 10:21pm

thanks!, i’ll try it and see if it works this time.

GooberOnTheForums · February 12, 2023, 10:22pm

I edited the post, use the new version instead.

the_sus7 · February 12, 2023, 10:29pm

it fixes the sound and animation playing over and over, but the sound doesnt play with the animation events, only plays when the animation starts, and the animation doesnt stop when i stop moving. any idea how to fix this? sorry about asking so many questions, lol

GooberOnTheForums · February 12, 2023, 10:33pm

runserv.RenderStepped:Connect(function()
	if hum.WalkSpeed <= 14 and hum.MoveDirection.Magnitude > 0 then
		if hum:GetState() == Enum.HumanoidStateType.Running and not walk.IsPlaying then
			if run.IsPlaying then run:Stop() end -- Stops the running animation
            walk:Play()
			walk:GetMarkerReachedSignal("Left"):Connect(foot())
			walk:GetMarkerReachedSignal("Right"):Connect(foot())
		end
	elseif hum.WalkSpeed >= 14 and hum.MoveDirection.Magnitude > 0 then
		if hum:GetState() == Enum.HumanoidStateType.Running and not run.IsPlaying then
			if walk.IsPlaying then walk:Stop() end -- Stops the walking animation
            run:Play()
			run:GetMarkerReachedSignal("Left"):Connect(foot())
			run:GetMarkerReachedSignal("Right"):Connect(foot())
		end
	else
        if run.IsPlaying then run:Stop() end
        if walk.IsPlaying then walk:Stop() end
    end
end)

Humanoid.MoveDirection.Magnitude will be greater than 0 when the player is moving, and Humanoid.MoveDirection.Magnitude will be 0 when the player is not moving

the_sus7 · February 12, 2023, 10:39pm

thanks, but the sound still doesnt play when the animation event passes,

GooberOnTheForums · February 12, 2023, 10:42pm

Are the Animation Events in the animation itself?

the_sus7 · February 12, 2023, 10:44pm

Yeah, they are in the animation