Custom PlayerList help

iiNathxnism · May 18, 2024, 4:48am

got myself a Working Playerlist, however it doesn’t reflect to everyone and therefore only get’s copied to a local player, can anyone help me out on this one? This only gets reflected on 1 player.

I used FireAllClients on ServerScripts. Can anyone help me out?

--// Client Side
function module.setUpPlayerList(plr: Player)
	local Template	= script:WaitForChild("TemplatePlayerList"):Clone()
	local success1, AvatarIMG_Headshot	= pcall(PLYR_SRVC.GetUserThumbnailAsync, PLYR_SRVC, plr.UserId, Enum.ThumbnailType.HeadShot, Enum.ThumbnailSize.Size420x420)
	local success2, AvatarIMG_Bust		= pcall(PLYR_SRVC.GetUserThumbnailAsync, PLYR_SRVC, plr.UserId, Enum.ThumbnailType.AvatarBust, Enum.ThumbnailSize.Size420x420)
	
	local ScrollingFrame = plr:WaitForChild("PlayerGui").CoreGui.PlayerFrame.PlayerFrame.PlayerList
	local ForCopy = STARTERGUI_SRVC.CoreGui.PlayerFrame.PlayerFrame.PlayerList
	Template.Parent = ForCopy
	Template.Parent = ScrollingFrame
	Template.Name = plr.Name
	
	local main_Contents = Template
	main_Contents.PlayerPicture.Image = AvatarIMG_Headshot
	main_Contents.DisplayName.Text = plr.DisplayName
	main_Contents.Username.Text = plr.Name

	local secondary_Contents = main_Contents:WaitForChild("MoreInfo_FRAME"):WaitForChild("FRAME")
	secondary_Contents.PlayerPicture.Image = AvatarIMG_Bust
	secondary_Contents.DisplayName.Text = plr.DisplayName
	secondary_Contents.AccountAge.Text = "Account Age: "..plr.AccountAge
	secondary_Contents.PlayerName.Text = plr.Name

	warn(SYS_String, "PlayerList for player", plr.Name, "is created.")
end

Doomcolp · May 18, 2024, 4:59am

You’re gonna need to show that code cuz that’s what the issue is gonna be

iiNathxnism · May 18, 2024, 5:03am

--// this is the Server Side
local function onPlayerAdded(plr: Player)
	PlayerUpdateListEvent:FireAllClients(plr, "PlayerEntered")
	PLYR_HANDLER.SetUp(plr)
	LEADERBOARD_DATA.LoadData(plr)
	CASH_DATA.LoadData(plr)
end

and then Client Listens:

--// Client Side
local function updatePlayerList(plr: Player, val: string)	
	if val == "PlayerEntered" then
		moduleClient.setUpPlayerList(plr)
	elseif val == "PlayerLeft" then
		moduleClient.removePlayerList(plr)
	end
end

then the rest is on the first one that I sent

Doomcolp · May 18, 2024, 5:56am

I’m super sorry for my hour late response, was doing something. I can prolly assume that the “updatePlayerList” function is connected to your remote event’s OnServerEvent listener

But could you show that line (OnServerEvent line). The code you just sent seems fine

iiNathxnism · May 18, 2024, 5:59am

isnt it suppose to be onClientEvent? or onServerEvent? since the remote fires from Server. And also no worries, been trying here to fix it myself too xd

Doomcolp · May 18, 2024, 5:59am

It probably should be OnClientEvent but let’s just see what you’ve got

iiNathxnism · May 18, 2024, 6:00am

that line of code is just a connection to the Function within the Client Script:

PlayerUpdateListEvent.OnClientEvent:Connect(updatePlayerList)

iiNathxnism · May 18, 2024, 6:03am

I actually have updated the code and currently testing it rn:

--// the current Module Code rn
function module.setUpPlayerList()
	local plrList = STARTERGUI_SRVC.PlayerListGui.PlayerFrame.PlayerFrame.PlayerList
	local Template	= script:WaitForChild("TemplatePlayerList"):Clone()
	local allPlayers = PLYR_SRVC:GetPlayers()
	
	for _, plrList in ipairs(plrList:GetChildren()) do
		if plrList:IsA("Frame") then
			plrList:Destroy()
			print("Deleted Current Playlist for a Refresh...")
		end
	end	
	
	for _, plrs in allPlayers do
		print("Creating new PlayerList...")
		print("Current Players: ", allPlayers)
		local success1, AvatarIMG_Headshot	= pcall(PLYR_SRVC.GetUserThumbnailAsync, PLYR_SRVC, plrs.UserId, Enum.ThumbnailType.HeadShot, Enum.ThumbnailSize.Size420x420)
		local success2, AvatarIMG_Bust		= pcall(PLYR_SRVC.GetUserThumbnailAsync, PLYR_SRVC, plrs.UserId, Enum.ThumbnailType.AvatarThumbnail, Enum.ThumbnailSize.Size420x420)
		local plrGui_plrList = plrs.PlayerGui.PlayerListGui.PlayerFrame.PlayerFrame.PlayerList

		local ForCopy = STARTERGUI_SRVC.PlayerListGui.PlayerFrame.PlayerFrame.PlayerList
		Template.Parent = ForCopy
		Template.Name = plrs.Name
		
		local main_Contents = Template
		main_Contents.PlayerPicture.Image = AvatarIMG_Headshot
		main_Contents.DisplayName.Text = plrs.DisplayName
		main_Contents.Username.Text = plrs.Name

		local secondary_Contents = main_Contents:WaitForChild("MoreInfo_FRAME"):WaitForChild("FRAME")
		secondary_Contents.PlayerPicture.Image = AvatarIMG_Bust
		secondary_Contents.DisplayName.Text = plrs.DisplayName
		secondary_Contents.AccountAge.Text = "Account Age: "..plrs.AccountAge
		secondary_Contents.PlayerName.Text = plrs.Name	
		
		Template:Clone().Parent = plrGui_plrList
		
		warn(SYS_String, "PlayerList for player", plrs.Name, "is created.")
	end
end

Doomcolp · May 18, 2024, 6:12am

Wait I just realized why it’s not working lol.

Was thinking about it and I was like… “why are you changing other player’s GUIs from the client?”

Ya cant manipulate other players’ UI from a client (that would be bad )

You should change it on the server. If I understood your problem correctly

iiNathxnism · May 18, 2024, 6:16am

I just realized that right now xD so wait… I should just let the creation of new playerlist directly on the Server than the client? bruh moment-

btw, I updated the code in module (the client uses this module) and this works and it gets replicated to everyone.

function module.setUpPlayerList()
	local plrList = STARTERGUI_SRVC.PlayerListGui.PlayerFrame.PlayerFrame.PlayerList
	local Template	= script:WaitForChild("TemplatePlayerList"):Clone()
	local allPlayers = PLYR_SRVC:GetPlayers()
	
	for _, plrList in ipairs(plrList:GetChildren()) do
		if plrList:IsA("Frame") then
			plrList:Destroy()
			print("Deleted Current Playlist for a Refresh...")
		end
	end	
	
	local plrGui_plrList = PLYR_SRVC.LocalPlayer.PlayerGui.PlayerListGui.PlayerFrame.PlayerFrame.PlayerList
	
	for _, plrs in allPlayers do
		print("Creating new PlayerList...")
		print("Current Players: ", allPlayers)
		local success1, AvatarIMG_Headshot	= pcall(PLYR_SRVC.GetUserThumbnailAsync, PLYR_SRVC, plrs.UserId, Enum.ThumbnailType.HeadShot, Enum.ThumbnailSize.Size420x420)
		local success2, AvatarIMG_Bust		= pcall(PLYR_SRVC.GetUserThumbnailAsync, PLYR_SRVC, plrs.UserId, Enum.ThumbnailType.AvatarThumbnail, Enum.ThumbnailSize.Size420x420)

		local ForCopy = STARTERGUI_SRVC.PlayerListGui.PlayerFrame.PlayerFrame.PlayerList
		Template.Parent = ForCopy
		Template.Name = plrs.Name
		
		local main_Contents = Template
		main_Contents.PlayerPicture.Image = AvatarIMG_Headshot
		main_Contents.DisplayName.Text = plrs.DisplayName
		main_Contents.Username.Text = plrs.Name

		local secondary_Contents = main_Contents:WaitForChild("MoreInfo_FRAME"):WaitForChild("FRAME")
		secondary_Contents.PlayerPicture.Image = AvatarIMG_Bust
		secondary_Contents.DisplayName.Text = plrs.DisplayName
		secondary_Contents.AccountAge.Text = "Account Age: "..plrs.AccountAge
		secondary_Contents.PlayerName.Text = plrs.Name	
		
		Template:Clone().Parent = plrGui_plrList
		
		warn(SYS_String, "PlayerList for player", plrs.Name, "is created.")
	end
end

tell me alternative ways I can make this better and efficient than the current ones I am doing xD

12345koip · May 18, 2024, 6:39am

Let each client manage their own gui. I had a similar issue recently and I just added PlayerAdded and PlayerRemoving connections on the client, it worked after that.

iiNathxnism · May 18, 2024, 6:42am

I thought its not possible to use PlayerAdded and PlayerRemoving on client?

12345koip · May 18, 2024, 6:54am

They work on the client, just not when you join. They will detect other people joining and leaving.

iiNathxnism · May 18, 2024, 6:55am

well I never knew about that, I guess I can look through it