Datastore not saving

Help and Feedback Scripting Support
1

Hello, I recently followed @GEILER123456’s tutorial on how to make a Datastore, but the data is not saving. The output says "There was an error with saving a player’s data Unable to cast to array.
This is the script:

local dataStoreService = game:GetService("DataStoreService")
local players = game:GetService("Players")

local dataStore = dataStoreService:GetDataStore("Name")

local function leaderboardSetUp(player)
	local userId = player.UserId
	local key = "Player_" .. userId
	local data = dataStore:GetAsync(key)
	
	local leaderstats = Instance.new("Folder")
	leaderstats.Name = "leaderstats"
	leaderstats.Parent = player
	
	local wins = Instance.new("IntValue")
	wins.Name = "Wins"
	wins.Value = data or 0
	wins.Parent = leaderstats
	
	local money = Instance.new("IntValue")
	money.Name = "Money"
	money.Value = data or 0
	money.Parent = leaderstats

	print("Leaderstats loaded.")

end

local function save(player)
	local userId = player.UserId
	local key = "Player_" .. userId
	local leaderstats = player:FindFirstChild("leaderstats")

	if leaderstats then
		local winsValue = leaderstats.Wins.Value
		local moneyValue = leaderstats.Money.Value
		local success, ret = pcall(dataStore.GetAsync, dataStore, key, winsValue, moneyValue)

		if success then
			print("Data has been saved successfully!")
		else
			print("There was an error with saving a player's data" .. ret)
		end
	end
end

local function onShutDown()
	wait(1)
end
game:BindToClose(onShutDown)



players.PlayerAdded:Connect(leaderboardSetUp)
players.PlayerRemoving:Connect(save)

while true do
	wait(60)
	for _,player in ipairs(players:GetPlayers()) do
		coroutine.wrap(save)(player)
	end
end

Is there any problem with the script? What am I doing wrong? Thank you.

2

Did you enabled roblox API Services on game settings?

3

If that is the problem, the error should be different

4

I did enable API Services on the game settings.

5

I think to save you have to use UpdateAsync() and not GetAsync()

1 Like
6

I think it’s should be SetAsync

7

You can use SetAsync when its the first time the player enters the game, when it already has player data, he have to use Update Async 'cause SetAsync is dangerous

8

When I did SetAsync, the output said the same thing, There was an error with saving a player’s data Unable to cast to array.

9

When I use UpdateAsync, then it prints out this saying “There was an error saving a player’s data Unable to cast value to function”.

10

Try this:

local dataStore = game:GetService("DataStoreService"):GetDataStore("Name")
local players = game:GetService("Players")

players.PlayerAdded:Connect(function(player)
	local Success,data = pcall(function()
		return dataStore:GetAsync("Player_" .. player.UserId)
	end)
	if not Success then				print(data)				end

	local leaderstats = Instance.new("Folder")
	leaderstats.Name = "leaderstats"
	leaderstats.Parent = player

	local wins = Instance.new("IntValue")
	wins.Name = "Wins"
	wins.Value = 0
	if data then				wins.Value = data["Wins"]		end
	wins.Parent = leaderstats

	local money = Instance.new("IntValue")
	money.Name = "Money"
	money.Value = 0
	if data then				wins.Value = data["Money"]		end
	money.Parent = leaderstats

	print("Leaderstats loaded.")
end)

function save(player)
	local key = "Player_" .. player.UserId
	
	local leaderstats = player:FindFirstChild("leaderstats")
	if leaderstats then
		local Success, Err = pcall(function()
			dataStore:SetAsync(key, {
				["Money"] = leaderstats.Money.Value,
				["Wins"] = leaderstats.Wins.Value
			})
		end)
		
		if Success then
			print("Data has been saved successfully!")
		else
			print("There was an error with saving a player's data" .. Err)
		end
	end
end

players.PlayerRemoving:Connect(save)
game:BindToClose(function()
	for _,player in pairs(game:GetService("Players"):GetPlayers()) do
		coroutine.wrap(save)(player)
	end
	wait(2)
end)

something happened?

1 Like
11

Let me test this out, and I will tell you.

1 Like
12

There was an error saying this:
ErrorDataStore

13

In the pcall parameter. You put values instead of function

1 Like
14

try more times:

for i = 1, 10 do
		local success, ret = pcall(dataStore.GetAsync, dataStore, key, winsValue, moneyValue)

		if success then
			print("Data has been saved successfully!")
			break
		else
			print("There was an error with saving a player's data" .. ret)
		end
end
1 Like
15

Does the output say something about the pcalls or prints?

1 Like
16

There was a print, but I don’t think there was anything with pcalls.
This is the print:

error4
error4888×38 17.9 KB

17

In the output, it said “Data has been saved successfully”, but the data didn’t save.

18

This is because that was a GetAsync call.

1 Like
19

What should I change it other than GetAsync? I tried SetAsync, UpdateAsync, but none of them worked.

20

UpdateAsync is the best one to use as if other servers access it then it will not become messy. Is it possible the values are being removed before the player leaves. Also, you should ALSO have PlayerRemoving as BindToClose only fires when a server is shutting down not a player leaving.

1 Like