Datastore not working

Help and Feedback Scripting Support
,
1

My datastore isn’t saving at all.

It’s a coins datastore, and the coins aren’t saving.
When a player leaves, their coins should be stored and then loaded when they rejoin. This isn’t the case here for some reason.

scripts:
(both in server script service)
script to setup the leaderstats

game.Players.PlayerAdded:Connect(function(player)
	local lead = Instance.new("Folder")
	lead.Name = "leaderstats"
	lead.Parent = player
	
	local coins = Instance.new("IntValue")
	coins.Name = "Coins"
	coins.Parent = lead
	
	
end)

datastore script

local DSS = game:GetService("DataStoreService")
local dataStore = DSS:GetDataStore("MyDataStore")

game.Players.PlayerAdded:Connect(function(player)
	local coins = player:WaitForChild("leaderstats").Coins
	
	local data
	local succ, err = pcall(function()
		data = dataStore:GetAsync(player.UserId.."_coins", player.leaderstats.Coins.Value)
	end)
	
	if succ then
		coins.Value = data
		print("coins loaded")	
	end
end)

game.Players.PlayerRemoving:Connect(function(player)
	local data = player.leaderstats.Coins.Value
	
	local succ, err = pcall(function()
		dataStore:SetAsync(player.UserId.."_coins", player.leaderstats.Coins.Value)
	end)		
	
	if succ then
		print("coins saved")
	else
		print("error when saving coins")
		warn(err)
		
	end
end)
2

I have studio API services enabled in game settings, so I know datastores are accessible.

3

Alright I have experienced this problem before, and you need to bind a close event to the DataModel to wait a few seconds. When the last player in the server leaves the game, the PlayerRemoving event might not run at all or only partially run, because the server closes straight after that.

I recommend adding a save button before the player leaves the game, or adding DataModel:BindToClose to bind a wait function that waits 10 seconds or until data is saved.

4

I’m not experienced with datastores so I’m not sure how I would do this

5

Check both the succ and err parameters on return from the Set/GetAsync(). The succ essentially means the DataStore was accessible, the err will tell you if the player has data or whether the calls successfully accessed the data.

6

The script works without problem i think you’re changing the Coins value in the client side

1 Like
7

Very simple, I will put it right here for you. Just add this into your script:

game:BindToClose(function()
wait(10)
end)

Of course, there’s a better way to do this but I think this works fine. The only issue with this is that Studio will wait long after exiting playtesting.

I would recommend an autosave feature instead, if you can code that in.

8

Try change the Coins Value in the server side and that will be saved

9

I was changing it on the client side

I forgot there was a server side feature in studio :sob: