DataStore Script

Help and Feedback Code Review
1

Note: I am messing around datastore very recently and I am noob in it so there maybe many mistakes in my code

Code:

--Made By Beastcraft_Gaming--
--30/10/20--
print("Script is working");
--Variables

--Services 
local Players = game:GetService("Players");
local DataStoreService = game:GetService("DataStoreService");

local MyDataStore = DataStoreService:GetDataStore("CashDataStore");

--functions

local function UpdateGui(player)
	local Gui = player:WaitForChild("leaderstats"):WaitForChild("Cash");
	local Value = MyDataStore:GetAsync("Cash"..player.UserId);
	
	Gui.Value = Value;
end


local function OnPlayerAdded(player)
	UpdateGui(player);
    local leaderstats = player:WaitForChild("leaderstats");
    local Data
    local success, errormessage = pcall(function()
        Data = MyDataStore:GetAsync("Cash"..player.UserId);
    end)

    if success then
        if Data then
            leaderstats:WaitForChild("Cash").Value = Data;
        else
            leaderstats:WaitForChild("Cash").Value = 0;
        end
    else
        warn(errormessage)
	end
	local Connection
	local Thread = coroutine.wrap(function()
		Connection = MyDataStore:OnUpdate("Cash"..player.UserId, function(Input)
			UpdateGui(player);

			Connection:Disconnect();
		end);
	end)
	Thread();
end

local function OnPlayerRemoving(player)
    local success, errormessage = pcall(function()
        --MyDataStore:SetAsync("Cash"..player.UserId, player.leaderstats.Cash.Value);
		MyDataStore:UpdateAsync("Cash"..player.UserId,function(OldValue)
			local DataInDataStore
			local success, errormessage = pcall(function()
				DataInDataStore = MyDataStore:GetAsync("Cash"..player.UserId);
			end)

			if success then
				if DataInDataStore ~= nil then
					local NewValue = OldValue or 0

					NewValue = NewValue
					return NewValue
				else
					return nil
				end
			else
				warn(errormessage);
			end	
		end);
    end)

    if success then 
        print("Data successfully saved");
    else
        warn(errormessage);
    end
end


--Events

Players.PlayerAdded:Connect(OnPlayerAdded);
Players.PlayerRemoving:Connect(OnPlayerRemoving);
2

Btw just a side note:
sometimes i get this error:
11:20:57.632 - DataStore request was added to queue. If request queue fills, further requests will be dropped. Try sending fewer requests.Key = Cash1106085551

idk why it happenes it doesn’t show the source and It doesn’t happens everytime.

3

This means you have sent too many Datastore requests in a period of time and Roblox is adding the requests to a queue instead of doing it immediately.

4

So how to fix it? is it because i am testing it too much?

1 Like
5

I remember I had the same error with one of my games and it crashed all servers. I fixed it by using Tables or you can also use Datastore2.

1 Like
6

In the PlayerAdded function you are calling :GetAsync twice.

local Value = MyDataStore:GetAsync("Cash"..player.UserId);

local success, errormessage = pcall(function()
        Data = MyDataStore:GetAsync("Cash"..player.UserId);
    end)
4 Likes
7

Oh my bad

I am doing same things twice.

Let me delete the UpdateGui.

1 Like
8

As there are no wait()s in the above function, its calling :GetAsync() twice at the exact same time. I believe you have to wait around 6 seconds between :GetAsync()s but don’t take my word for it.

1 Like
9

you can save the data once the player leaves with game.Players.PlayerRemoving:Connect() and also when the server shuts down, with game:BindToClose(function() you need to use these both for a proper result

3 Likes
10

I believe this is doing the save on player remove and as of BindToClose I might add that too.

1 Like
11

To fix this you need to add time waiting to datastores, the min time is 15 seconds.

1 Like