GUI Not Disappearing?

asunoandkrito · April 15, 2021, 11:18pm

So I’ve got this medkit that has a GUI instruction frame that shows up if you equip the tool and disappears if you unequip it. But for some reason, after you use the medkit and the tool disappears from the inventory, the GUI stays. I’ve tried using basic code like script.Parent.Instruct.Frame.BackgroundTransparency = 0, but that doesn’t seem to work. Help?

Medkit script:

local Tool = script.Parent;
enabled = true


function onActivated()
	if not enabled  then
		return
	end
	enabled = false
	Tool.Handle.Sound:Play()
	wait(1.5)
	Tool.Handle.Transparency = 1
	

	
	local h = Tool.Parent:FindFirstChild("Humanoid")
	if (h ~= nil) then
		wait(1)
		h.Health = h.Health + 100
	
	end
	
	wait(2.5)
	
	
	script.Parent:Remove()
	
end




function onEquipped()
	Tool.Handle.Equip:Play()
end

script.Parent.Activated:connect(onActivated)
script.Parent.Equipped:connect(onEquipped)

GUI script:

local gui

local equipped = false

script.Parent.Equipped:Connect(function()
	equipped = true
	if not game.Players.LocalPlayer.PlayerGui:FindFirstChild("Instruct") then -- Your Gui's name.
		gui = script.Parent.Instruct:Clone() -- Replace "TestGUI" with your Gui's name.
		gui.Parent = game.Players.LocalPlayer.PlayerGui
	end
end)
script.Parent.Unequipped:Connect(function()
	equipped = false
	gui:Destroy()
end)

Deraxile · April 15, 2021, 11:26pm

As far as I understood, you’re trying to hide(not destroy) the gui when you unequip the tool.
Am I correct?

asunoandkrito · April 15, 2021, 11:27pm

yes. i only want to destroy the GUI when the tool is used up

Deraxile · April 15, 2021, 11:28pm

Where’s the GUI script located?
In the tool itself, or in other location?

asunoandkrito · April 15, 2021, 11:29pm

its in the tool itself, but won’t disappear wehn the tool itself is gone

Deraxile · April 15, 2021, 11:30pm

Do you get any errors?
(character limit)

asunoandkrito · April 15, 2021, 11:32pm

nope, no errors at all. (character limit)

Deraxile · April 15, 2021, 11:37pm

local gui -- this is the problem

local equipped = false

script.Parent.Equipped:Connect(function()
	equipped = true
	if not game.Players.LocalPlayer.PlayerGui:FindFirstChild("Instruct") then 
		gui = script.Parent.Instruct:Clone()
		gui.Parent = game.Players.LocalPlayer.PlayerGui
	end
end)
script.Parent.Unequipped:Connect(function()
	equipped = false
	gui:Destroy()
end)

Take a look at line 1, you’re destroying a variable when you unequip the tool;
You declared gui in the first statement, but you forgot to declare it in the second one.
Try setting it to gui = script.Parent:FindFirstChild("Instruct")

asunoandkrito · April 15, 2021, 11:53pm

gui = script.Parent:FindFirstChild("Instruct")

local equipped = false

script.Parent.Equipped:Connect(function()
	equipped = true
	if not game.Players.LocalPlayer.PlayerGui:FindFirstChild("Instruct") then -- Your Gui's name.
		gui = script.Parent.Instruct:Clone() -- Replace "TestGUI" with your Gui's name.
		gui.Parent = game.Players.LocalPlayer.PlayerGui
	end
end)
script.Parent.Unequipped:Connect(function()
	equipped = false
	gui:Destroy()
end)

it still doesn’t work

Deraxile · April 15, 2021, 11:56pm

Try this:

local gui

local equipped = false

script.Parent.Equipped:Connect(function()
	equipped = true
	if not game.Players.LocalPlayer.PlayerGui:FindFirstChild("Instruct") then -- Your Gui's name.
		gui = script.Parent.Instruct:Clone() -- Replace "TestGUI" with your Gui's name.
		gui.Parent = game.Players.LocalPlayer.PlayerGui
	end
end)
script.Parent.Unequipped:Connect(function()
	gui = game.Players.LocalPlayer.PlayerGui:FindFirstChild("Instruct")
	equipped = false
	gui:Destroy()
end)

JackscarIitt · April 15, 2021, 11:58pm

Can’t you just set the Enabled property of the Gui to false instead of cloning/deleting it every time it gets equipped?

gui = script.Parent:FindFirstChild("Instruct")

local equipped = false

script.Parent.Equipped:Connect(function()
	equipped = true
	if gui.Enabled = false then -- Your Gui's name.
		gui.Enabled = true
	end
end)

script.Parent.Unequipped:Connect(function()
	equipped = false
	gui.Enabled = false
end)

asunoandkrito · April 16, 2021, 1:04am

still doesn’t work. the gui still stays after the tool was been destroyed

Aanggoodluck · April 16, 2021, 1:11am


local Tool = script.Parent;

enabled = true

function onActivated()

    local gui=game.Players.LocalPlayer.PlayerGui:FindFirstChild("Instruct")

    enabled=not enabled

    if enabled==true then

    local h = Tool.Parent:FindFirstChild("Humanoid")

    Tool.Handle.Sound:Play()

    wait(1.5)

    Tool.Handle.Transparency = 1

    if (h ~= nil) then

        wait(1)

        h.Health = h.Health + 100       

    end

    wait(2.5)

    script.Parent:Destroy()

    gui:Destroy()

    else

    end

end

function onEquipped()

    Tool.Handle.Equip:Play()

end

script.Parent.Activated:connect(onActivated)

script.Parent.Equipped:connect(onEquipped)


local gui

local equipped = true

script.Parent.Equipped:Connect(function()

    equipped = not equipped

    if equipped==false then

        if not game.Players.LocalPlayer.PlayerGui:FindFirstChild("Instruct") then -- Your Gui's name. -- Replace "TestGUI" with your Gui's name.

            gui = script.Parent.Instruct:Clone()

            gui.Parent = game.Players.LocalPlayer.PlayerGui

        end

    else

        gui:Destroy()

    end

end)

script.Parent.Unequipped:Connect(function()

    equipped = false

end)

try and tell me if it worked

asunoandkrito · April 16, 2021, 1:33am

i tried the first and second one. none of them worked.

Aanggoodluck · April 16, 2021, 1:34am

can you show the full hierarchy with the script

asunoandkrito · April 16, 2021, 1:39am

Aanggoodluck:

local gui
local equipped = true

script.Parent.Equipped:Connect(function()
	equipped = not equipped
    if equipped==false then
        if not game.Players.LocalPlayer.PlayerGui:FindFirstChild("Instruct") then -- Your Gui's name. -- Replace "TestGUI" with your Gui's name.
            gui = script.Parent.Instruct:Clone()
            gui.Parent = game.Players.LocalPlayer.PlayerGui
        end
    else
	    gui:Destroy()
    end
end)
script.Parent.Unequipped:Connect(function()
	equipped = false
end)

nope it didn’t work at all. i tried both of them

JackscarIitt · April 16, 2021, 1:54am

Boop.mp3

JackscarIitt:

Can’t you just set the Enabled property of the Gui to false instead of cloning/deleting it every time it gets equipped?

gui = script.Parent:FindFirstChild("Instruct")

local equipped = false

script.Parent.Equipped:Connect(function()
	equipped = true
	if gui.Enabled = false then -- Your Gui's name.
		gui.Enabled = true
	end
end)

script.Parent.Unequipped:Connect(function()
	equipped = false
	gui.Enabled = false
end)

I feel like you didn’t even try this oof

asunoandkrito · April 16, 2021, 1:58am

it’s filled with errors, and it didn’t work when i tried it

JackscarIitt · April 16, 2021, 2:01am

Okay what are the errors then?

Aanggoodluck · April 16, 2021, 2:11am

local Tool = script.Parent
player=game.Players.LocalPlayer
enabled = true
equipped = false
instruct = script.Parent.Instruct

function onActivated()
	local humanoid = Tool.Parent:FindFirstChild("Humanoid")
    enabled=not enabled
	if not enabled  then
		return
	end
	Tool.Handle.Sound:Play()
	wait(1.5)
	Tool.Handle.Transparency = 1
	if humanoid ~= nil then
		wait(1)
		humanoid.Health += 100
	end
	wait(2.5)
	Tool:Destroy()
end
script.Parent.Equipped:Connect(function()
	equipped = true
	if player:FindFirstChild("Instruct")~=nil then
        equipped=true
	    Tool.Handle.Equip:Play()
        instruct:Clone()
		instruct.Parent = player.PlayerGui
	end
end)
script.Parent.Unequipped:Connect(function()
	equipped = false
    if player.PlayerGui:FindFirstChild("Instruct")~=nil then
        player:FindFirstChild("Instruct"):Destroy()
    end
end)
script.Parent.Activated:connect(onActivated)

try this