Help with folder children DataStore

Help and Feedback Scripting Support
,
1

I’m trying to save the items (parts) inside of a folder in ReplicatedStorage. I don’t know what’s going on with this DataStore because everything looks right. I’ve tried following tutorials, and seeing free models but none seem to work.

Part is cloned to workspace so I can see that it registers

Script:

local DataStoreService = game:GetService("DataStoreService")
local AbilitiesDataStore = DataStoreService:GetDataStore("AbilitiesDataStore")
local AbilitiesFolder = game.ReplicatedStorage:WaitForChild("MatchVariables").MatchEquipment.Abilities

game.Players.PlayerAdded:Connect(function(Player)
	pcall(function()
		local StoreKey = AbilitiesDataStore:GetAsync(Player.UserId)
		
		if StoreKey then
			for i, SaveObject in pairs(StoreKey) do
				for i, Ability in pairs(AbilitiesFolder:GetChildren()) do
					if Ability then
						Ability:Clone().Parent = game.Workspace
					end
				end
			end
		end
	end)
end)

game.Players.PlayerRemoving:Connect(function(Player)
	pcall(function()
		local SavingObjects = {}
		
		for i, Object in pairs(AbilitiesFolder:GetChildren()) do
			table.insert(SavingObjects, Object.Name)
		end
		
		AbilitiesDataStore:SetAsync(Player.UserId, SavingObjects)
	end)
end)

Thanks,

  • Skylexion
2

Try this:

local DataStoreService = game:GetService("DataStoreService")
local AbilitiesDataStore = DataStoreService:GetDataStore("AbilitiesDataStore")
local AbilitiesFolder = game.ReplicatedStorage:WaitForChild("MatchVariables").MatchEquipment.Abilities

game.Players.PlayerAdded:Connect(function(Player)

    local StoreKey
	local success, err = pcall(function() StoreKey=AbilitiesDataStore:GetAsync(Player.UserId) end)
	if success and StoreKey then
		for _, SaveObject in pairs(StoreKey) do
			for _, Ability in pairs(AbilitiesFolder:GetChildren()) do
				if SaveObject then Ability:Clone().Parent = game.Workspace end
			end
		end
	end
	if not success then warn(err) end	

end)

game.Players.PlayerRemoving:Connect(function(Player)

	local SavingObjects = {}
	for i, Object in pairs(AbilitiesFolder:GetChildren()) do
		table.insert(SavingObjects, Object.Name)
	end
	local success, err = pcall(function() AbilitiesDataStore:SetAsync(Player.UserId, SavingObjects)end) 
    if not success then warn(err) end
end)

I haven’t tested the code but it should work.

I think the problem you were having comes from this:

for i, SaveObject in pairs(StoreKey) do
				for i, Ability in pairs(AbilitiesFolder:GetChildren()) do
					if Ability then
						Ability:Clone().Parent = game.Workspace
					end
				end
			end

but you should be checking for SaveObject not Ability in the second loop.

3 Likes
3

Is you API access enabled at studio?

4

I have it enabled and I’m doing game testing, not studio testing.

5

Didn’t work. Not a single datastore is working for my game expect for a coins datastore.

6

Interesting, free models not works too right?

7

I’m not using free models. 444

8

Potential Problem: Game is closing before the player removing event can fire.

To solve this simply bind a “save all” to game close, with something like this:

game:BindToClose(function()
    for Name, Player in pairs(game.Players:GetPlayers()) do
        pcall(function()
		    local SavingObjects = {}
		
		    for i, Object in pairs(AbilitiesFolder:GetChildren()) do
			    table.insert(SavingObjects, Object.Name)
		    end
		
		    AbilitiesDataStore:SetAsync(Player.UserId, SavingObjects)
	    end)
    end
end)
9

If you used the code I pasted then it will show you any errors from the datastore calls in the output window, did any errors show up?

10

No errors popped up in the output.