Help with my script

Help and Feedback Scripting Support
#1

Hello developers! I am currently trying to make an elimination game, and when you step into a place, AKA, touch a massive invisible, CanCollide off, part, in which inside of it, a local script is placed…

I want it so when you touch the part, the GUI is shown, saying, “You’re in!”

Here is the script below! :arrow_down:

local inpart = script.Parent
local plr = game.Players.LocalPlayer
local text = script.Parent.Parent.intext
text.Visible = false

local function PopupReady(inpart)
text.Visible = true
end

local function PopupGone(inpart)
	text.visible = false
end

inpart.Touched:Connect(PopupReady(plr))

inpart.TouchEnded:Connect(PopupGone(plr))

Currently, the gui pop up is constantly shown, even when you are not ‘inside’ the part.
Help would be good! Thank you in advance! :smiley:

1 Like
#2

A LocalScript inside a part? You should put it in StarterGui or so.

1 Like
#3

The use of region 3 would be better. If you want to use Region3 the LocalScript has to be in StarterPlayerScript.

If you don’t know how to use it this is a good tutorial for beginners Roblox - Play music in different areas - Scripting tutorial (2020 updated version) - YouTube, on the video it’s used to play sounds but you can easelg change it with show/hide the gui

2 Likes
#4

I moved it to screenGui, it stayed the same!

#5

Why isn’t the way I’m doing it working though?

#6

Because when the player touches the part both functions fires and so it keeps on the screen

#7

but I made it so that when the touch ends, visible = false. so it should = false

I am getting more and more confused…
As soon as I press play, it is on the screen, I haven’t touched the part or anything…

#8

No you didn’t as I can see from the script, if you really want to use this method that I don’t suggest to use you will need to add a denounce that gets set to true for an amount of time you want when the part is touched and another one that is set to true when the function that fires when the player is in and to false with the other function, however this is not a good method to detect when the player is in and you should use Region3.

#9

That happens because the function fires even if it’s not a player to touch it to fix it you have to add a check to control if the part is touched by a player for example checking if the part that touches it contain an humanoid

#10

Hi There!
You can simply fix this by putting the script in StarterGui/StarterPlayerScripts and removing the (plr) argument where you call the function
like this -

inpart.Touched:Connect(PopupReady)

inpart.TouchEnded:Connect(PopupGone)

And replace v with capital V of the visible in the 12th line (remember, case sensitive)

#11

That is what the

local plr = game.Players.LocalPlayer

does, and also the

local function PopupReady(inpart)
	text.Visible = true
end

inpart.Touched:Connect(PopupReady(plr))

checks for a plr (game.Players.LocalPlayer) who touches it

#12

Hey there! :wave:

An issue I would assume could occur is that .Touched either doesnt register OR it will simply fire multiple times over and over again. (same with .TouchEnded)

I would suggest you use Region3s to accomplish what you are looking for!

#13

do I need to change it to

local inpart = workspace.inpart

???

#14

No it doesn’t do what you think, you are actually giving to the function a parameter thst it never uses

#15

Probably yes, you have to tell the script where the part and the Gui is.

Also, you don’t have to write “inpart” as a parameter of the function, if you want to make sure the part is touched by a player then add a code that will run the function when a player’s character is touching the part…
Like this -

    local Players = game:GetService("Players")

    local function PopupReady(hit)
    	local player = Players:GetPlayerFromCharacter(hit.Parent)
        if player ~= Players.LocalPlayer then
		return
	end
    	
    		text.Visible = true
    		
    end
#16

would this be correct:

local inpart = workspace.inpart
local plr = game.Players.LocalPlayer
local text = game.StarterGui.ScreenGui.intext

local Players = game:GetService("Players")

local function PopupReady(hit)
	local player = Players:GetPlayerFromCharacter(hit.Parent)
	if player then
		text.Visible = true
	end
end


inpart.Touched:Connect(PopupReady)

I didn’t do PopupGone on that script…

#17

Yep, this will work, try it by completing the PopupGone function.

#18

try to add a variable that acts like a debounce like
local PartTouched = false and set it where if the PartTouched = false when the player touches it then you can make the text visible you can do the same for the touch ended event. so your script would kinda look like this

local inpart = script.Parent
local plr = game.Players.LocalPlayer
local text = script.Parent.Parent.intext
local PartTouched = false
text.Visible = false

local function PopupReady(inpart)
if PartTouched == false then
        text.Visible = true
    end
end

local function PopupGone(inpart)
    if InPart == true then
	   text.visible = false
    end
end

inpart.Touched:Connect(PopupReady(plr))

inpart.TouchEnded:Connect(PopupGone(plr))
#19

Hey! I have got this script that doesn’t work!

 local inpart = script.Parent
local plr = game.Players.LocalPlayer
local text = script.Parent.Parent.intext
local PartTouched = false
text.Visible = false

local inpart = workspace.inpart
local plr = game.Players.LocalPlayer
local text = game.StarterGui.ScreenGui.intext

local Players = game:GetService("Players")

local function PopupReady(hit)
	local player = Players:GetPlayerFromCharacter(hit.Parent)
	if player then
		text.Visible = true
		print("Stepped in!")
	end
end

local function PopupGone(hit)
	local player = Players:GetPlayerFromCharacter(hit.Parent)
	if player then
		print("Stepped out!")
		text.Visible = false
	end
end


inpart.Touched:Connect(PopupReady)

inpart.Touched:Connect(PopupReady)

This is where the parts are positioned:

Explorer_help
Explorer_help576×681 85.3 KB

any help with this?

#20

you need something like
local player = game.Players.LocalPlayer
in the touch connections
if player == plr then
(your stuff)
also u need the params for popupgone and the other one as (plr, part)
and u need if part.Parent:FindFirstChild(“Humanoid”)