How do I stop reloading when tool is unequipped?

Bikereh · October 11, 2021, 10:43pm

So I have this reloading script which runs when the reload remote event fires.

--// Variables \\--

-- Variables --
local tool = script.Parent

-- Values --
local equipped = false

local reloading = tool:WaitForChild("Reloading")

local ammoFolder = tool.Ammo
local mag = ammoFolder.Mag
local maxAmmo = ammoFolder.MaxAmmo

--// Code \\--

-- Equipping --
tool.Equipped:Connect(function()
	equipped = true
end)

tool.Unequipped:Connect(function()
	equipped = false
	reloading.Value = false
end)

-- Reloading --
tool:WaitForChild("Reload").OnServerEvent:Connect(function(plr)
	if reloading.Value or not equipped or mag.Value == maxAmmo.Value then return end
	
	reloading.Value = true
	
	wait(0.5)
	tool.BodyAttach.MagOut:Play()
	wait(0.53)
	tool.BodyAttach.MagIn:Play()
	wait(0.6)
	tool.BodyAttach.BoltBack:Play()
	wait(0.27)
	tool.BodyAttach.BoltForward:Play()
	wait(0.77)
	
	-- Handle Ammo --
	mag.Value = maxAmmo.Value
		
	reloading.Value = false
end)

Does anyone know how to stop reload when the player unequips the tool?

tell me if you need more info (i deleted everything about firing the gun just to make the code easier to understand)

GrayzcaIe · October 11, 2021, 10:44pm

Instead of using the “or” operator here, you might consider using “and”

Kaid3n22 · October 11, 2021, 10:46pm

add an if statement to check if the reloading value is still true.

	if reloading.Value == true then
		mag.Value = maxAmmo.Value
		
		reloading.Value = false
	end

cjthekiller1 · October 11, 2021, 10:47pm

You can simply tie the script with a tool.equipped function so it only occurs when the tool is equipped.

Bikereh · October 11, 2021, 10:48pm

But then if the player unequips after the if statements passes if wont detect it so it won’t stop.

Bikereh · October 11, 2021, 10:48pm

I don’t think that makes a difference.

Kaid3n22 · October 11, 2021, 10:49pm

Right here, you changed the reloading value to false after unequipping the tool. So, if they started to reload, it would be turned to false and not add the ammo.

cjthekiller1 · October 11, 2021, 10:51pm

Here is what I meant with tying in a equipped function.

local activateequip;
--This is called a connection. 
activateequip = tool.Equipped:Connect(function()
-- your equip script here
end)
tool.Unequipped:Connect(function()
activateequip:Disconnect()
--when tool is unequipped, it disconnects the equipped function rendering it disabled
end)

Bikereh · October 11, 2021, 10:54pm

I did this:

--// Variables \\--

-- Variables --
local tool = script.Parent

-- Values --
local equipped = false

local reloading = tool:WaitForChild("Reloading")

local ammoFolder = tool.Ammo
local mag = ammoFolder.Mag
local maxAmmo = ammoFolder.MaxAmmo

--// Code \\--
local func

-- Equipping --
tool.Equipped:Connect(function()
	equipped = true
	
	func = tool:WaitForChild("Reload").OnServerEvent:Connect(function(plr)
		if reloading.Value or not equipped or mag.Value == maxAmmo.Value then return end

		reloading.Value = true

		wait(0.5)
		tool.BodyAttach.MagOut:Play()
		wait(0.53)
		tool.BodyAttach.MagIn:Play()
		wait(0.6)
		tool.BodyAttach.BoltBack:Play()
		wait(0.27)
		tool.BodyAttach.BoltForward:Play()
		wait(0.77)

		-- Handle Ammo --
		mag.Value = maxAmmo.Value

		reloading.Value = false
	end)
end)

tool.Unequipped:Connect(function()
	equipped = false
	reloading.Value = false
	
	func:Disconnect()
end)

-- Reloading --
tool:WaitForChild("Reload").OnServerEvent:Connect(function(plr)
	if reloading.Value or not equipped or mag.Value == maxAmmo.Value then return end
	
	reloading.Value = true
	
	wait(0.5)
	tool.BodyAttach.MagOut:Play()
	wait(0.53)
	tool.BodyAttach.MagIn:Play()
	wait(0.6)
	tool.BodyAttach.BoltBack:Play()
	wait(0.27)
	tool.BodyAttach.BoltForward:Play()
	wait(0.77)
	
	-- Handle Ammo --
	mag.Value = maxAmmo.Value
		
	reloading.Value = false
end)

It didn’t work. (i think that’s what you meant)

cjthekiller1 · October 11, 2021, 10:57pm

Remove “equipped” and “unequipped” variables, also you need two connections as you have another function below for reloading

cjthekiller1 · October 11, 2021, 10:57pm

Also please make the connection the tool equipped function

Bikereh · October 11, 2021, 10:58pm

Sorry, but can you show me how to do that. lol

Bikereh · October 11, 2021, 11:00pm

Oh sorry i tried it again but with this:

--// Variables \\--

-- Variables --
local tool = script.Parent

-- Values --
local equipped = false

local reloading = tool:WaitForChild("Reloading")

local ammoFolder = tool.Ammo
local mag = ammoFolder.Mag
local maxAmmo = ammoFolder.MaxAmmo

--// Code \\--
local func

-- Equipping --
tool.Equipped:Connect(function()
	equipped = true
	
	func = tool:WaitForChild("Reload").OnServerEvent:Connect(function(plr)
		if reloading.Value or not equipped or mag.Value == maxAmmo.Value then return end

		reloading.Value = true

		wait(0.5)
		tool.BodyAttach.MagOut:Play()
		wait(0.53)
		tool.BodyAttach.MagIn:Play()
		wait(0.6)
		tool.BodyAttach.BoltBack:Play()
		wait(0.27)
		tool.BodyAttach.BoltForward:Play()
		wait(0.77)

		-- Handle Ammo --
		mag.Value = maxAmmo.Value

		reloading.Value = false
	end)
end)

tool.Unequipped:Connect(function()
	equipped = false
	reloading.Value = false
	
	func:Disconnect()
end)

But I got the same results.

cjthekiller1 · October 11, 2021, 11:01pm

--// Variables \\--

-- Variables --
local tool = script.Parent

-- Values --
local equipped = false

local reloading = tool:WaitForChild("Reloading")

local ammoFolder = tool.Ammo
local mag = ammoFolder.Mag
local maxAmmo = ammoFolder.MaxAmmo

--// Code \\--
local func;

-- Equipping --
func = tool.Equipped:Connect(function()
	equipped = true
	
	tool:WaitForChild("Reload").OnServerEvent:Connect(function(plr)
		if reloading.Value or not equipped or mag.Value == maxAmmo.Value then return end

		reloading.Value = true

		wait(0.5)
		tool.BodyAttach.MagOut:Play()
		wait(0.53)
		tool.BodyAttach.MagIn:Play()
		wait(0.6)
		tool.BodyAttach.BoltBack:Play()
		wait(0.27)
		tool.BodyAttach.BoltForward:Play()
		wait(0.77)

		-- Handle Ammo --
		mag.Value = maxAmmo.Value

		reloading.Value = false
	end)
end)

tool.Unequipped:Connect(function()
	equipped = false
	reloading.Value = false
	
	func:Disconnect()
end)

cjthekiller1 · October 11, 2021, 11:01pm

Try that, tell me if any errors occur because it’s quite hard to tell on the DevForum

cjthekiller1 · October 11, 2021, 11:02pm

You need to add ; after func other wise it is just a variable, not a connection

Bikereh · October 11, 2021, 11:08pm

no errors it’s the same as before (i also added the ; after func)

Bikereh · October 11, 2021, 11:09pm

I think its because the reloading has waits inside of it. I put them there because my sounds are all seperate

cjthekiller1 · October 11, 2021, 11:09pm

Can I ask why you have two reloading functions?

Bikereh · October 11, 2021, 11:10pm

i took the other one away but the same thing happens