How to convert userinput function into a local function

NoobInAFishTank · October 11, 2024, 6:13pm

how would i convert this part of script into a function like “function example()”

UserInputService.InputBegan:Connect(function(input, gameProcessed)
	if gameProcessed then return end
	if input.KeyCode == Enum.KeyCode.E and not cooldown then
		shieldActivatedEvent:FireServer()
		local shieldGui = player:FindFirstChild("PlayerGui"):FindFirstChild("ShieldGui")
		if shieldGui then
			local shieldImage = shieldGui:FindFirstChild("ImageLabel")
			if shieldImage then
				shieldImage.Visible = true
			end
		end
		cooldown = true
		task.wait(50)
		cooldown = false
	end
end)

thornedmaiden · October 11, 2024, 6:21pm

Just make the function for the input,

local function Input(Input, Processed)
if Processed then return end
	if input.KeyCode == Enum.KeyCode.E and not cooldown then
		shieldActivatedEvent:FireServer()
		local shieldGui = player:FindFirstChild("PlayerGui"):FindFirstChild("ShieldGui")
		if shieldGui then
			local shieldImage = shieldGui:FindFirstChild("ImageLabel")
			if shieldImage then
				shieldImage.Visible = true
			end
		end
		cooldown = true
		task.wait(50)
		cooldown = false
	end
end

UserInputService.InputBegan:Connect(Input)

MisterGrinch2017 · October 11, 2024, 6:22pm

The code you provided works, but if you want it to be consistent with some format, you can do it like this:

local function EXAMPLE_NAME(input, gameProcessed)
	if gameProcessed then return end
	if input.KeyCode == Enum.KeyCode.E and not cooldown then
		shieldActivatedEvent:FireServer()
		local shieldGui = player:FindFirstChild("PlayerGui"):FindFirstChild("ShieldGui")
		if shieldGui then
			local shieldImage = shieldGui:FindFirstChild("ImageLabel")
			if shieldImage then
				shieldImage.Visible = true
			end
		end
		cooldown = true
		task.wait(50)
		cooldown = false
	end
end)

UserInputService.InputBegan:Connect(EXAMPLE_NAME)

If I remember correctly, the parameters may not pass so you have to do this

UserInputService.InputBegan:Connect(function(...)
    EXAMPLE_NAME(...)
end)

NoobInAFishTank · October 11, 2024, 6:24pm

i tried both but if i use those it wont even work upon pressing E

thornedmaiden · October 11, 2024, 6:26pm

Are you using a localscript? The normal way I handle keybind abilities in my game is this way.

NoobInAFishTank · October 11, 2024, 6:27pm

its a local script in starterplayerscripts

thornedmaiden · October 11, 2024, 6:28pm

Is there any input at all or are you loading the character at any point in the game?

NoobInAFishTank · October 11, 2024, 6:28pm

yes i am should i send full orginial script

thornedmaiden · October 11, 2024, 6:29pm

Yes that would be helpful if you sent the full code

NoobInAFishTank · October 11, 2024, 6:31pm

local Players = game:GetService("Players")
local ReplicatedStorage = game:GetService("ReplicatedStorage")
local CAS = game:GetService("ContextActionService")
local UserInputService = game:GetService("UserInputService")

local player = Players.LocalPlayer
local shieldActivatedEvent = ReplicatedStorage:WaitForChild("ShieldActivated")
local cooldown = false

UserInputService.InputBegan:Connect(function(input, gameProcessed)
	if gameProcessed then return end
	if input.KeyCode == Enum.KeyCode.E and not cooldown then
		shieldActivatedEvent:FireServer()
		local shieldGui = player:FindFirstChild("PlayerGui"):FindFirstChild("ShieldGui")
		if shieldGui then
			local shieldImage = shieldGui:FindFirstChild("ImageLabel")
			if shieldImage then
				shieldImage.Visible = true
			end
		end
		cooldown = true
		task.wait(50)
		cooldown = false
	end
end)

player.CharacterAdded:Connect(function()
    cooldown = false
end)

shieldActivatedEvent.OnClientEvent:Connect(function()
	local shieldGui = player:FindFirstChild("PlayerGui"):FindFirstChild("ShieldGui")
	if shieldGui then
		local shieldImage = shieldGui:FindFirstChild("ImageLabel")
		if shieldImage then
			shieldImage.Visible = false
		end
	end
end)

CAS:BindAction("ShieldAction", ,true, Enum.KeyCode.E)
CAS:SetTitle("ShieldAction", "Shield")
CAS:SetPosition("ShieldAction", UDim2.new{0.908, 0},{0.6, 0})

NoobInAFishTank · October 11, 2024, 6:32pm

also now if i press E it wont work

MrOnlyKemal · October 11, 2024, 6:33pm

Remove this line

CAS:BindAction("ShieldAction", ,true, Enum.KeyCode.E)

or bind a real function

thornedmaiden · October 11, 2024, 6:34pm


local Players = game:GetService("Players")
local ReplicatedStorage = game:GetService("ReplicatedStorage")
local CAS = game:GetService("ContextActionService")
local UserInputService = game:GetService("UserInputService")

local player = Players.LocalPlayer
local shieldActivatedEvent = ReplicatedStorage:WaitForChild("ShieldActivated")
local cooldown = false

local function Input(Input, Gpe)
	if Gpe then return end
	if Input.KeyCode == Enum.KeyCode.E and not cooldown then
		shieldActivatedEvent:FireServer()
		local shieldGui = player:FindFirstChild("PlayerGui"):FindFirstChild("ShieldGui")
		if shieldGui then
			local shieldImage = shieldGui:FindFirstChild("ImageLabel")
			if shieldImage then
				shieldImage.Visible = true
			end
		end
		cooldown = true
		task.wait(50)
		cooldown = false
	end
end

player.CharacterAdded:Connect(function()
	cooldown = false
	--
	pcall(function()
		UserInputService.InputBegan:Connect(function(...)
			Input(...)
		end)
	end)
end)

shieldActivatedEvent.OnClientEvent:Connect(function()
	local shieldGui = player:FindFirstChild("PlayerGui"):FindFirstChild("ShieldGui")
	if shieldGui then
		local shieldImage = shieldGui:FindFirstChild("ImageLabel")
		if shieldImage then
			shieldImage.Visible = false
		end
	end
end)

CAS:BindAction("ShieldAction",true, Enum.KeyCode.E)
CAS:SetTitle("ShieldAction", "Shield")
CAS:SetPosition("ShieldAction", UDim2.new{0.908, 0},{0.6, 0})

NoobInAFishTank · October 11, 2024, 6:34pm

thats the whole point of this post, i want to convert the input into a function

MrOnlyKemal · October 11, 2024, 6:36pm

local Players = game:GetService("Players")
local ReplicatedStorage = game:GetService("ReplicatedStorage")
local CAS = game:GetService("ContextActionService")
local UserInputService = game:GetService("UserInputService")

local player = Players.LocalPlayer
local shieldActivatedEvent = ReplicatedStorage:WaitForChild("ShieldActivated")
local cooldown = false

local function inputfunc()
if not cooldown then
shieldActivatedEvent:FireServer()

		local shieldGui = player:FindFirstChild("PlayerGui"):FindFirstChild("ShieldGui")
		if shieldGui then
			local shieldImage = shieldGui:FindFirstChild("ImageLabel")
			if shieldImage then
				shieldImage.Visible = true
			end
		end
		cooldown = true
		task.wait(50)
		cooldown = false
end
end

UserInputService.InputBegan:Connect(function(input, gameProcessed)
	if gameProcessed then return end
	if input.KeyCode == Enum.KeyCode.E  then
		 inputfunc()
	end
end)

player.CharacterAdded:Connect(function()
    cooldown = false
end)

shieldActivatedEvent.OnClientEvent:Connect(function()
	local shieldGui = player:FindFirstChild("PlayerGui"):FindFirstChild("ShieldGui")
	if shieldGui then
		local shieldImage = shieldGui:FindFirstChild("ImageLabel")
		if shieldImage then
			shieldImage.Visible = false
		end
	end
end)

CAS:BindAction("ShieldAction", inputfunc ,true, Enum.KeyCode.E)
CAS:SetTitle("ShieldAction", "Shield")
CAS:SetPosition("ShieldAction", UDim2.new{0.908, 0},{0.6, 0})

NoobInAFishTank · October 11, 2024, 6:36pm

error is: 22:35:56.799 Players.NoobInAFishTank.PlayerScripts.ShieldActivationClient:12: attempt to index nil with ‘KeyCode’ - Client - ShieldActivationClient:12

NoobInAFishTank · October 11, 2024, 6:37pm

tsym bro this works with both E, and a button appears that when presses it happens

system · October 25, 2024, 6:47pm

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.