How to identify a table from another function

planeboy2021 · February 16, 2025, 8:14am

Hello!

I have got a problem in my script where a table is in one function but a table.remove is in another.

Example:
Lets say we have got a table called: mytable
And mytable is in a function:

game.Players.PlayerRemoving:Connect(function(plr)
	local mytable = {
		"cat",
		"dog",
		"attack helicopter"
	}
end)

But we have another function where we want to remove something from that table like this:

game.Players.PlayerAdded:Connect(function(plr)
	table.remove(mytable, "dog")
end)

But roblox studio doesn’t recognise mytable in the PlayerAdded function.
How do we fix this so it will recognise mytable in another function?

Full Example Script (Server)

game.Players.PlayerAdded:Connect(function(plr)
	table.remove(mytable, "dog")
end)

game.Players.PlayerRemoving:Connect(function(plr)
	local mytable = {
		"cat",
		"dog",
		"attack helicopter"
	}
end)

SeargentAUS · February 16, 2025, 8:17am

If you want the table to be identical for all players, you could move the declaration outside of the connections:

local mytable = {
		"cat",
		"dog",
		"attack helicopter"
	}
game.Players.PlayerAdded:Connect(function(plr)
	table.remove(mytable, "dog")
end)
game.Players.PlayerRemoving:Connect(function(plr)
	
end)

If, however, you want it to be specific to the player, then I would recommend having a dictionary (with the player as the key):

local Tables = {}

game.Players.PlayerAdded:Connect(function(plr)
	table.remove(Tables[plr], "dog")
end)
game.Players.PlayerRemoving:Connect(function(plr)
	Tables[plr] = {
		"cat",
		"dog",
		"attack helicopter"
	}
end)

planeboy2021 · February 16, 2025, 8:27am

An error appears.

18:21:45.789 ServerScriptService.ToolSaving:40: invalid argument #1 to ‘remove’ (table expected, got nil) - Server - ToolSaving:40

On this line:

table.remove(tools[plr], tool)

here is the table

local tools = {}

SeargentAUS · February 16, 2025, 8:27am

Can you please show me the entirety of the code?

planeboy2021 · February 16, 2025, 8:29am

local Players = game:GetService("Players")
local DataStoreService = game:GetService("DataStoreService")
local ServerStorage = game:GetService("ServerStorage")
local RepliStorage = game:GetService("ReplicatedStorage")

local player_data = DataStoreService:GetDataStore("TestData1")
local RemoveSoldItem = RepliStorage.Remotes.RemoveSoldItem

local toolsInstance = ServerStorage.Tools

local tools = {}

Players.PlayerAdded:Connect(function(client)
	client.CharacterAdded:Connect(function(plr)
		local key = "client_" .. client.UserId
		local inventory = player_data:GetAsync(key) 
		print(inventory)
		
		
		
		for i, name in inventory or {} do
			local tool = game:GetService("ReplicatedStorage").ItemAssets:FindFirstChild(name)
			local Backpack = client.Backpack
			

			if tool then
				print(tool.Name)
				local Clonedtool = tool:Clone()
				Clonedtool.Name = tool.Name
				Clonedtool.Parent = Backpack
				print("tool cloned")
			else
				warn("Item could not be cloned")
			end
		end
		
		RemoveSoldItem.OnServerEvent:Connect(function(plr, tool)
			local Backpack = client.Backpack
			local tool = Backpack:FindFirstChild(tool)
			table.remove(tools[plr], tool)
			print("Removed "..tool)
		end)
		
	end)
	

end)

Players.PlayerRemoving:Connect(function(client)
	local key = "client_" .. client.UserId
	tools[client] = { }

	local Character = client.Character
	if Character then
		for X, item in Character:GetChildren() do
			if not item:IsA("Tool") then continue end

			table.insert(tools[client], item.Name)
		end
	end

	for _, item in client.Backpack:GetChildren() do
		table.insert(tools, item.Name)
		
	end
	
	player_data:UpdateAsync(key, function(prev)
		
		return tools
		
	end)
end)

SeargentAUS · February 16, 2025, 8:30am

At no point are you defining tools[player] (or tools[client]). You need to define it with the default values at some point within the PlayerAdded command

planeboy2021 · February 16, 2025, 8:55am

How would I do that???

planeboy2021 · February 16, 2025, 9:01am

OK then what next?

FunnyDevGames · February 16, 2025, 9:15am

What is your problem currently?

planeboy2021 · February 16, 2025, 9:18am

Ive got this error:
19:17:25.980 ServerScriptService.ToolSaving:25: invalid argument #2 (string expected, got table) - Server - ToolSaving:25

on this line:

local tool = game:GetService("ReplicatedStorage").ItemAssets[name]

Full (server) script:

local Players = game:GetService("Players")
local DataStoreService = game:GetService("DataStoreService")
local ServerStorage = game:GetService("ServerStorage")
local RepliStorage = game:GetService("ReplicatedStorage")

local player_data = DataStoreService:GetDataStore("TestData1")
local RemoveSoldItem = RepliStorage.Remotes.RemoveSoldItem

local toolsInstance = ServerStorage.Tools

local tools = {}

Players.PlayerAdded:Connect(function(client)
	client.CharacterAdded:Connect(function(plr)
		tools[client] = {}
		
		local key = "client_" .. client.UserId
		local inventory = player_data:GetAsync(key) 
		print(inventory)
		
		
		
		for i, name in inventory do
			print(name)
			local tool = game:GetService("ReplicatedStorage").ItemAssets[name]
			local Backpack = client.Backpack
			print(tool)

			if tool then
				print(tool.Name)
				local Clonedtool = tool:Clone()
				Clonedtool.Name = tool.Name
				Clonedtool.Parent = Backpack
				print("tool cloned")
			else
				warn("Item could not be cloned")
			end
		end
		
		RemoveSoldItem.OnServerEvent:Connect(function(plr, tool)
			local Backpack = client.Backpack
			local tool = Backpack:FindFirstChild(tool)
			table.remove(tools[client], tool)
			print("Removed "..tool)
		end)
		
	end)
	

end)

Players.PlayerRemoving:Connect(function(client)
	local key = "client_" .. client.UserId
	tools[client] = { }

	local Character = client.Character
	if Character then
		for X, item in Character:GetChildren() do
			if not item:IsA("Tool") then continue end

			table.insert(tools[client], item.Name)
		end
	end

	for _, item in client.Backpack:GetChildren() do
		table.insert(tools[client], item.Name)
		
	end
	print(tools[client])
	player_data:UpdateAsync(key, function(prev)
		
		return tools
		
	end)
end)

FunnyDevGames · February 16, 2025, 9:19am

You should use FindFirstChild() method.

CelestialDominio · February 16, 2025, 9:20am

its table.remove(mytable, table.find(mytable, “dog”))

FunnyDevGames · February 16, 2025, 9:20am

Like this:

local tool = game:GetService("ReplicatedStorage").ItemAssets:FindFirstChild(name)

planeboy2021 · February 16, 2025, 9:21am

I will be back in 15 mins.

BonesIsUseless · February 16, 2025, 9:24am

guys if the error says it got a table, that means the given value is a table.

table.find() doesn’t return a table
:FindFirstChild() doesn’t stop a table from being passed

name must be a table
check the data that’s being printed Planey

planeboy2021 · February 16, 2025, 9:29am

This is what name prints

planeboy2021 · February 16, 2025, 9:30am

Here is what appeared in my output

19:30:36.079 argument #1 expects a string, but table was passed - Server - ToolSaving:25

FunnyDevGames · February 16, 2025, 9:31am

Then, that may be a table I think.

planeboy2021 · February 16, 2025, 9:31am

Yes it is but it is supposed to be a string. How do I fix this?

SeargentAUS · February 16, 2025, 9:32am

The (or an) issue is on line 72. You are returning tools when you should be returning tools[client].