I need help with this script

Official_ProGamerYT · January 25, 2021, 5:42pm

I want to achieve a double jump system where when the play jumps twice it does it twice
the issue is when the player hold the jump button or space bar it doubles
i have tried to fix it

why does it double jump when you hold jump here is some of the script

jumpEvent.Event:Connect(function()
    if onGround == false then
        script.Parent.Enabled = true
    end
    
    if jumpsLeft > 0 and char and debounce == false then
        if onGround == false then
            debounce = true
            jumpsLeft -= 1
            label.Text = jumpsLeft.."/"..maxJumps
            char.Humanoid.JumpPower = 50
            
            bar:TweenSize(UDim2.new(jumpsLeft / maxJumps,0,1,0),
                Enum.EasingDirection.InOut,
                Enum.EasingStyle.Quad,
                .1
            )
            if jumpsLeft == 0 then
                delay(.1, function()
                    bar.Visible = false
                end)
            end
            char.Humanoid.JumpPower = 150
            anim:Play()
            char.Humanoid:ChangeState(Enum.HumanoidStateType.Jumping)
            delay(0.3, function()
                debounce = false
            end)
        end
    end
end)

userInput.JumpRequest:Connect(function()
    jumpEvent:Fire()
end)

Please don’t write the full script

Thank you

Vrythex · January 25, 2021, 6:00pm

The documentation actually mentions this: UserInputService.JumpRequest (roblox.com). Looks like that page recommends using a debounce to fix it.

EDIT:
It looks like you set up a boolean to handle this yourself. If you want to do it this way, make sure you define the variable “debounce” outside of the event.

Official_ProGamerYT · January 25, 2021, 9:11pm

it still doesnt work it is doing the same thing

Vrythex · January 25, 2021, 9:34pm

Would you mind posting the full script, with your edits?

Official_ProGamerYT · January 25, 2021, 9:38pm

ok

local userInput = game:GetService("UserInputService")

local player = game.Players.LocalPlayer

repeat wait() until player.Character

local char = player.Character
player.CharacterAdded:Connect(function(c)
	char = c
end)

local jumpEvent = script.Parent.Jumped
local animation = script:WaitForChild("Boost")
local anim = char.Humanoid:LoadAnimation(animation)
local upgradeEvent = script.Parent.Upgrade

local background = script.Parent.Background
local bar = background.Bar
local label = script.Parent.Label

local maxJumps = player.DJumps.MaxDJumps.Value
local jumpsLeft = maxJumps

local onGround = false
local debounce = false

coroutine.resume(coroutine.create(function()
	while wait(.1) do
		local ray = Ray.new(char.HumanoidRootPart.Position, Vector3.new(0,-3,0))
		local hit,pos = workspace:FindPartOnRayWithIgnoreList(ray,{char})
		
		if hit then
			onGround = true
			
			bar:TweenSize(UDim2.new(1,0,1,0),
				Enum.EasingDirection.InOut,
				Enum.EasingStyle.Quad,
				.1
			)
			
			maxJumps = player.DJumps.MaxDJumps.Value
			char.Humanoid.JumpPower = 50
			script.Parent.Enabled = false
			bar.Visible = true
			jumpsLeft = maxJumps
			label.Text = jumpsLeft.."/"..maxJumps
		else
			onGround = false
		end
	end
end))

upgradeEvent.Event:Connect(function(newValue)
	maxJumps = newValue
end)

local db = 0

if db == 2 then
	wait(3)
	db = 0
else
	jumpEvent.Event:Connect(function()
		if onGround == false then
			script.Parent.Enabled = true
		end

		if jumpsLeft > 0 and char and debounce == false then
			db = db + 1
			if onGround == false then
				debounce = true
				jumpsLeft -= 1
				label.Text = jumpsLeft.."/"..maxJumps
				char.Humanoid.JumpPower = 50

				bar:TweenSize(UDim2.new(jumpsLeft / maxJumps,0,1,0),
					Enum.EasingDirection.InOut,
					Enum.EasingStyle.Quad,
					.1
				)
				if jumpsLeft == 0 then
					delay(.1, function()
						bar.Visible = false
					end)
				end
				char.Humanoid.JumpPower = 150
				anim:Play()
				char.Humanoid:ChangeState(Enum.HumanoidStateType.Jumping)
				delay(0.3, function()
				end)
			end
		end
	end)

	userInput.JumpRequest:Connect(function()
		jumpEvent:Fire()
	end)
	end

the problem is now when the player loads in it works and then when the player try to double it doesn’t work

Vrythex · January 25, 2021, 10:20pm

Well you are not setting “debounce” back to false from what I can see. It looks like you removed that in the updated script. If it still double jumps by holding jump, would you mind placing a print(debounce) inside the event, just to double check?

Official_ProGamerYT · January 25, 2021, 10:23pm

Here is the script before i changed it

local userInput = game:GetService("UserInputService")

local player = game.Players.LocalPlayer

repeat wait() until player.Character

local char = player.Character
player.CharacterAdded:Connect(function(c)
	char = c
end)

local jumpEvent = script.Parent.Jumped
local animation = script:WaitForChild("Boost")
local anim = char.Humanoid:LoadAnimation(animation)
local upgradeEvent = script.Parent.Upgrade

local background = script.Parent.Background
local bar = background.Bar
local label = script.Parent.Label

local maxJumps = player.DJumps.MaxDJumps.Value
local jumpsLeft = maxJumps

local onGround = false
local debounce = false

coroutine.resume(coroutine.create(function()
	while wait(.1) do
		local ray = Ray.new(char.HumanoidRootPart.Position, Vector3.new(0,-3,0))
		local hit,pos = workspace:FindPartOnRayWithIgnoreList(ray,{char})
		
		if hit then
			onGround = true
			
			bar:TweenSize(UDim2.new(1,0,1,0),
				Enum.EasingDirection.InOut,
				Enum.EasingStyle.Quad,
				.1
			)
			
			maxJumps = player.DJumps.MaxDJumps.Value
			char.Humanoid.JumpPower = 50
			script.Parent.Enabled = false
			bar.Visible = true
			jumpsLeft = maxJumps
			label.Text = jumpsLeft.."/"..maxJumps
		else
			onGround = false
		end
	end
end))

upgradeEvent.Event:Connect(function(newValue)
	maxJumps = newValue
end)

jumpEvent.Event:Connect(function()
	if onGround == false then
		script.Parent.Enabled = true
	end
	
	if jumpsLeft > 0 and char and debounce == false then
		if onGround == false then
			debounce = true
			jumpsLeft -= 1
			label.Text = jumpsLeft.."/"..maxJumps
			char.Humanoid.JumpPower = 50
			
			bar:TweenSize(UDim2.new(jumpsLeft / maxJumps,0,1,0),
				Enum.EasingDirection.InOut,
				Enum.EasingStyle.Quad,
				.1
			)
			if jumpsLeft == 0 then
				delay(.1, function()
					bar.Visible = false
				end)
			end
			char.Humanoid.JumpPower = 150
			anim:Play()
			char.Humanoid:ChangeState(Enum.HumanoidStateType.Jumping)
			delay(0.3, function()
				debounce = false
			end)
		end
	end
end)

userInput.JumpRequest:Connect(function()
	jumpEvent:Fire()
end)

Vrythex · January 25, 2021, 10:25pm

When you hold down jump, does it instantly double jump, or does it wait 0.3 seconds before double jumping?

Official_ProGamerYT · January 25, 2021, 10:36pm

do you want to play the game? and see what happens

Official_ProGamerYT · January 25, 2021, 10:36pm

Boxing Champions (BETA) - Roblox

SOTR654 · January 25, 2021, 10:40pm

This LocalScript works.
https://www.roblox.com/library/3241662825/Doble-jump

Vrythex · January 25, 2021, 10:59pm

Try increasing the time before setting “debounce” to false. Let me know if that fixes it.

Official_ProGamerYT · January 25, 2021, 11:02pm

how should I do that please could you tell me

Vrythex · January 25, 2021, 11:10pm

Change

delay(0.3, function()
   debounce = false
end)

to

delay(1, function()
	debounce = false
end)

Official_ProGamerYT · January 25, 2021, 11:17pm

does work still when I hold the jump button it does a double

Vrythex · January 25, 2021, 11:23pm

Does it wait for one second before doing the double jump, or does it immediately happen?

Official_ProGamerYT · January 25, 2021, 11:25pm

no (i am just doing this because i have to write 30 words)

Vrythex · January 25, 2021, 11:30pm

Alright. If you place a print(debounce) inside of your event, what does it return? You also may want to check for the state change to falling, and set “debounce” to false when that occurs, instead of waiting for a set period of time: Humanoid.StateChanged (roblox.com).

EDIT:
You may be having an issue because of the script detecting when a player is on the ground. Try changing the Vector3 to Vector3.new(0, -4, 0). Add a wait(0.5) before onGround = false. Let me know if this fixes it.

I know that you did not want a script given to you, but if it is still not working you might cross reference your version of the script, with this one inside of StarterCharacterScripts (which works for me on a baseplate):

local userInput = game:GetService("UserInputService")

local player = game.Players.LocalPlayer


local char = script.Parent

local maxJumps = 1
local jumpsLeft = maxJumps

local onGround = true
local debounce = false

char.Humanoid.StateChanged:connect(function(Old, New)
	if New == Enum.HumanoidStateType.Landed then
		onGround = true
		char.Humanoid.JumpPower = 50
		jumpsLeft = maxJumps
	elseif (New == Enum.HumanoidStateType.Jumping) or (New == Enum.HumanoidStateType.Freefall) then
		print("Changed")
		wait(0.3)
		onGround = false
	end
end)



function jumpEvent()
	if onGround == false then
	else
	end

	if (jumpsLeft > 0) and (char) and (debounce == false) then
		print("JumpsLeft:"..jumpsLeft.." debounce:"..tostring(debounce))
		if onGround == false then
			debounce = true
			jumpsLeft -= 1
			char.Humanoid.JumpPower = 150


			char.Humanoid:ChangeState(Enum.HumanoidStateType.Jumping)
			print("DOUBLE")
			wait(0.3)
			print(debounce)
			debounce = false
		end
	end
end

userInput.JumpRequest:Connect(function()
	jumpEvent()
end)

Official_ProGamerYT · January 26, 2021, 7:32pm

This worked thank you this has really helped