In pairs only gets 1 player

Help and Feedback Scripting Support
1

  1. What do you want to achieve? I want to achieve a script that loops thru all the players.

  2. What is the issue? My In pairs function doesn’t get all the players. It only gets 1 player (yes i have tested with other people)

  3. What solutions have you tried so far? Changing it to Ipairs, pairs, Making "Game.Players:GetChildren(), Making Game.Players:GetPlayers()

After that, you should include more details if you have any. Try to make your topic as descriptive as possible, so that it’s easier for people to help you!

function CheckSight(Players)
	-- THE "PLAYERS" Variable IS game.Players:GetPlayers()
	
	for i, v in ipairs(Players) do
		local char = v.Character
		print(v)
      end
end

Heres a preview of the script. It only prints 1 player name.

1 Like
2

if the Players Variable is saved at the beginning of the script (the start of the server). It wont update when a player joins/leaves (since its a preassigned table)

function CheckSight(Players)
	-- Remove the "Players" Variable
	
	for i, v in ipairs(game.Players:GetPlayers()) do
		local char = v.Character
		print(v)
	end
end
3

It is made right before the function is called

local Players = game.Players:GetPlayers()
local Result = CheckSight(Players)
4

I also have tried it like that. Thats how it looked in the start.

5

Still really not a good option, if a player joins when the function is called, he wont be included

6

Use pairs

function CheckSight(Players)
	-- Remove the "Players" Variable
	
	for _, v in pairs(game.Players:GetPlayers()) do
		local char = v.Character
		print(v)
	end
end
7

Have tried that too doesnt change anything

8

You must need print character?

9

Try again:

function CheckSight(Players)
	-- Remove the "Players" Variable
	
	for _, v in pairs(game.Players:GetPlayers()) do
		local char = v:WaitForChild("Character")
		print(v)
	end
end
10

That won’t make a difference. pairs and ipairs are basically identical, just that ipairs is better for looping through arrays.

11

That isnt the problem. The problem is that it doesn’t get all players. Print(v) doesn’t have anything with the char todo. It shall print the Instances name witch is the Player.

12

I thought that was maybe solution

13

Try printing the length of the array, to see if the issue has something to do with your loop.

print(#Players)
14 
for _, v in pairs(game.Players:GetPlayers())
  print(v.Character)
wait()
end
16

No. This is not how it works. Please research before trying to answer questions with false information.

17

Alright ill test that also:

Run.Heartbeat:Connect(function()
	Playerss = game.Players:GetPlayers()
end)

I have tried doing that to test if it was because it only checked when the script that made.
But this doesn’t change a thing.

18

This won’t change anything, either. Try doing what I said.

19

It prints 2 Constantly. When im testing with 2 players

20

But it only prints 1 player name in the Print player function.

21

Yeah, alright. The issue should be you doing player:WaitForChild("Character"), since the Character is a property of the player, not a instance. Change it to player.Character.