Is anything wrong

Help and Feedback Scripting Support
1

Is anything wrong in this datastore script?

local DataStoreService = game:GetService("DataStoreService")
local DataStore = DataStoreService:GetDataStore("DataStore")

game.Players.PlayerAdded:Connect(function(player)
	local leaderstats = Instance.new("Folder", player)
	leaderstats.Name = "leaderstats"
	
	local Coins = Instance.new("IntValue", leaderstats)
	Coins.Name = "Coins"
	
	local Gems = Instance.new("IntValue", leaderstats)
	Gems.Name = "Gems"
	
	local Rebirths = Instance.new("IntValue", leaderstats)
	Rebirths.Name = "Rebirths"
	
	local playerUserID = "Player_"..player.UserId
	
	-- Load Data
	local data
	local success, errormessage = pcall(function()
		DataStore:GetAsync(playerUserID)
	end)
	
	
end)

game.Players.PlayerRemoving:Connect(function(player)
	local playerUserID = "Player_"..player.UserId
	
	local data = {
		Coins = player.leaderstats.Coins.Value;
		Gems = player.leaderstats.Gems.Value;
		Rebirths = player.leaderstats.Rebirths.Value;
	}
	
	local success, errormessage = pcall(function()
		DataStore:SetAsync(playerUserID, data)
	end)
	
	if success then
		print("Successfully Saved!")
	else
		print("There was an error!")
		warn(errormessage)
	end
	
end)

All help appreciated.

2

After this part,
you’ll need to check if there is data, and set the gems, coins and rebirths values accordingly to their values in the data.

3

For save the data, you need transform the table into a JSON array using http service

And when you go to use the data, you need use http service again with JSONDecode method

Because the second value returned of “GetAsync” is the stored value with “SetAsync”, not an error message

4

Which part shall i write that in?

5

before storing the data with “SetAsync”

6

But there is no data variable in the function. Look:

game.Players.PlayerRemoving:Connect(function(player)
	local playerUserID = "Player_"..player.UserId
	
	local data = game.HttpService:JSONEncode(data)
	local success, errormessage = pcall(function()
		DataStore:SetAsync(playerUserID, data)
	end)
	
	if success then
		print("Successfully Saved!")
	else
		print("There was an error!")
		warn(errormessage)
	end
	
end)
7

“SetAsync” not accept tables with value, JSONEncode transforms the table in a string, and JSONDecode transforms that string in an array again. You need modify now the “GetAsync” function, because the second value returned of “GetAsync” function is not a error message. You can do this with your code:

8

Error on:

Error:
Argument 1 missing or nil.

9

Transforming tables into the JSON format is not required

11

It’s correctly, I’m sorry. Then we go to use if-then, to avoid the error. Can be like this:

12

So “SetAsync” accepts tables and arrays?

13

No, because this code doesn’t work, and the ‘code review’ section is for codes that do work

14

Yes; I always just send raw tables through and it works fine

1 Like
15

image

16

They do?

urda:SetAsync({"hi"})
17

you can substitute:

for:

	Coins.Value =  0
	Gems.Value =  0
	Rebirths.Value = 0

if data ~= nil then
		data = game.HttpService:JSONDecode(data)
		Coins.Value = data.Coins
		Gems.Value = data.Gems
		Rebirths.Value = data.Rebirths
	end
18

It’s correctly, but I started this example using JSON

19

I fixed it so i dont need help anymore

20

Sorry for the delay, but I now have the error in the script.
The argument is nil because in the function:

the return instruction for the function “GetAsync” has not been given.

We need write “return” at the line:

local success, data = pcall(function()
-- in this part we need write "return"
		return DataStore:GetAsync(playerUserID)
	end)
21

Look at this post please! I already…