Is it ok to use a player and set the values of the datastore to the player?
Im wondering if its safe enough to set the values to the player, or should i set it to like a folder in serverstorage and then copy those values to the player?
I think not, because the player is a client-only connection… what is stopping you from using the player’s userid as a key?
If those values are instances / represent instances - such as cars ,tools owned, etc. Then yes, you could store them in server storage. [ you could alternatively simply use the instances themselves, but save the names/values accordingly].
But if those values simply represent stats, such as Cash, Money, etc.. there is no point in doing so. Simply store those values in a table in the data store.
Preferably, use the player’s ID as the key when saving the values.