Is there a better way to do this?

Help and Feedback Code Review
1

I recently made a functional tower defense game with no lobby and just direct gameplay.
But thats not the issue.

I want to create a script to give a random color to an enemy when it spawns. This only works when i use while true do loop, and im aware that its quite horrible for performance. Is there anything better I can use? If so, please let me know. All help and inputs are appreciated.

Thank you in advance.

Heres the code.

local killbot = workspace:WaitForChild("Mobs"):WaitForChild("Killbot")
while true do 
	if killbot then 
		if killbot.BINGBONG:IsA("BasePart") then 
			killbot.BINGBONG.Color = Color3.fromRGB(math.random(0,255), math.random(0,255), math.random(0,255))
		end
	end
	task.wait(1)
end

Using the if statement without the While true do loop only executes the code once (not what i need)

1 Like
2

Well, I might be wrong but I noticed a possibility of an infinite loop… so I’d say the script should have a slight change so it only runs when a new enemy is added

local mobsFolder = workspace:WaitForChild("Mobs")

mobsFolder.ChildAdded:Connect(function(child)
	if child.Name == "Killbot" and child:FindFirstChild("BINGBONG") and child.BINGBONG:IsA("BasePart") then
		child.BINGBONG.Color = Color3.fromRGB(math.random(0,255), math.random(0,255), math.random(0,255))
	end
end)
3 Likes
3

Thank you so much!
It worked really well.

1 Like
5

Already perfect code, if you want more flexibility I’d give them Tags instead of relying on names

1 Like
6

I’m fairly noobie, what are tags?

7

Tags are metadata (data about data) for Instances,

you can give any Instance a tag by using Instance:AddTag(tag: string).
This can be useful if you have a game that contains different types of Zombies for example, where you can give each Zombie Instance a Tag “Zombie” and rename them to whatever you want, eg. “BigZombie” or “ZombieBoss”.

You can loop through Instances in a folder or workspace and check if they are a Zombie with Instance:HasTag(tag) . It’s a great practise to get better at coding and it can bring some structure to your game.

You can also use Collection Service, which is better because it keeps all Instances with a certain tag in one place and accessable at any time without needing extra tables.

1 Like
8

Oh, alright, perfect! I now recall them, they’re above attributes in the properties bar. Thanks! :D

1 Like