Is using one script for all OnServerEvents a bad habit?

Help and Feedback Scripting Support
#1

I use RemoteEvents for value manipulation, like using GUIs to add values from the server.
I have this script that serves as the “Core” script of my game, this is just a bit of it. Most of the contents of the script is just OnServerEvents and nothing else.

-- QuickAdEvent event
game.ReplicatedStorage.Misc.QuickAdEvent.OnServerEvent:Connect(function(player)
	player.leaderstats.Cash.Value = player.leaderstats.Cash.Value + (player.leaderstats.Rebirths.Value + 1)
end)


-- MBAdd event
game.ReplicatedStorage.Misc.MBAdd.OnServerEvent:Connect(function(player)
	local a = player.stats.mb.Value + 1
	local price = a * 1000
	if player.leaderstats.Cash.Value >= price then
		player.stats.mb.Value = player.stats.mb.Value + 1
		player.leaderstats.Cash.Value = player.leaderstats.Cash.Value - price
	end
end)


-- MBSub event
game.ReplicatedStorage.Misc.MBSub.OnServerEvent:Connect(function(player)
	if player.stats.mb.Value >= 1 then
		player.stats.mb.Value = player.stats.mb.Value - 1
		player.leaderstats.Cash.Value = player.leaderstats.Cash.Value + (player.stats.mb.Value * 100)
	end
end)
#2

In my opinion, no. I think it’s good to keep organised and have all of the code that is handling your events in one script, as they are all in the same place and easy to access. I wouldn’t say this is a bad habit.

#3

Its not a bad habit to use one script to handle all remote event traffic that comes to the server, just keep in mind that over time code can get messy (If you have alot of remote events / remote functions).

#4

Oh my that is actually a good idea though. I have too many scripts in my server script service.

#5

One thing to try for organizational purposes is for player specific events (for example, an animation event) is to keep it in a separate script/event within the character/player. That way each player has their own folder of player specific events with a script to handle them. I wouldn’t do it for everything, but some events, such as tools for firing weapons, it might make sense to keep them separate and more easily accessible.