Issue with Cframes before welding

[TutanHello616 (Tutankhamun)]

So im having an issue when an script clones an armor and changes the cframe for each body part some of them dont even change, i didnt do anything to the game for like a month and a half and when i come back this happens and i honestly dont know why

		for _,v in pairs(Armors[Chosen]:GetChildren()) do
			if v:IsA("BasePart") then
				local weldingto=player.Character:WaitForChild(v.Name)
				local part=v:Clone()
				part.CFrame = weldingto.CFrame
				local weld = Instance.new("WeldConstraint")
				weld.Part0 = part
				weld.Part1 = weldingto
				weld.Parent = part
				part.Parent = ArmorFolder
			end
		end

[Manfred_good]

I think the Problem is that the position of the HRP is kinda ofset. You can fix this problem by welding the character a “Hitbox” on spawn and using this one. Or you just can make the amor a accessorie.

[Suvry1 (JustYSH)]

im not sure if this is the correct solution but i wanted to help you need to make sure both parts are positioned correctly before creating the weld if you weld them first then try to change the cframe the weld will override it so always move the parts into place first then create the weld after that if youre setting cframes make sure the parts are anchored temporarily then unanchor after welding if needed otherwise the physics might break especially on the server where replication timing matters im pretty sure the issue is coming from WeldConstraint

[TutanHello616 (Tutankhamun)]

Looks like all I had to do was parent the part before changing the cframe… im sure this isnt the best method but it works