Issue with DataStore

MrDaBigBoss · May 7, 2020, 5:24pm

Hello! I seem to have a problem with my DataStore. It was working fine until I added the “WalkSpeed” save. Here is the script… The output also says that either Humanoid or Character isn’t part of player/character and using WaitForChild() and FindFirstChild() didn’t work either.

local ServerStorage = game:GetService("ServerStorage")
local DataStoreService = game:GetService("DataStoreService")
local myDataStore = DataStoreService:GetDataStore("myDataStore")

game.Players.PlayerAdded:Connect(function(player)
	
	local leaderstats = Instance.new("Folder")
	leaderstats.Name = "leaderstats"
	leaderstats.Parent = player
	
	local Points = Instance.new("IntValue")
	Points.Name = "Points"
	Points.Parent = leaderstats
	
	local Wins = Instance.new("IntValue")
	Wins.Name = "Wins"
	Wins.Parent = leaderstats
	
	local Activations = Instance.new("IntValue")
	Activations.Name = "Activations"
	Activations.Parent = leaderstats
	
	local Deaths = Instance.new("IntValue")
	Deaths.Name = "Deaths"
	Deaths.Parent = leaderstats
	
	local Upgrades = Instance.new("Folder")
	Upgrades.Name = "Upgrades"
	Upgrades.Parent = player
	
	local SpeedLevel = Instance.new("IntValue")
	SpeedLevel.Name = "SpeedLevel"
	SpeedLevel.Parent = Upgrades

	local JumpLevel = Instance.new("IntValue")
	JumpLevel.Name = "JumpLevel"
	JumpLevel.Parent = Upgrades

	-->> Data: Begining
	
	local playerUserId = "Player_"..player.UserId
	
	-->>Data: Load Data
	
	local data
	local success, errormessage	 = pcall(function()
		data = myDataStore:GetAsync(playerUserId)
	end)
	
	if success then
		if data then
			Points.Value = data.Points
			Wins.Value = data.Wins
			Activations.Value = data.Activations
			Deaths.Value = data.Deaths
			SpeedLevel.Value = data.SpeedLevel
			JumpLevel.Value = data.JumpLevel
			player.Character.Humanoid.WalkSpeed = data.WalkSpeed
		end
	end
	
end)

-->> Data: Saving Stats

game.Players.PlayerRemoving:Connect(function(player)
	local playerUserId = "Player_"..player.UserId

	local data = {
		Points = player.leaderstats.Points.Value;
		Wins = player.leaderstats.Wins.Value;
		Activations = player.leaderstats.Activations.Value;
		Deaths = player.leaderstats.Deaths.Value;
		SpeedLevel = player.Upgrades.SpeedLevel.Value;
		JumpLevel = player.Upgrades.JumpLevel.Value;
		WalkSpeed = player.Character.Humanoid.WalkSpeed;
	}
	
	local success, errormessage = pcall(function()
		myDataStore:SetAsync(playerUserId, data)
	end)
		
	if success then
		print("Data succefully saved!")
	else
		print("Data saving error")
		warn(errormessage)
	end
	
end)

Slazai · May 7, 2020, 5:26pm

That may be due because the character hasn’t been loaded yet and/or the appearance wasn’t loaded yet.

NOCOMPLYMOBY · May 7, 2020, 5:27pm

Don’t do that, here’s what you should do, since the character most likely hasn’t loaded.

...

local character = player.Character or player.CharacterAdded:Wait()
character:WaitForChild("Humanoid").WalkSpeed = data.WalkSpeed

Slazai · May 7, 2020, 5:32pm

He can use the CharacterAppearanceLoaded event in the following way:

player.CharacterAppearanceLoaded:Wait() -- this basically waits until the event is fired meaning it will yield the script until the appearance of the character is loaded.
player.Character.Humanoid.WalkSpeed = data.WalkSpeed

MrDaBigBoss · May 7, 2020, 5:34pm

So would puting this in the data loading would work? I added character as first line of the PlayerAdded function.

if character then
       character:WaitForChild("Humanoid").WalkSpeed = data.WalkSpeed
end

NOCOMPLYMOBY · May 7, 2020, 5:35pm

No, you can just do the same thing I did, basically how it works is that it checks if the players character exists, if it doesn’t then it waits for the CharacterAdded event to fire. TL;DR, there’s no if statements needed, since it already takes care of waiting for the player’s character.

MrDaBigBoss · May 7, 2020, 5:36pm

So how would I add this in my script?

NOCOMPLYMOBY · May 7, 2020, 5:37pm

You put it at the part where it says:

player.Character.Humanoid.WalkSpeed = data.Walkspeed

(Without the “…”)

MrDaBigBoss · May 7, 2020, 5:38pm

But isn’t that what I had at first?

NOCOMPLYMOBY · May 7, 2020, 5:40pm

No, like this:


local ServerStorage = game:GetService("ServerStorage")
local DataStoreService = game:GetService("DataStoreService")
local myDataStore = DataStoreService:GetDataStore("myDataStore")

game.Players.PlayerAdded:Connect(function(player)
	
	local leaderstats = Instance.new("Folder")
	leaderstats.Name = "leaderstats"
	leaderstats.Parent = player
	
	local Points = Instance.new("IntValue")
	Points.Name = "Points"
	Points.Parent = leaderstats
	
	local Wins = Instance.new("IntValue")
	Wins.Name = "Wins"
	Wins.Parent = leaderstats
	
	local Activations = Instance.new("IntValue")
	Activations.Name = "Activations"
	Activations.Parent = leaderstats
	
	local Deaths = Instance.new("IntValue")
	Deaths.Name = "Deaths"
	Deaths.Parent = leaderstats
	
	local Upgrades = Instance.new("Folder")
	Upgrades.Name = "Upgrades"
	Upgrades.Parent = player
	
	local SpeedLevel = Instance.new("IntValue")
	SpeedLevel.Name = "SpeedLevel"
	SpeedLevel.Parent = Upgrades

	local JumpLevel = Instance.new("IntValue")
	JumpLevel.Name = "JumpLevel"
	JumpLevel.Parent = Upgrades

	-->> Data: Begining
	
	local playerUserId = "Player_"..player.UserId
	
	-->>Data: Load Data
	
	local data
	local success, errormessage	 = pcall(function()
		data = myDataStore:GetAsync(playerUserId)
	end)
	
	if success then
		if data then
			Points.Value = data.Points
			Wins.Value = data.Wins
			Activations.Value = data.Activations
			Deaths.Value = data.Deaths
			SpeedLevel.Value = data.SpeedLevel
			JumpLevel.Value = data.JumpLevel
			local character = player.Character or player.CharacterAdded:Wait()
            character:WaitForChild("Humanoid").WalkSpeed = data.WalkSpeed
		end
	end
	
end)

-->> Data: Saving Stats

game.Players.PlayerRemoving:Connect(function(player)
	local playerUserId = "Player_"..player.UserId

	local data = {
		Points = player.leaderstats.Points.Value;
		Wins = player.leaderstats.Wins.Value;
		Activations = player.leaderstats.Activations.Value;
		Deaths = player.leaderstats.Deaths.Value;
		SpeedLevel = player.Upgrades.SpeedLevel.Value;
		JumpLevel = player.Upgrades.JumpLevel.Value;
		WalkSpeed = player.Character.Humanoid.WalkSpeed;
	}
	
	local success, errormessage = pcall(function()
		myDataStore:SetAsync(playerUserId, data)
	end)
		
	if success then
		print("Data succefully saved!")
	else
		print("Data saving error")
		warn(errormessage)
	end
	
end)

Slazai · May 7, 2020, 5:40pm

add player.CharacterAppearanceLoaded:Wait() before applying the WalkSpeed.

That’ll wait until the character appearance has loaded and then will resume executing the script.

MrDaBigBoss · May 7, 2020, 5:43pm

This doesn’t fix the issue with data not saving at all… So i can’t verify that this works.

NOCOMPLYMOBY · May 7, 2020, 5:45pm

Well, are you going into the server view in studio?
And do you have Studio Access to API Services enabled in your game settings?

MrDaBigBoss · May 7, 2020, 5:51pm

Yes, it’s on. But what will going into Server Side change?

NOCOMPLYMOBY · May 7, 2020, 5:55pm

I don’t have an image readily available, but there’s a button when you go into play solo that says (something like) client, if you click it you can go to the server view.

MrDaBigBoss · May 7, 2020, 5:55pm

I know, but how will that help?

MrDaBigBoss · May 7, 2020, 5:56pm

This didn’t seem to work… 30 chars

NOCOMPLYMOBY · May 7, 2020, 5:57pm

You change the values from the server, you’re probably changing it from the client. With FilteringEnabled, changes from the client don’t replicate.

MrDaBigBoss · May 7, 2020, 5:59pm

Ohhhh, I see what you mean. I tried changing the Values from the Server side but that did NOT save them sadly…

NOCOMPLYMOBY · May 7, 2020, 6:00pm

That’s super bizarre, I have no idea what could be happening.