Memory Leak? Script gets laggier over time

Help and Feedback Scripting Support
#1

Im pretty sure I have a memory leak or something but I may not me 100% sure, this script starts off being pretty good then becoming unusable in the matter of minutes, so there’s a major memory leak I believe. I just want a second pair of eyes to review my code to see if theres anything major I messed up on.

CONTEXT: This is AI script that follows the player, it isn’t fully done but this is a major issue I need done so I can add more later.

CLIENT:

local PFS = game:GetService("PathfindingService");

--Public Vars
local plr = game.Players.LocalPlayer;
local char = plr.Character or plr.CharacterAdded:Wait();
local PathObj = PFS:CreatePath();

--Functions
local function GetDst(Pos1, Pos2)
	return math.sqrt((Pos1.X - Pos2.X)^2 + (Pos1.Y - Pos2.Y)^2 + (Pos1.Z - Pos2.Z)^2);
end

--Main
game.ReplicatedStorage.Events.TroopListen.OnClientEvent:Connect(function(TroopEvent)
	TroopEvent.OnClientEvent:Connect(function(Path, Troop)
		if (char) then
			local StartPoint;
			if (#Path > 0) then
				StartPoint = Path[#Path].Position;
			else
				 StartPoint = Troop.HumanoidRootPart.CFrame.Position;
			end
			PathObj:ComputeAsync(StartPoint, char.HumanoidRootPart.CFrame.Position);

			local ReturnPoints = {};
			local Waypoints = PathObj:GetWaypoints();
			if #Waypoints < 4 or GetDst(StartPoint, char.HumanoidRootPart.CFrame.Position) < 10 then
				TroopEvent:FireServer(ReturnPoints)
				return
			end

			for i = 2, 5 do
				if (Waypoints[i]) then
					table.insert(ReturnPoints, Waypoints[i])
				end
			end
			TroopEvent:FireServer(ReturnPoints)
		end
	end)
end)

SERVER:

--Services
local PFS = game:GetService("PathfindingService");

--//Public Vars
local UpdatePath = script.Parent.UpdatePath;
local Troop = script.Parent.Parent;
local Hum = Troop.Humanoid;
local Path = {};
local Owner = script.Parent.Owned;
local Debounce = false;
--//Functions

local function GetDst(Pos1, Pos2)
	return math.sqrt((Pos1.X - Pos2.X)^2 + (Pos1.Y - Pos2.Y)^2 + (Pos1.Z - Pos2.Z)^2);
end

local function CheckPath()
	local Char = Owner.Value.Character;
	if (Char) then
		if #Path <= 4 and GetDst(Troop.HumanoidRootPart.CFrame.Position, Char.HumanoidRootPart.CFrame.Position) > 10 then
			if (Debounce == false) then
				Debounce = true;
				UpdatePath:FireClient(Owner.Value, Path, Troop);
			end
		end
	end
end

--//Main
UpdatePath.OnServerEvent:Connect(function(plr, NewPath)
	if (plr == Owner.Value) then
		for i,v in pairs(NewPath) do
			table.insert(Path, v);
		end
		Debounce = false;
	end
end)

while true do
	CheckPath();
	print(#Path)
	local Target = Path[1];
	if (Target) then
		local Char = Owner.Value.Character;
		if (Char) then
			local Dst = GetDst(Target.Position, Char.HumanoidRootPart.CFrame.Position);
			if (not (Dst <= 10)) then
				Hum:MoveTo(Target.Position);
				if (Target.Action == Enum.PathWaypointAction.Jump) then
					Hum.Jump = true;
				end
				Hum.MoveToFinished:Wait();
			end
		end
		table.remove(Path, 1)
	else
		wait();
	end
end

PS: Thanks for your time <3

2 Likes
#2

While reading over this I basicly made a block of code I never done before and its kind of hacky which is:

game.ReplicatedStorage.Events.TroopListen.OnClientEvent:Connect(function(TroopEvent)
	TroopEvent.OnClientEvent:Connect(function(Path, Troop)
		if (char) then
			local StartPoint;
			if (#Path > 0) then
				StartPoint = Path[#Path].Position;
			else
				 StartPoint = Troop.HumanoidRootPart.CFrame.Position;
			end
			PathObj:ComputeAsync(StartPoint, char.HumanoidRootPart.CFrame.Position);

			local ReturnPoints = {};
			local Waypoints = PathObj:GetWaypoints();
			if #Waypoints < 4 or GetDst(StartPoint, char.HumanoidRootPart.CFrame.Position) < 10 then
				TroopEvent:FireServer(ReturnPoints)
				return
			end

			for i = 2, 5 do
				if (Waypoints[i]) then
					table.insert(ReturnPoints, Waypoints[i])
				end
			end
			TroopEvent:FireServer(ReturnPoints)
		end
	end)
end)

Which basically connects the event of the AI to the Player so it can calculate the math on the AI’s owner.

This may be the leak, im not 100% sure

#3

After more testing, the thing that’s causing lag is in the SERVER script, not the code block above

#4

Do you find your path table getting larger faster than it’s depleting?

How big does print( #Path ) get to?

1 Like
#5

0 - 8 never higher , I believe it could be something more major. It’s is not the events as if u just stand still and don’t move no events fire yet it slows the game down

#6

You should not fire a while loop in the server because whether anything is firing or not it’ll always keep looping that check system.
Instead try making it run every time the character moves, or you can run the while loop locally (in this case it won’t create server lag) and then when the check appears true make it fire to the server what you want it to do.

#7

Im gonna rescript the whole system in a bit and ill see if the issue still persists, ill update once I finish.

#8

This could be an issue, every time TroopListen event is fired, a function is connected to TroopEvent. For every connection to TroopEvent there is a RBXScriptConnection, which means it could build up lag. Do you disconnect the events/destroy the remove event ever? With :Destroy() not :remove()

If connections are being built up, then there are unnecessary function calls being made (lag) with unnecessary memory being held buy the functions and the RBXScriptConnections.

#9

Ok I’ll look into it thanks :+1: