MouseButton1Up Function not working?

Help and Feedback Scripting Support
,
1

Im tryna make a frame open when clicked a button, but it wont work. Why doesn’t my script work?

local mainframe = sgui:FindFirstChild("MainFrame")
local buttons = mainframe:FindFirstChild("Buttons")
local updatebutton = buttons:FindFirstChild("UpdatesButton")
local openframe = updatebutton:FindFirstChild("UpdatesLog")

openframe.Visible = false
updatebutton.MouseButton1Up:Connect(function()
	openframe.Visible = true
end)

This is my only error
Players.killersfatality.PlayerGui.MainMenuGUI.UpdatesLogOPEN:7: attempt to index nil with 'Visible'

1 Like
2

Try replacing this with:

updatebutton.MouseButton1Click:Connect(function()

This errors is telling you that “UpdatesLog” is nil / doesn’t exist which means that its parent couldn’t find it. Maybe check the spelling here:

3

That gives me another error

Players.killersfatality.PlayerGui.MainMenuGUI.MainFrame.Buttons.UpdatesButton.UpdatesLogOPEN:8: attempt to index nil with Visible

4

Could you take a picture of the hierarchy of the GUIs? Like the parents and children in the explorer

5

image
UpdateLogsOPEN is the script i am scriptin

2 Likes
6

Okay it seems like you’re just referencing the UpdateLogFrame incorrectly. Try replacing this line:

With this line:

local openframe = mainframe:FindFirstChild(“UpdateLogFrame”)
7

I know this is unrelated but if I may ask, how did you get that programmer role?

1 Like
8

Developer Forum | Roblox or Programmers - Developer Forum | Roblox

1 Like
9

The reason the TextButton is registered as nil is because you have used FindFirstChild(), which is generally used when you are unsure that a child will exist.

In this case, since it is a client-side script, you need to replace FindFirstChild() with WaitForChild(), which will yield the code until the given child exists. WaitForChild() is very helpful within the client when a given object is needed for the code to run correctly.

Example:

local updatebutton = buttons:WaitForChild("UpdatesButton")
--this will make the script wait until the child exists. Make sure you
--put the correct name in character for character, otherwise you can get an infinite yield error where it is waiting forever.

Hope this helps!

1 Like
10

Ah yes this helped, I also changed a few things
@12345koip @Doomcolp
I did what you both said, there are no errors, but the frame doesn’t show up when i click the updates button

local sgui = startergui.MainMenuGUI
local mainframe = sgui:FindFirstChild("MainFrame")
local buttons = mainframe:FindFirstChild("Buttons")
local updatebutton = buttons:WaitForChild("UpdatesButton")
local openframe = mainframe:WaitForChild("UpdateLogFrame")

openframe.Visible = false

script.Parent.MouseButton1Click:Connect(function(click)
	openframe.Visible = true
end)
11

Try this:

updatesbutton.MouseButton1Click:Connect(function()
    openframe.Visible = true
end)
12

Your other code was using script.Parent, therefore making the variable unnecessary.

13

Yes, I tried that, that’s why I switched it to script.Parent

14

You are editing it in StarterGui, from the top variable. Change the sgui variable if it is set to the StarterGui.

local sgui = game.Players.LocalPlayer:WaitForChild("PlayerGui")
1 Like
15

Nevermind, it works. Thanks my code is now

local sgui = startergui:WaitForChild("MainMenuGUI")
local mainframe = sgui.MainFrame
local buttons = mainframe:FindFirstChild("Buttons")
local updatebutton = buttons:FindFirstChild("UpdatesButton")
local openframe = mainframe.UpdateLogFrame

openframe.Visible = false

updatebutton.MouseButton1Click:Connect(function(click)
	openframe.Visible = true
end)
1 Like
16

For that variable, you are using FindFirstChild() again! Change it to WaitForChild().

1 Like
17

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.