My friend wants to publish clothes, but it is a edited version of another template

Someone I know took military uniforms from a group, but he edited some aspects of them (specifically; collar, shading, colors and rank insignia)

But he also credited the original creator for their work.

Is this considered a violation of the ToS? Because I want to inform him before he publishes them in about a few days.

(P.S he directly messaged me telling that the clothes are from an abandoned project.)

IANAL: even if you give attribution, modifying an existing work is considered a copyright violation without explicit permission from the original clothing author.

you may get away with it, but it is against TOS, and the original clothing owner would completely be within their rights to send a DMCA request and get it taken down.