I’ve just created my own ScriptSignal implementation. It was supposed to be used in another, bigger module that’s the main project, but I’ve ported (albeit poorly) the Enum, ScriptConnection, ConnectionRunner (middleware) and ScriptSignal classes into a standalone module. This is my first time ever going completely all out coding like this, so I would like to have feedback and criticism.
It is less efficient than stravant’s GoodSignal due to the existence of a middleware but more functionalities are enabled due to the middleware like firing a specific ScriptConnection through an unique identifier. An Enum class isn’t strictly necessary for this but it’s used in the aforementioned bigger project so I just ported it to here as well.
P.S. The types are unfinished, but everything else are finished and stress tested & debugged. Not confirmed prod stable though.
Sorry, exactly what advantage does this have over GoodSignal or FastSignal? I see you mentioned firing a specific connection based on an identifier however can’t this just be done with a locally defined table?
The code looks fine but it really seems to fall into the phrase “if it ain’t broke, don’t fix it”. Feel free to correct me if I am wrong though.
tbh not much advantage over them, i’m mostly just treating this as practice
the code can definitely use some compressing, there are a lot of unnecessary code because i ported this from a bigger project of mine without optimization