Need Help With a Script

Help and Feedback Scripting Support
1

I have coded a script to put the Values of to NumberValues onto guis, but the second function wont fire, but the first dose

Player.PlayerGui.ScreenGui.leaderstatAmounts.Credits.TextLabel.Text = "$"..Comma(game.ReplicatedStorage.userData[Player.Name].Credits.Value)
game.ReplicatedStorage.userData[Player.Name].Credits.Value:GetPropertyChangedSignal("Value"):Connect(function()
	Player.PlayerGui.ScreenGui.leaderstatAmounts.Credits.TextLabel.Text = "$"..Comma(game.ReplicatedStorage.userData[Player.Name].Credits.Value)

end)
	-- Wont Fire

Player.PlayerGui.ScreenGui.leaderstatAmounts.Miles.TextLabel.Text = ""..Comma(game.ReplicatedStorage.userData[Player.Name].StudsDriven.Value)
game.ReplicatedStorage.userData[Player.Name].StudsDriven.Value:GetPropertyChangedSignal("Value"):Connect(function()
	Player.PlayerGui.ScreenGui.leaderstatAmounts.Miles.TextLabel.Text = ""..Comma(game.ReplicatedStorage.userData[Player.Name].StudsDriven.Value)
end)
2

Are you getting any errors when server startup?

3

No, I don’t get any errors on startup

4

Are you sure that the value is present on replicated storage could you try to put a print inside the GetPropertyChangedSignal function?

5

It doesn’t print anything, There both the same kind of value, the only thing that is different is the Name of the value

6

Could you send the Comma function, it may be yielding it forever?

7

Well it looks a bit strange if there are not errors and the first function fire, there are no reason of why the second function wont fire…

8

Here:

function Comma(v10)
	while true do 
		v10, k = string.gsub(v10,"^(-?%d+)(%d%d%d)", '%1,%2')
		if (k == 0)	then
			break
		end
	end
	return v10

end
9

Oh! I see the problem, it doesn’t seem to break the loop I have another comma function if you would like to try it.

function comma(amount)
	if (math.abs(amount) < 1000) then 
		return tostring(amount) 
	end

	local str = (amount < 0 and "-" or "") .. tostring(math.abs(math.floor(amount))):reverse():gsub("%d%d%d","%1,"):gsub(",$",""):reverse()

	if (not (amount == math.floor(amount))) then
		str = str .. "." .. (tostring(amount):match("%d+.$"))
	end

	return str
end

You obviously don’t have to use it but try and replace it to see if it works

10

Sadly, i dosent work

function comma(amount)
	if (math.abs(amount) < 1000) then 
		return tostring(amount) 
	end

	local str = (amount < 0 and "-" or "") .. tostring(math.abs(math.floor(amount))):reverse():gsub("%d%d%d","%1,"):gsub(",$",""):reverse()

	if (not (amount == math.floor(amount))) then
		str = str .. "." .. (tostring(amount):match("%d+.$")) -- here its underlined as a error
	end

	return str
end
11

Did you try and run it? Because it should work. Nothing else should yield the function.

Its underlined red because of something wrong with the script editor

12

This is a picture of the script:

Screenshot 2022-04-14 150040
Screenshot 2022-04-14 1500401581×744 114 KB

13

I don’t see a problem with the script, try making variables, for example PlayerGui and try to use :WaitForChild where possible

14

I made a quick version you could try to use

local ReplicatedStorage = game:GetService("ReplicatedStorage")

local PlayerGui = Player:WaitForChild("PlayerGui")
local ScreenGui = PlayerGui:WaitForChild("ScreenGui")
local leaderstatAmounts = ScreenGui:WaitForChild("leaderstatAmounts")

leaderstatAmounts.Credits.TextLabel.Text = "$"..Comma(game.ReplicatedStorage.userData[Player.Name].Credits.Value)
ReplicatedStorage.userData[Player.Name].Credits.Value:GetPropertyChangedSignal("Value"):Connect(function()
	leaderstatAmounts.Credits.TextLabel.Text = "$"..Comma(ReplicatedStorage.userData[Player.Name].Credits.Value)

end)

leaderstatAmounts.Miles.TextLabel.Text = ""..Comma(ReplicatedStorage.userData[Player.Name].StudsDriven.Value)
ReplicatedStorage.userData[Player.Name].StudsDriven.Value:GetPropertyChangedSignal("Value"):Connect(function()
	leaderstatAmounts.Miles.TextLabel.Text = ""..Comma(ReplicatedStorage.userData[Player.Name].StudsDriven.Value)
end)
15

With the new script, it still puts the text on the first label, but for some reason it doesn’t do it for the second.

16

And you’re not getting any errors?

17

Yes i get this error: PlayerGui.ScreenGui.Client:155: attempt to index number with ‘GetPropertyChangedSignal’

18

Oh! I see the problem. I made a fixed version for you!

local ReplicatedStorage = game:GetService("ReplicatedStorage")

local PlayerGui = Player:WaitForChild("PlayerGui")
local ScreenGui = PlayerGui:WaitForChild("ScreenGui")
local leaderstatAmounts = ScreenGui:WaitForChild("leaderstatAmounts")

local userDataFolder = ReplicatedStorage:WaitForChild("userData")
local userData = userDataFolder:FindFirstChild(Player.Name)

leaderstatAmounts.Credits.TextLabel.Text = "$"..Comma(userData.Credits.Value)
userData.Credits:GetPropertyChangedSignal("Value"):Connect(function()
	leaderstatAmounts.Credits.TextLabel.Text = "$"..Comma(userData.Credits.Value)

end)

leaderstatAmounts.Miles.TextLabel.Text = ""..Comma(userData.StudsDriven.Value)
userData.StudsDriven:GetPropertyChangedSignal("Value"):Connect(function()
	leaderstatAmounts.Miles.TextLabel.Text = ""..Comma(userData.StudsDriven.Value)
end)

The problem was that you did Credits.Value:GetPropertyChangedSignal, and that doesn’t work you have to remove the .Value because the value is returning a number.

19

It worked! Thank you for your help!