OnTouched Event not working

Help and Feedback Scripting Support
#21

I’m going to try it in studio and see if I can get the same problem

#22

Same error. 30charssssssssssssssssssssssss

#23

Can you screenshot the output?

#24

There should be no errors at line 4.

#25


Here. 30charsssssssssssssssssssssssssss

#26

local Part = script.Parent

Part.Touched:Connect(function(hit)
if hit.Parent:FindFirstChild(“Humanoid”) then
local plr = game.Players:GetPlayerFromCharacter(hit)
if plr then
local playergui = plr:WaitForChild(“PlayerGui”)
local Quest1 = plr.PlayerGui.Quest1
print(“working”)
Part.BillboardGui.arrow_downward.Visible = false
Part.BillboardGui.done.Visible = true
Quest1.Frame:Destroy()
Quest1.QuestFinished.Visible = true
end
end
end)

Try this

#27

I think the problem is very obvious. You’re :remove()ing Quest1 before changing the QuestFinished value. Why are you removing Quest1 anyways if you still want the QuestFinished value to be around?

#28

There is not errors, but the “print” thing doesn’t print in the output and nothing happens.

#29

Basicly they are like this: image

1 Like
#30

They are removing the frame not the gui I think

1 Like
#31

Sorry I didn’t read quite carefully, what’s the problem you’re having exactly? Any errors? You were also editing the UI in StarterGui and not PlayerGui.

As well, it’s generally useless to use global variables (variables not prefixed with local), and don’t use :remove(), use :Destroy() instead.

1 Like
#32

I think I know why!

local Part = script.Parent

Part.Touched:Connect(function(hit)
if hit.Parent:FindFirstChild(“Humanoid”) then
local plr = game.Players:GetPlayerFromCharacter(hit.Parent)
if plr then
local playergui = plr:WaitForChild(“PlayerGui”)
local Quest1 = plr.PlayerGui.Quest1
print(“working”)
Part.BillboardGui.arrow_downward.Visible = false
Part.BillboardGui.done.Visible = true
Quest1.Frame:Destroy()
Quest1.QuestFinished.Visible = true
end
end
end)

when getting the plr put hit.Parent instead of hit

1 Like
#33

Thanks! It works!!
It was very long and painfull. Have a great day/night.

#34

Thank you! I can’t believe I missed it, that always happens to me haha

#35

Also, don’t forget to use the good brakets !

1 Like