Problem with datastore requests

Help and Feedback Scripting Support
, ,
#1

Well, I have a big problem… that when I gain exp, I leave the game or even save the data… the following error comes!

Untitled 2
Untitled 2795×165 19.1 KB

My Data Script in ServerScriptService:

local DataStore = game:GetService("DataStoreService")
local Level1 = DataStore:GetDataStore("Levels001")
local Beli11 = DataStore:GetDataStore("Beli001")
local Exp1 = DataStore:GetDataStore("Exp001")
local ExpNeed1 = DataStore:GetDataStore("ExpNeed001")
local HealthAdd1 = DataStore:GetDataStore("HealthAdd001")
local DefenseP1 = DataStore:GetDataStore("DefenseP001")
local SwordP1 = DataStore:GetDataStore("SwordP001")
local LuckP1 = DataStore:GetDataStore("LuckP001")
local SpecialP1 = DataStore:GetDataStore("Special001")
local Defense1 = DataStore:GetDataStore("Defense001")
local Sword1 = DataStore:GetDataStore("Sword001")
local Luck1 = DataStore:GetDataStore("Luck001")
local Special1 = DataStore:GetDataStore("Special001")
local Points1 = DataStore:GetDataStore("Points001")
local Gems1 = DataStore:GetDataStore("Gems001")
local PvpSystem1 = DataStore:GetDataStore("PvpSystem001")
local Bounty1 = DataStore:GetDataStore("Bounty001")

game.Players.PlayerAdded:Connect(function(Plr)
	--- Folders
	local stats = Instance.new("Folder", Plr)
	stats.Name = "Data"
	
	local leaderstats = Instance.new("Folder", Plr)
	leaderstats.Name = "leaderstats"
	
	--- Bounty System
	local Bounty = Instance.new("IntValue", leaderstats)
	Bounty.Name = "Bounty"
	Bounty.Value = 0
	
	--- PVP System
	local PvpSystem = Instance.new("IntValue", stats)
	PvpSystem.Name = "PVP"
	PvpSystem.Value = 0
	
	--- Level System
	local Levels = Instance.new("IntValue", stats)
	Levels.Name = "Levels"
	Levels.Value = 1
	local Exp = Instance.new("IntValue", stats)
	Exp.Name = "Exp"
	Exp.Value = 0
	local ExpNeed = Instance.new("IntValue", stats)
	ExpNeed.Name = "ExpNeed"
	ExpNeed.Value = 170
	
	--- Money System
	local Beli = Instance.new("IntValue", stats)
	Beli.Name = "Beli"
	Beli.Value = 0
	local Gems = Instance.new("IntValue", stats)
	Gems.Name = "Gems"
	Gems.Value = 0
	
	--- Stats Text
	local HealthAdd = Instance.new("IntValue", stats)
	HealthAdd.Name = "HealthAdd"
	HealthAdd.Value = 0
	local DefenseP = Instance.new("IntValue", stats)
	DefenseP.Name = "DefenseP"
	DefenseP.Value = 0
	local SwordP = Instance.new("IntValue", stats)
	SwordP.Name = "SwordP"
	SwordP.Value = 0
	local LuckP = Instance.new("IntValue", stats)
	LuckP.Name = "LuckP"
	LuckP.Value = 0
	local SpecialP = Instance.new("IntValue", stats)
	SpecialP.Name = "SpecialP"
	SpecialP.Value = 0
	
	--- Stats System
	local Points = Instance.new("IntValue", stats)
	Points.Name = "Points"
	Points.Value = 3
	local PointsS = Instance.new("IntValue", stats)
	PointsS.Name = "PointsS"
	PointsS.Value = 1
	local Defense = Instance.new("IntValue", stats)
	Defense.Name = "Defense"
	Defense.Value = 0
	local Sword = Instance.new("IntValue", stats)
	Sword.Name = "Sword"
	Sword.Value = 0
	local Luck = Instance.new("IntValue", stats)
	Luck.Name = "Luck"
	Luck.Value = 0
	local Special = Instance.new("IntValue", stats)
	Special.Name = "Special"
	Special.Value = 0

	--PVP System
	Bounty.Value = Bounty1:GetAsync(Plr.UserId) or Bounty.Value
	Bounty1:SetAsync(Plr.UserId, Bounty.Value)
	Bounty.Changed:connect(function()
		Bounty1:SetAsync(Plr.UserId, Bounty.Value)
	end)
	--PVP System
	PvpSystem.Value = PvpSystem1:GetAsync(Plr.UserId) or PvpSystem.Value
	PvpSystem1:SetAsync(Plr.UserId, PvpSystem.Value)
	PvpSystem.Changed:connect(function()
		PvpSystem1:SetAsync(Plr.UserId, PvpSystem.Value)
	end)
	--- Levels
   Levels.Value = Level1:GetAsync(Plr.UserId) or Levels.Value
	   Level1:SetAsync(Plr.UserId, Levels.Value)
	Levels.Changed:connect(function()
	   Level1:SetAsync(Plr.UserId, Levels.Value)
   end)
	--- Gold
   Beli.Value = Beli11:GetAsync(Plr.UserId) or Beli.Value
	   Beli11:SetAsync(Plr.UserId, Beli.Value)
	Beli.Changed:connect(function()
	   Beli11:SetAsync(Plr.UserId, Beli.Value)
	end)
	-- Gems
	Gems.Value = Gems1:GetAsync(Plr.UserId) or Gems.Value
	Gems1:SetAsync(Plr.UserId, Gems.Value)
	Gems.Changed:connect(function()
		Gems1:SetAsync(Plr.UserId, Gems.Value)
	end)
	--- Exp
   Exp.Value = Exp1:GetAsync(Plr.UserId) or Exp.Value
	   Exp1:SetAsync(Plr.UserId, Exp.Value)
	Exp.Changed:connect(function()
	   Exp1:SetAsync(Plr.UserId, Exp.Value)
   end)
	--- ExpNeed
   ExpNeed.Value = ExpNeed1:GetAsync(Plr.UserId) or ExpNeed.Value
	   ExpNeed1:SetAsync(Plr.UserId, ExpNeed.Value)
	ExpNeed.Changed :connect(function()
	   ExpNeed1:SetAsync(Plr.UserId, ExpNeed.Value)
	end)
	--- HealthAdd
	HealthAdd.Value = HealthAdd1:GetAsync(Plr.UserId) or HealthAdd.Value
	HealthAdd1:SetAsync(Plr.UserId, HealthAdd.Value)
	HealthAdd.Changed:connect(function()
		HealthAdd1:SetAsync(Plr.UserId, HealthAdd.Value)
	end)
	--- SwordP
   SwordP.Value = SwordP1:GetAsync(Plr.UserId) or SwordP.Value
	   SwordP1:SetAsync(Plr.UserId, SwordP.Value)
	SwordP.Changed:connect(function()
	   SwordP1:SetAsync(Plr.UserId, SwordP.Value)
   end)
	--- DefenseP
   DefenseP.Value = DefenseP1:GetAsync(Plr.UserId) or DefenseP.Value
	   DefenseP1:SetAsync(Plr.UserId, DefenseP.Value)
	DefenseP.Changed:connect(function()
	   DefenseP1:SetAsync(Plr.UserId, DefenseP.Value)
   end)
	--- Sword
   Sword.Value = Sword1:GetAsync(Plr.UserId) or Sword.Value
	   Sword1:SetAsync(Plr.UserId, SwordP.Value)
	Sword.Changed:connect(function()
	   Sword1:SetAsync(Plr.UserId, SwordP.Value)
   end)
	--- Defense
   Defense.Value = Defense1:GetAsync(Plr.UserId) or Defense.Value
	   Defense1:SetAsync(Plr.UserId, Defense.Value)
	Defense.Changed:connect(function()
	   Defense1:SetAsync(Plr.UserId, Defense.Value)
   end)
	--- Luck
   Luck.Value = Luck1:GetAsync(Plr.UserId) or Luck.Value
	   Luck1:SetAsync(Plr.UserId, Luck.Value)
	Luck.Changed:connect(function()
	   Luck1:SetAsync(Plr.UserId, Luck.Value)
   end)
	--- Special
   Special.Value = Special1:GetAsync(Plr.UserId) or Special.Value
	   Special1:SetAsync(Plr.UserId, Special.Value)
	Special.Changed:connect(function()
	   Special1:SetAsync(Plr.UserId, Special.Value)
	end)
	--- Points
   Points.Value = Points1:GetAsync(Plr.UserId) or Points.Value
	   Points1:SetAsync(Plr.UserId, Points.Value)
		Points.Changed:connect(function()
	   Points1:SetAsync(Plr.UserId, Points.Value)
   end)
end)

game.Players.PlayerAdded:Connect(function(plr)
	wait(.1)
	local Exp = plr.Data.Exp
	local Levels = plr.Data.Levels
	local ExpNeed = plr.Data.ExpNeed
	local Points = plr.Data.Points
	
	while wait() do
		if Exp.Value >= 170 * (Levels.Value * 1) and Levels.Value <= 4499 then
			Points.Value = Points.Value + 3
			Exp.Value = Exp.Value - ExpNeed.Value
			Levels.Value = Levels.Value + 1
			ExpNeed.Value = ExpNeed.Value + 170
			game.ReplicatedStorage.LevelSystem.LevelUpGui:FireClient(plr)
		end
		if Levels.Value >= 4499 then
			Exp.Value = (170 * Levels.Value)
		end
	end
end)

game.Players.PlayerRemoving:connect(function(Player)
	Bounty1:SetAsync(Player.UserId, Player.leaderstats.Bounty.Value)
	PvpSystem1:SetAsync(Player.UserId, 0)
	Level1:SetAsync(Player.UserId, Player.Data.Levels.Value)
	Beli11:SetAsync(Player.UserId, Player.Data.Beli.Value)
	Gems1:SetAsync(Player.UserId, Player.Data.Gems.Value)
	Exp1:SetAsync(Player.UserId, Player.Data.Exp.Value)
	ExpNeed1:SetAsync(Player.UserId, Player.Data.ExpNeed.Value)
	HealthAdd1:SetAsync(Player.UserId, Player.Data.HealthAdd.Value)
	SwordP1:SetAsync(Player.UserId, Player.Data.SwordP.Value)
	DefenseP1:SetAsync(Player.UserId, Player.Data.DefenseP.Value)
	LuckP1:SetAsync(Player.UserId, Player.Data.LuckP.Value)
	SpecialP1:SetAsync(Player.UserId, Player.Data.SpecialP.Value)
	Sword1:SetAsync(Player.UserId, Player.Data.Sword.Value)
	Defense1:SetAsync(Player.UserId, Player.Data.Defense.Value)
	Luck1:SetAsync(Player.UserId, Player.Data.Luck.Value)
	Special1:SetAsync(Player.UserId, Player.Data.Special.Value)
	Points1:SetAsync(Player.UserId, Player.Data.Points.Value)
end)

and DataStore in ServerScriptService:

game.Players.PlayerAdded:connect(function(player)
	local datastore = game:GetService("DataStoreService"):GetDataStore(player.Name.."Stats")
	player:WaitForChild("Data")
	local stats = player:FindFirstChild("Data"):GetChildren()
	
	for i = 1, #stats do
		stats[i].Value = datastore:GetAsync(stats[i].Name)
	end
	
	wait()
	print("Status carregado com sucesso")	
end)

game.Players.PlayerRemoving:connect(function(player)
	local datastore = game:GetService("DataStoreService"):GetDataStore(player.Name.."Stats")
	local statstorage = player:FindFirstChild("Data"):GetChildren()
	
	for i = 1, #statstorage do
		datastore:SetAsync(statstorage[i].Name, statstorage[i].Value)
	end
	
	print("Status salvo com sucesso")	
end)
1 Like
#2

Look how many requests you’re sending here, that’s the reason.
I suggest storing those stats inside a table and then simply save that table and do the rest needed.

2 Likes
#3

Thanks for the tip, I did it differently and it worked, simply the ‘Data’ Script was with the PlayerRemoving saving the data, and in the ‘DataStore’ script there was also a PlayerRemoving saving the data (only in a table).
Just deleted PlayerRemoving from ‘Data’ script and now it’s perfect

1 Like
#4

On top of what @Valkyrop said, you’re saving every value every time they change.

3 Likes