Problem with making a single GUI visible when near 2 different models

Help and Feedback Scripting Support
1

Hello, so in my script I have loops that checks if a player is close enough to 2 different models and if they are then a GUI pops up but if there not then it wont pop up

but

some reason the first for loop is not working, it only works if I remove the second for loop

How do I fix this or Is there another way I could do this? btw ignore the wait(1)

Screenshot (526)
Screenshot (526)632×539 25.2 KB

GUI is showing up for the door but not the mystery box

Screenshot (528)
Screenshot (528)944×449 401 KB

2

Since those loops are nearly the same thing, you could turn it into a function and use an argument for the location in which GetChildren() is called on. Maybe that will work for you.

Also I just noticed you are setting the same label to visible or not visible depending on if you are near an object, which means you need to choose if it should be visible or not depending if you are near any of the objects, and not just a single one.

3

so should i try 2 for loops in that function? cause these models are in separate folders and call the function in a while loop?

4

I meant that you only need to use 1 for loop, but swap out the parent that the GetChildren() is using in the loop. For example:

local function loopThrough(location)
	for _, find in pairs(location:GetChildren()) do
		-- the rest of the stuff
	end
end

while true do
	task.wait(1)
	loopThrough(MysteryBoxes)
	loopThrough(Doors)
end

Also you should have the function return a boolean if a player was in proximity of an object. Then compare both booleans to determine if the label should be visible.

Rough example:

local found1 = loopThrough(MysteryBoxes)
local found2 = loopThrough(Doors)
if found1 and found2 then
    Label.Visible = true
else
    Label.Visible = false
end
5

hmm so I did that and its still doing the same problem

6

Can you post the code you currently have?

7

yes

Screenshot (530)
Screenshot (530)1000×513 24.1 KB

8

This is what I meant by returning something from the function to tell the loop if it should show the label or not:

local InteractLabel = script.Parent.InteractLabel

local function InteractGui(Objects)
	for _, find in pairs(Objects:GetChildren()) do
		local Body = find:WaitForChild("Body")
		local CostValue = find:WaitForChild("CostValue")
		if Body:IsA("BasePart") and CostValue.ClassName:find("Value") then
			if (Body.Position - RootPart.Position).magnitude <= 7 then
				return true, Body.Parent.Name.." ["..CostValue.Value.."]"
			end
		end
	end
	return false, false
end

while true do
	task.wait(1)
	local found1, text1 = InteractGui(MysteryBoxes)
	local found2, text2 = InteractGui(Doors)
	if found1 and found2 then
		InteractLabel.Text = text1 or text2 or ""
		InteractLabel.Visible = true
	else
		InteractLabel.Text = ""
		InteractLabel.Visible = false
	end
end

Hope this helps!

9

its not working and Sorry for making you type most of my code down

10

its fine if you cant figure it out, I’m sure someone else can help

11

Have both loops set a separate Bool variable, then at the end of the while loop do something like the following.

if bool1 and bool2 then
	InteractLabel.Visible = true
else
	InteractLabel.Visible = false
end

Since you didn’t copy and paste the code here I can’t really help any further.