Script gives error when making variable

Help and Feedback Scripting Support
1

Hello,

I’m working with remote functions lately, but now when the script wants to check if the player has enough cash it gives an error cause its no longer in a local script. And I have no idea how I can make it that it works just fine in a normal script in serverscriptservice.

Can someone help me with this?

Here’s the serverscript;

local ReplicatedStorage = game:GetService("ReplicatedStorage")

local createPartRequest = Instance.new("RemoteFunction")
createPartRequest.Parent = ReplicatedStorage
createPartRequest.Name = "CreatePartRequest"

local player = game.Players.LocalPlayer
local Cash = player:WaitForChild("leaderstats"):WaitForChild("Cash")
local leaderstats = player.leaderstats

local function onCreatePartRequested(player)
	
	local tvclone = game.ReplicatedStorage.Tvs.OldTv.PartsOfOldTv:Clone()
	tvclone.Parent = game.Workspace

	for i, v in pairs(tvclone:GetChildren()) do
		v.Anchored = false
		v.CanCollide = true
		v.Transparency = 0
	end

	
	if Cash.Value >= 300 then
		return tvclone
	else
		print("You don't have enough cash to buy this!")
		
	end
end

createPartRequest.OnServerInvoke = onCreatePartRequested
2 Likes
3

Can you show us the error you’re getting?

4

image

5

The error comes from ServerScriptService, I assume it’s a server-script.
LocalPlayer only exists on the client, not the server.

local player = game.Players.LocalPlayer

EDIT - It seems like the leaderstats have not been created when the script tries to access it.
Make sure it exists when the server invokes the client instead.

6

Yea I know but do you have any idea how I can make it work on a normal server?

7

I would recommend a RemoteEvent instead.
If you want the script to affect the player activating it, it has to be a localscript.

8

OnServerInvoke event does contain a player argument itself. You don’t need to define it again.

@AlphazxParticles

This is not correct. OnServerInvoke is a function itself. You don’t need to use Connect again.

9

No, remote functions are going to return stuff remote event not so thats why I am using remote functions!

10

At least fix your code, LocalPlayer does NOT exist on the server-side.
You already have the player parameter in your onCreatePartRequested function.

11

Does anyone else know how I can make it work?

12

Yes, by removing your player variable above your function.
Try that in the first place.

13

Just delete the line you are defining with LocalPlayer and move the lines which you defined something with the player you wrote out of the invoke, then you will see it will be working.

This is your revised script.

local ReplicatedStorage = game:GetService("ReplicatedStorage")

local createPartRequest = Instance.new("RemoteFunction")
createPartRequest.Parent = ReplicatedStorage
createPartRequest.Name = "CreatePartRequest"

local function onCreatePartRequested(player)

    local tvclone = game.ReplicatedStorage.Tvs.OldTv.PartsOfOldTv:Clone()
    tvclone.Parent = game.Workspace

    local Cash = player:WaitForChild("leaderstats"):WaitForChild("Cash")
    local leaderstats = player.leaderstats

    for i, v in pairs(tvclone:GetChildren()) do
	    v.Anchored = false
	    v.CanCollide = true
	    v.Transparency = 0
    end


    if Cash.Value >= 300 then
	    return tvclone
    else
	    print("You don't have enough cash to buy this!")	
    end
end

createPartRequest.OnServerInvoke = onCreatePartRequested
14

I did that but that doesnt works…

15

At least elaborate a little bit more than “it doesn’t work”, what’s the error?

16

image

17

This doesn’t works either cause when I change the value to 200 then it will clone either way.

18

Yes, this is because you are cloning it before checking the value. Simply do

if Cash.Value >= 300 then
    local tvclone = game.ReplicatedStorage.Tvs.OldTv.PartsOfOldTv:Clone()
    tvclone.Parent = game.Workspace
else
    print("You don't have enough cash to buy this!")	
end

Delete the first two line at the beginning of the function and move them into the if statement.

19

Even then it still says the same error as above.

20

its still saying this error ServerScriptService.TvScripts.Philips:21 attempt to index nil with ‘value’

21

When is the leaderstats & Cash object created? It seems like it can’t find it.