Script is disabled, but still works

Help and Feedback Scripting Support
#1

This script is supposed to increase the value of a NumberValue every one second, however, when I disable it, the value continues to rise. Please help!

while true do
	wait(1)
	script.Parent.Temperature.Value = script.Parent.Temperature.Value + 1
end

It is disabled by a line of code from a different script.

core.Heater.Disabled = true
#2

Check to make sure the line of code is firing, and ensure you are referencing the correct script. The script should disable and value should stop rising.

#3

I checked.
If I destroy the script, the value stops rising. However, when I disable it, it continues to rise.
It’s being referenced right, and the code is firing.

#5

Make sure you do not have any other script that’s got something to do with that specific value rising.

#6

Yeah, I checked that as well. If I had those running, if I destroyed the script, the temperature would still rise. It only rises if I disable it. On destruction, rising stops.

#7

So have you found your issue or are you still having the same problem?

#8

Same problem. I may have to consider cloning the script or something, but this is very odd.

#9

So you are just trying to disable rising entirely, back at where you said it only rises if I disable it you could try do the opposite of it.

#10

True, but that’s an extra script, and adds unnecessary complications.

#11

Alright, I fixed it.

I had to put a check in the while true do function to only run if the script wasn’t disabled. This seems to have fixed it. Thanks for the help everyone :grinning_face_with_smiling_eyes: .

#12

I can’t think of anything else that could be causing this, but you could make your code more efficient by using either a bindable event or a .Changed event from a bool value to stop the heater.

#13

See, the script already compiled, hence why it’s running.

#14

I just realised is the core.Heater.Disabled = true in the loop?

#15

Maybe you can try this:

repeat
wait(1)
script.Parent.Temperature.Value = script.Parent.Temperature.Value + 1
until
script.Disabled == true

(btw im pretty sure loops of any kind in a disabled script will still run even if the script is disabled.)

1 Like
#16

Try putting core.Heater.Disabled = true in the loop. I believe if you do then it would always be checking if its disabled.

#17

Solution has been marked everyone, no need to add any more answers. Thank you.