Simple script not working

Help and Feedback Scripting Support
1 
local MoneyStore = DataStoreService:GetDataStore("Moneyds")
local RebirthStore = DataStoreService:GetDataStore("Rebirthsds")
local button = game.StarterGui.ScreenGui.TextButton
game.Players.PlayerAdded:Connect(function(player)
	local leaderstats = Instance.new("Folder",player)
	leaderstats.Name = "leaderstats"
	
	local Money = Instance.new("IntValue",leaderstats)
	Money.Name = "Money"
	Money.Value = MoneyStore:GetAsync(player.UserId) or 0
	
	local Rebirths = Instance.new("IntValue",leaderstats)
	Rebirths.Name = "Rebirths"
	Rebirths.Value = RebirthStore:GetAsync(player.UserId) or 0
	
	
	button.MouseButton1Click:Connect(function(player)
		Money.Value = Money.Value + 1 
		
		
		
	end)
end)

game.Players.PlayerRemoving:Connect(function(player)
	pcall(function()
		MoneyStore:UpdateAsync(player.UserId,player.leaderstats.Money.Value)
		RebirthStore:UpdateASync(player.UserId,player.leaderstats.Money.Value)
	end)
	
end)
there are no errors in the output, but when i click the button nothing happens
2

First of all, is this a server script or a local script?

3

Regular script inside of serverscriptservice

4

Then, you cannot use server scripts for UI stuff. You should use local scripts instead.

5

You are supposed to be calling the button from the player’s PlayerGui not from the StarterGui, the StarterGui is only there for holding Gui objects not for calling it, you should be detecting the MouseButton1Click event in a local script not on the server.

6

Then how can I call the leaderstats?

7

You can place a remove event in replicated storage, then fire that event from the client whenever the button is clicked, and update the leaderstats on server event.

8

Could you help me make the script? Basically every time the button is pressed the players money goes up by one.

9

You should rather use a Remote event so that when you click a button then you can fire the remote event to the server which then can add up your money value. So first of all add a remote event in the ReplicatedStorage and do this:

Script

local MoneyStore = DataStoreService:GetDataStore("Moneyds")
local RebirthStore = DataStoreService:GetDataStore("Rebirthsds")
local button = game.StarterGui.ScreenGui.TextButton
game.Players.PlayerAdded:Connect(function(player)
	local leaderstats = Instance.new("Folder",player)
	leaderstats.Name = "leaderstats"
	
	local Money = Instance.new("IntValue",leaderstats)
	Money.Name = "Money"
	Money.Value = MoneyStore:GetAsync(player.UserId) or 0
	
	local Rebirths = Instance.new("IntValue",leaderstats)
	Rebirths.Name = "Rebirths"
	Rebirths.Value = RebirthStore:GetAsync(player.UserId)

end)

game.ReplicatedStorage.RemoteEvent.OnServerEvent:Connect(function()

Money.Value = Money.Value + 1

end)

Localscript

Button.MouseButton1Click:Connect(function()
        game.ReplicatedStorage.RemoteEvent:FireServer() -- make sure you have created a remote event in the replicated storage

end)

and also make sure to call the Button from the player’s gui, like this:

local Player = game.Players.LocalPlayer
local PlayerGui = Player:WaitForChild("PlayerGui")
local Button = PlayerGui:WaitForChild("Button")
1 Like
10 
--Local script
local remoteEvent = --navigate to the event, preferably in ReplicatedStorage
local button = -- navigate to the button

button.MouseButton1Click:Connect(function()
    remoteEvent:FireServer()
end)

--Server script
local remoteEvent = --navigate to the event, preferably in ReplicatedStorage

remoteEvent.OnServerEvent:Connect(function(player)
    player.leaderstats.Money.Value += 1
    --[[ This is the same as saying:
     player.leaderstats.Money.Value = player.leaderstats.Money.Value + 1
    ]]
end)
11

10:04:14.309 - Infinite yield possible on ‘Players.U_npluggedDev:WaitForChild(“PlayerGUI”)’

10:04:03.628 - Infinite yield possible on ‘RobloxReplicatedStorage:WaitForChild(“GetServerVersion”)’

I got 2 errors in orange

12

Its PlayerGui not PlayerGUI, mhm

1 Like
13

10:04:03.628 - Infinite yield possible on ‘RobloxReplicatedStorage:WaitForChild(“GetServerVersion”)’

14

Did you add a remote event in the replicated storage?

1 Like
15

yes. RemoteEvent. What does GetServerVersion mean tho

16

This is Roblox side error. It has nothing to do with your script.

2 Likes
17

I’m not actually sure, I have had that error before, might be something to do with something else.

1 Like