Thoughts on my 3D perlin noise script?

[x86_architecture (TritiumAndDeuterium)]

I made a script that generates a 3D perlin noise map / cube. Here is how it looks like:

Here is the script:

local MapSize = 64
math.randomseed(tick())
local Seed = math.random(-1000000000, 1000000000) % math.random(-1000000000, 1000000000)
math.randomseed(Seed)
local Seed = math.random(-1000000000, 1000000000) % math.random(-1000000000, 1000000000)
local NoiseScale = 10
local Amp = 20
local BlockSize = 2
local MaxDensity = -14 -- Must be a  Number between -10, 10

-- -969535336

for x = 0, MapSize do
	for z = 0, MapSize do
		for y = 0, MapSize do
			local Xnoise = math.noise(y / NoiseScale, z / NoiseScale, Seed) * Amp
			local Ynoise = math.noise(x / NoiseScale, z / NoiseScale, Seed) * Amp
			local Znoise = math.noise(x / NoiseScale, y / NoiseScale, Seed) * Amp
			
			local Density = Xnoise + Ynoise + Znoise
			
			if Density < MaxDensity then
				local Part = Instance.new("Part", workspace)
				
				Part.Anchored = true
		        Part.Reflectance = 1		
				Part.Size = Vector3.new(BlockSize, BlockSize, BlockSize)
				
				Part.CFrame = CFrame.new(x*BlockSize, y*BlockSize, z*BlockSize)
			end
		end
	end
	wait()
end

One thing you can do is go to line 20 (Where the local density variable is), then you add + y to the equation. This will give you a result similar to this:

I was wondering if someone has feedback on this.

[Sublivion]

There is no need to pass arguments to your math.random because it will generate a random number with lots of decimal points anyway. Just multiply it by a constant if you feel results aren’t random enough. You can use ticks for seeds too.

Also, consider using the new class Random. Apparently it is more efficient, more random, and a better interface.

What is the purpose of the wait() at the end of the first for loop? This shouldn’t be in a game because it would just slow down the generation. If it’s to prevent studio crashing or to visualise it then I get it.

I’d also suggest you move to camel case for variables because it increases readability and conforms with standards but I suppose that’s just a personal preference. I used to use Pascal case for everything for about 5 years then suddenly switched a few years ago. Was 100% worth it.

Apart from that the generation algorithm looks very good.

[x86_architecture (TritiumAndDeuterium)]

Just multiply it by a constant if you feel results aren’t random enough.

Do you mean just multiply the random number by a number?

What is the purpose of the wait() at the end of the first for loop?

It is quite obvious lol. To prevent crashing.

I’d also suggest you move to camel case for variables because it increases readability and conforms with standards but I suppose that’s just a personal preference.

What is camel case? I have been using local variables the whole time I have been scripting on roblox.

Apart from that the generation algorithm looks very good.

Yes the algorithm is logical. We generate enough 2D noise maps with the right arguments every time then we combine them in the “Density” variable by adding them.

[Sublivion]

Do you mean just multiply the random number by a number

Yes

It is quite obvious lol. To prevent crashing.

There’s no reason for it to crash.

What is camel case?

Camel case is the naming of variables likeThis, as opposed to LikeThis. More information here.

[x86_architecture (TritiumAndDeuterium)]

There’s no reason for it to crash.

Well mine slows down. Especially if generating a large world at once.

[Sublivion]

I suppose if you want it to behave that way it is fine. Good script.

[Halalaluyafail3 (FindFirstChild)]

@DragRacer31

local Part = Instance.new(“Part”, workspace)

PSA: Don't use Instance.new() with parent argument

I’ve discovered a pretty bad performance issue in one of top games that has to do with Instance.new and wanted to write about this, since this is not obvious unless you know the system inside out. Tthere are several ways to create a ROBLOX object in Lua: local obj = Instance.new(‘type’); fill obj fields local obj = Instance.new(‘type’, parent); fill obj fields local obj = util.Create(‘type’, { field1 = value1, … }) If you care at all about performance, please only use the first option - I wi…

Wouldn’t hurt to set parent last.

[Sublivion]

Oh big oof… how didn’t I notice this… tldr that article using the 2nd parameter of Instance.new is really slow so don’t do it

[Sublivion]

Pls like the post of the guy who pointed it out not me lol

[GreekForge]

Your generation looks weird, it feels as if you’ve inverted everything. The caves are full of blocks and the normal ground is empty.

Is this purposeful?

[x86_architecture (TritiumAndDeuterium)]

Your generation looks weird, it feels as if you’ve inverted everything. The caves are full of blocks and the normal ground is empty.

Maybe mess around with the variables in the script?

Is this purposeful?

It is up to you to find that out. If you find a purpose for this then use it.

[x86_architecture (TritiumAndDeuterium)]

Minecraft uses 3D perlin noise to make terrain. So you could make a game similar to minecraft with this script.