Too many Locker models spawning in!

[Not_Jdlranger (Jdlranger)]

I’m trying to spawn a Locker model only once each time this function runs. I’m trying to make a room spawning system like Doors. But it keeps spawning more than one, or none at all for some reason.

I wanted it so when the requiresLocker Parameter is true, then it spawns lockers based on the LockerCount parameter, but only spawns other furniture types when requiresLocker is false.

Code:

function furniture.FurnishRoom(room, requiresLocker, lockerCount)
    local FurnitureTemplates = room:FindFirstChild("Furniture")
    if not FurnitureTemplates then
        return
    end

    local lockersSpawned = 0  -- To track how many lockers have been spawned
    local totalTemplates = #FurnitureTemplates:GetChildren()  -- Get the total number of furniture templates

    -- Ensure that lockerCount doesn't exceed the number of templates available
    lockerCount = math.min(lockerCount, totalTemplates)

    for i, template in pairs(FurnitureTemplates:GetChildren()) do
        local newFurniture = nil
        if requiresLocker and lockersSpawned < lockerCount then
            newFurniture = workspace.Furniture:WaitForChild("Locker"):Clone()
            lockersSpawned = lockersSpawned + 1
        else
            -- Spawn random furniture if no more lockers need to be spawned
            local randomIndex = furniture.Random:NextInteger(1, #furniture.TotalFurniture)
            local selectedModel = furniture.TotalFurniture[randomIndex]:Clone()
            newFurniture = selectedModel
        end

        -- If newFurniture is valid, set its position and parent it
        if newFurniture then
            -- Ensure that newFurniture has a primary part (it must to use SetPrimaryPartCFrame)
            if newFurniture.PrimaryPart then
                newFurniture:SetPrimaryPartCFrame(template.CFrame)
                newFurniture.Parent = template.Parent
                template:Destroy()  -- Destroy the template once the furniture is placed
            end
        end
    end
end

[xcreatee]

Hi @Not_Jdlranger

I don’t kinda undestand what you are talking about but because of this

 else
            -- Spawn random furniture if no more lockers need to be spawned
            local randomIndex = furniture.Random:NextInteger(1, #furniture.TotalFurniture)
            local selectedModel = furniture.TotalFurniture[randomIndex]:Clone()
            newFurniture = selectedModel
 end

insted try

        if requiresLocker and lockersSpawned < lockerCount then
            newFurniture = workspace.Furniture:WaitForChild("Locker"):Clone()
            lockersSpawned = lockersSpawned + 1
        elseif  requiresLocker and lockersSpawned == lockerCount then
            -- Spawn random furniture if no more lockers need to be spawned
            local randomIndex = furniture.Random:NextInteger(1, #furniture.TotalFurniture)
            local selectedModel = furniture.TotalFurniture[randomIndex]:Clone()
            newFurniture = selectedModel
        end

[Not_Jdlranger (Jdlranger)]

try what? i saw code get deleted. EDIT: Thx

[xcreatee]

Sorry i made little issue while copying.

[Not_Jdlranger (Jdlranger)]

Found it:

function furniture.FurnishRoom(room, requiresLocker, lockerCount)
    local FurnitureTemplates = room:FindFirstChild("Furniture")
	if not FurnitureTemplates then return end
	
	local totalFurniture = {}
	
	for i, template in pairs(FurnitureTemplates:GetChildren()) do
		local randomFurniture = furniture.Random:NextInteger(1,#furniture.TotalFurniture)
		local furnitureModel = furniture.TotalFurniture[randomFurniture]:Clone()
		furnitureModel:PivotTo(template.CFrame)
		furnitureModel.Parent = template.Parent
		table.insert(totalFurniture, furnitureModel)
	end
	
	if requiresLocker then
		local totalLockers = 0

		for _, obj in ipairs(totalFurniture) do
			if obj.Name == "Locker" then
				totalLockers += 1
			end
		end
		
		if totalLockers > lockerCount then
			local deletionTimes = (totalLockers-lockerCount)
			for i = 1,deletionTimes do
				
				for i,v in pairs(room:FindFirstChild("Furniture"):GetChildren()) do
					if v.Name == "Locker" then
						v:Destroy()
						print("deleted locker",room)
						break
					end
				end
			end
			
		end
		
	end
end