Trying to use .Changed on an int value returns error

Help and Feedback Scripting Support
#1

I’m literally just trying to use a basic .Changed function on an int value I created earlier in the script and put in a folder in the player. When I try to do that I get this error - [ attempt to index nil with ‘Changed’] I know this means that the value isn’t there, but the problem is it is!

--creating values
local playerStats = utility.new("Folder", player, "PlayerStats")
speed = utility.new("IntValue", playerStats, "Speed")

speed.Changed:Connect(function(newVal)
	humanoid.WalkSpeed = newVal
end)

Basically the utility easily creates values without extra steps, but while this works perfectly for leaderstats, for this folder it does nothing. Also in my other script where I try to get it from the player inside a playeradded function it says infinite yield possible on the folder.

function onPlayerAdded(plr)
	--[[stats = plr:WaitForChild("PlayerStats")
		print(stats.Name)
	speed = stats:FindFirstChild("Speed")--]]
--other stuff
end

game.Players.PlayerAdded:Connect(onPlayerAdded)

If I go into the server the folder is definitely there which confuses me.
If you need any extra information ask! Thanks.

1 Like
#2

Can you do a print(speed.Parent) before the .Changed line? Let me know what it gives you.

#4

Read the post entirely before asking questions like these.

#5

Ok I did that, and it said a weird error about a concentrated string (that now that I changed back from .Name I can’t seem to reproduce). So i added .Name to that and then it said, attempted to index nil with parent.

#6

Right. This means that the instance either doesn’t get created with your module, or you’re trying to access it too soon. Can you provide the utility.new() code? You might’ve forgotten to return the value after it’s created.

#7

Ok here is a screenshot of what is inside of my player on the server (It looks the same on the client). Screenshot by Lightshot

	local utility = {}
	
	utility.new = function(a,b,c,d)
		local i = Instance.new(a)
		if c then
			i.Name = c
		end
		if d then
			for p,v in next,d do
				i[p]=v
			end
		end
		if b then
			i.Parent = b
		end
		return i
	end

return utility
#8

Can you add a print(a) at the start of the utility.new function of yours? (just trying to debug this)

1 Like
#11

It prints folder (leaderstats), intvalue x3 then folder again (playervalues) then intvalue x2. I’m really confused because it is showing up in the player, but it stays saying it’s nil.

#12

Try using Instance.new() for debugging purposes.

#13 
		speed = Instance.new("IntValue")
		speed.Name = "Speed"
		speed.Parent = playerStats
		speed.Value = 25

same error- [1:46:13.837 - ServerScriptService.Server:246: attempt to index nil with ‘Parent’]

i then tried just printing playerstats which said attempted to index nil with Name. So is the script running like while creating the values moving on to the next part of the script? I’m going to sleep maybe I’ll figure it out in the morning thanks for trying to help.

#14

I find this odd. When I try this for myself, it works perfectly. This is just a blind shot, but could you try adding a wait() in-between local playerStats and speed?

#15

That makes no sense, why would speed be nil? You literally just defined it with Instance.new().

#16

@spicychilly2 And this is probably the weirdest part. I reference speed in another spot,

local function onCharacterAdded(character)
	local player = players:GetPlayerFromCharacter(character)
	humanoid = character:FindFirstChild("Humanoid")
	humanoid.WalkSpeed = speed.Value

and it works fine? I also change speeds value in multiple places and it works fine. That’s why I’m so confused about why it’s only giving nil in the .Changed. I’m going to try one more thing and that is move that function right next to where I create speed.

#17

How is speed defined here? I don’t see it defined in the onCharacterAdded function as it needs to be.

#18

That’s why speed is not local when I create it so I can reference it in other places, though this might not be the best practice I’m not sure.

Ok well I moved the Changed function next to where I create speed, and now I’m no longer getting an error which is nice, but in my other scripts where I reference the folder I’m still getting and infinite yield possible on it.

#22

Couldn’t reproduce the issue. I wrote pretty much the same code as you did except with my own conventions in place and I did not get any such error. Are you perhaps overwriting a variable or not properly calling your module? It’d be worth printing what “speed” is to further debug this.

My version of utility 
local utility = {}

function utility.new(class, name, parent, propertiesTable)
	local instance = Instance.new(class)
	
	if name then
		instance.Name = name
	end
	
	if propertiesTable then
		for property, value in pairs(propertiesTable) do
			-- Don't want it happening even accidentally
			if property ~= "Parent" then
				instance[property] = value
			end
		end
	end
	
	if parent then
		instance.Parent = parent
	end
	
	return instance
end

return utility
My unit testing code 
local Players = game:GetService("Players")
local ServerScriptService = game:GetService("ServerScriptService")

local UTILITY = require(ServerScriptService.Utility)

local function playerAdded(player)
	local playerStats = UTILITY.new("Folder", "PlayerStats", player)
	local speed = UTILITY.new("IntValue", "Speed", playerStats)
	
	speed.Changed:Connect(function (newValue)
		print(newValue)
	end)
end

Players.PlayerAdded:Connect(playerAdded)
for _, player in ipairs(Players:GetPlayers()) do
	playerAdded(player)
end

Repro file:
Utility Repro.rbxl (18.6 KB)

All code is in ServerScriptService. ^

1 Like