Uniform GUI Script is not working, no errors

Help and Feedback Scripting Support
1

Alright, I’m scripting a uniform GUI that allows you to select a uniform based on your rank in the main group. This part, to the best of my knowledge, is working. The button works and the GUI opens, but the problem is that I scripted one of the buttons, the HR button. The hierarchy and script for it is below.

image
image333×592 78.4 KB 

local hr = script.Parent.Parent.StarterGui.ScreenGui.UniformGUI.HR

hr.MouseButton1Click:Connect(function()
	game.Players.PlayerAdded:Connect(function(plr)
		print("hi")
		plr:WaitForChild("Character").Shirt.ShirtTemplate.Value = 513567320
		print("hi")
		plr:WaitForChild("Character").Pants.PantsTemplate.Value = 513570472
		print("hi")
	end)
end)

I could really use some help as it isn’t even printing the first “hi.”

2

When the player loads in, GUIs are cloned to their StarterPlayerGUIs. The GUI you want to reference is not the one in startergui, but the one in the starterplayergui. You should also switch to using localscripts and remoteevents to handle these kinds of requests.

1 Like
3

Alright, I tried to implement this but this new code still isn’t working and I’m getting no “hi’s.”

        
        game.Players.PlayerAdded:Connect(function(plr)
        local hr = plr.PlayerGui.ScreenGui.UniformGUI.HR
        hr.MouseButton1Click:Connect(function() 
        print("hi")
        plr:WaitForChild("Character").Shirt.ShirtTemplate.Value = 513567320
        print("hi")
        plr:WaitForChild("Character").Pants.PantsTemplate.Value = 513570472
        print("hi")
    end)
end)

Also I’ll stick with how I’m doing it already so far as I’m not that advanced and will probably end up breaking more stuff, but thanks for the advice.

4

I think it would be better to add a localscript under the HR button. Copying this should work:

script.Parent.MouseButton1Click:Connect(function()
    print("hi")
    plr:WaitForChild("Character").Shirt.ShirtTemplate.Value = 513567320
    print("hi")
    plr:WaitForChild("Character").Pants.PantsTemplate.Value = 513570472
    print("hi")
end)

However, this won’t replicate to clients. You should have a listener on the server to change your clothing template.

1 Like
5

Alright at least I got a console output this time, but;

image
image1126×82 34.6 KB

Also in the script you gave me, “plr” isn’t defined.

6

My bad. You should define the plr, in this case, it should be game.Players.LocalPlayer.Character

1 Like
7

image
image1132×91 37.3 KB

This is the new one;

local plr = game.Players.LocalPlayer.Character

script.Parent.MouseButton1Click:Connect(function(plr)
	print("hi")
	plr:WaitForChild("Character").Shirt.ShirtTemplate.Value = 513567320
	print("hi")
	plr:WaitForChild("Character").Pants.PantsTemplate.Value = 513570472
	print("hi")
end)
8

You don’t need waitforchild anymore. It’s already defined at the top.

1 Like
9

Yep, I removed it just before you replied, but now this. This is why I haven’t changed my group title to programmer yet :sad:

image
image976×25 12.1 KB 

local plr = game.Players.LocalPlayer.Character

script.Parent.MouseButton1Click:Connect(function()
	print("hi")
	plr.Character.Shirt.ShirtTemplate.Value = 513567320
	print("hi")
	plr.Character.Pants.PantsTemplate.Value = 513570472
	print("hi")
end)
10

No, I meant removing the entire waitforchild so it becomes like this:

plr.Shirt.ShirtTemplate.Value = 513567320
1 Like
11

image
image1116×49 25.7 KB

I tried to do tonumber() but it still didn’t wanna cooperate

local plr = game.Players.LocalPlayer.Character

script.Parent.MouseButton1Click:Connect(function()
	print("hi")
	plr.Shirt.ShirtTemplate.Value = tonumber(513567320)
	print("hi")
	plr.Pants.PantsTemplate.Value = tonumber(513570472)
	print("hi")
end)
12 
plr.Shirt.ShirtTemplate = 513567320
13

Alright thanks this worked, but it just took my shirt and pants off, it didn’t replace them.

14

try

plr.Shirt.ShirtTemplate = "rbxassetid://" .. 513567320
1 Like