What am I doing wrong with this?

Help and Feedback Scripting Support
#1 
Remote.OnClientEvent:Connect(function()
local groups = {script.Parent.Frame:FindFirstChild("Things"), script.Parent.Frame:FindFirstChild("Things2")}


for _, i in ipairs(groups) do
		
		for _, e in pairs(i:GetDescendants()) do
			
			for _, d in pairs(plrresearch:GetChildren()) do 
				
					local NAMES = d
				local TroopsVALUE = d.Value
				
					
				if e.Name == NAMES.Name  then if e:IsA("ViewportFrame")  then 
						
						for _, q in pairs(e:FindFirstChild("BUY")) do -- HERE THERE IS A INVALID ARGUMENT ERROR
							if q:IsA("TextButton") then

--something happens idk
print("Something, Idk yet")














end
end


end
end

end
end

end
end)
1 Like
#2

Here is a more organized version :

local replicated = game:GetService("ReplicatedStorage")
local remote = replicated:WaitForChild("remote")

remote.OnClientEvent:Connect(function()
	local groups = {
		script.Parent.Frame:FindFirstChild("Things"), 
		script.Parent.Frame:FindFirstChild("Things2")
	}

	for _, i in ipairs(groups) do
		for _, e in pairs(i:GetDescendants()) do
			for _, d in pairs(plrresearch:GetChildren()) do 
				local NAMES = d
				local TroopsVALUE = d.Value
				if e.Name == NAMES.Name  then if e:IsA("ViewportFrame")  then
						for _, q in pairs(e:FindFirstChild("BUY")) do -- HERE THERE IS A INVALID ARGUMENT ERROR
							if q:IsA("TextButton") then
								print("Something, Idk yet")
							end
						end
					end
				end
			end
		end
	end
end)

What is plrresearch ?

#3

What are the groups? What are you trying to make? Any errors in the output? What did the code do when you ran it? Please provide more info.

1 Like
#4

Clearing Up a bit.
I am trying to learn to make a thing where there is a Gui that will have the price of the item depending on what level item does the player own. There are multiple of these Items and there are Viewport frames named after them and the Player.Research has the Values / levels of the items.
(prices of things are on a module script that is basically just the same that I have for the server side , but just in replicated storage so its local, bc I don’t really care if they change the price on their screen, the module on server side is used for other things that require buying things , but thats besides the point)
I am currenctly trying to make it in a way that when the gui opens it detects what levels the things are and it puts the right prices.

I am currently stuck in that part of the script. I wish that I would find the most efficent method for this action.

Local player = game.Players.LocalPlayer
Local plrresearch = player.Research --(Folder containing Number Values)

It is expecting a table at

"invalid argument #1 to ‘pairs’ (table expected, got nil)

1 Like
#5

did you forget :getchildren() ?
the error says it all

#6

Where Did I forget :GetChildren?
I don’t see where I should have another one?

#7

since you used findfirstchild BUY is an instance
you cant loop over an instance it dont make sense

#8

i just quoted his original post and organized it.

1 Like
#9

i know theres still wrong code in there you cant loop over an instance it has to be a table

2 Likes
#10

show us the explorer tab of the gui if u still hadnt solved it

1 Like
#11

Location of the GUI

NÀyttökuva 2022-06-12 000444eeeeeeeeeeeeee

#12

is BUY the button youre to get or is there text buttons inside of it?

1 Like
#13

, “BUY” Is the one I am trying to Get

#14

yea i dont think i can help u fix your script, its too messy and doesnt make sense
if you want to detect click on the button just add a localscript to it and use mousebutton1click

#15

I don’t really understand the meaning of the loop here. BUY is a TextButton, a singular instance, there’s nothing you can loop through in it. If you wanted to check if the BUY exists, you can just do this:

local buyButton = e:FindFirstChild("BUY") -- this returns nil if the instance doesn't exist

if buyButton then
-- if the buyButton is NOT nil, then ... your code
else
#16

Yeah I know right, Btw this had nothing to do with clicking the button