What would be better to use for checking if GetAsync was Successful?

[DasKairo (Cairo)]

Which would be more efficient when checking if GetAsync was Successful?

I am talking about the return result parts of the code

if success then -- if successful
	if result then -- if Data
		return result -- returns result
	else -- If no Data
		return table.clone(self.Data) -- returns new Data
	end
else -- if Failed
	return -- returns nothing
end

if success then -- if successful
	return result or table.clone(self.Data) -- Result or new Data
else -- if Failed
	return -- returns nothing
end

Sorry if the Topic is a bit misleading, or too vague btw.

[Chaos_Geo]

The second might be slightly more performant, but it would be so small that it wouldn’t matter which one you use. Choose which one is more readable to you.

[boeljoet]

you can go smaller if u want

i gues you are using a pcall.
when u use a return inside the pcall the 2nd output will become the returned value

local succes,returnedvalue= pcall (function()
	return "test"
end)
if not succes then print(returnedvalue)end 

[Dev_Peashie]

I think the question is about how to handle the return better, splitted in an if statement or by using or.
Adding the not makes no difference at all for the question:

if not success then
	return -- nothing
else
	return result or table.clone(self.Data)
end

…

if success then
	return result or table.clone(self.Data)
else
	return -- nothing
end

[McThor2]

I’d typically use a guard statement pattern for this. E.g:

if not success then
    return 
end

if not result then
    return table.clone(self.Data)
end

return result

I find this to be the most readable as it reduces indentation and separates the different checks / logic clearly.

[DasKairo (Cairo)]

Late Replies but.

@Chaos_Geo

The second might be slightly more performant, but it would be so small that it wouldn’t matter which one you use. Choose which one is more readable to you.

Good to Know

---

@boeljoet

i gues you are using a pcall.

Nahh Really???

@boeljoet

local succes,returnedvalue= pcall (function()
	return "test"
end)

my pcall()

success, result = pcall(self.DataStore.GetAsync, self.DataStore, Key)

Its not Important however, Is whats I do after that is.

---

@Dev_Peashie

I think the question is about how to handle the return better

Yes

@Dev_Peashie

splitted in an if statement or by using or .

Yes

@Dev_Peashie

Adding the not makes no difference at all for the question:

Y E S. . .

---

@McThor2

I’d typically use a guard statement pattern for this. E.g:

if not success then
    return 
end

if not result then
    return table.clone(self.Data)
end

return result

I find this to be the most readable as it reduces indentation and separates the different checks / logic clearly.

That is neater, It might as well be cleaner