Whats a better way to do this that actually works?

Help and Feedback Scripting Support
#1

Screen Shot 2022-04-23 at 5.53.15 PM
Screen Shot 2022-04-23 at 5.53.15 PM1748Ă—1394 73.5 KB

1 Like
#2

Please considier putting the code on a block.

What do you want to achieve?

1 Like
#3

So i wanted to make something that sells my genetics and turns it into coins but its not working for some reason, it only works when the player starts of with a number of genetic and then it turns it to coins but when i click the tool that gives me genetics and try selling it to make it into coins it doesnt work.

1 Like
#4

Edit: Is a local?

Well since you cant change server values from a client then you need to use remote events, that would be a good option.

You should read this API reference and get more info about it.

1 Like
#5

no its not a local, but yeah i will look into it

2 Likes
#6

is there any other advice you got for me or any way of helping me?

#7

Check Bindable event instead then.

#8

Im sorry, but i have no clue what that is.

#9

The issue isn’t with networking as they’re using a Touched event which will presumably be done on the server.

I believe the issue will arise somewhere from your indexing. If your data is a leaderboard value, you’ll have to do “leaderstats” to reference the data folder, as seen in the following code:

local data = player:WaitForChild("leaderstats")

However, if it isn’t a leaderboard and is rather an internal datastore, the issue will be a logic issue, like the genetics value isn’t properly being updated

1 Like
#10

It is possible, although I would be more inclined to check if the player is within a radius in a localscript, and then fire an event to the server.

#11

Uploading: Screen Recording 2022-04-23 at 5.49.06 PM.mov…
Screen Shot 2022-04-23 at 6.16.25 PM


this is what i have

#12

what should i change for that script to actually work?

#13 
local part = script.Parent

part.Touched:Connect(function(hit)
	local player = game.Players:GetPlayerFromCharacter(hit.Parent)

	if player then
		local data = player:WaitForChild("leaderstats") -- YOUR FOLDER
		local coins = data.Coins
		local genetics = data.Genetics

		if coins and genetics then

			-- Your code

		end
	end
end)

I did this, put it inside the part, works perfectly.

Edit: Modify it so it works for you

#14

ok im goign to try that right now ill let you know

#15

where it says my code, i put
if Genetics.Value > 0 then
Coins.Value = Coins.Value + Genetics.Value *
Genetics.Value = 0

#16

Put that there

Summary

chaaaar

#17

its not working :c and i put that there,
their is also no errors

#18

want me to send you a vid? of it

#19 
local part = script.Parent

part.Touched:Connect(function(hit)
	local player = game.Players:GetPlayerFromCharacter(hit.Parent)

	if player then
		local data = player:WaitForChild("data")
		local coins = data.Coins
		local genetics = data.Genetics

		if coins and genetics then

			if genetics.Value > 0 then
				
				data.Coins.Value = data.Coins.Value + data.Genetics.Value * 1
				data.Genetics.Value = 0
				
			else
				return
			end
			
		end
	end
end)
#20

Alternatively check for proximity on the server … I’ve found it more convenient.

With regards to your latest post, sharing an entire code block is likely not going to teach the OP anything. A few comments would help.