Why are the abilities and leaderstats folder keep replicating

Help and Feedback Scripting Support
#1

I have 2 folders in the datastore, one called abilities, and one called leaderstats. However, they keep replicating. Does anyone know why?

my player added script

local userId = player.userId
	local key = "Player_" .. userId

	local leaderstats = Instance.new("Folder")
	leaderstats.Name = "leaderstats"
	
	local abilities = Instance.new("Folder")
	abilities.Name = "Abilities"
	
	abilities.Parent = player

	local cash = Instance.new("IntValue")
	cash.Name = "cash"
	
	
	
	local success, ret = 1, 1
	
	repeat
		waitForRequestBudget(Enum.DataStoreRequestType.GetAsync)
		local success, ret = pcall(datastore.GetAsync, datastore, key)
		print("trying")
	until success or not Players:FindFirstChild(player.Name)
	
	if success then
		cash.Value = ret or 0
		
		
		cash.Parent = leaderstats
		leaderstats.Parent = player
	else
		print("There was an error! " .. ret)
	end
#2

What is this waitForRequestBudget Function? Also is this in a PlayerAdded function are is it wrapped around the event?

#3
  1. Because the repeat is always trying it, the function is checking whether we have enough budget for that. 2. it’s a function, but i have a PlayerAdded:Connect(playerAdded)
#4

Might ask when you say it replicating, do you mean the actual instances keep replicating?

#5

Yup, the instances are duplicating itselves

And well, playing around with the scripts, they no longer do that, sorry for the late response

#6

Well now the instances get duplicated again

#7

Is the script in the ServerScriptService (Script) or is the script a local script?

#8

The script is in serverscriptservice

#9

I noticed that you parent the cash and leaderstat Instance after the loop is completed(otherwise when not Players:FindFirstChild(player.Name)) meaning it parents to a player instance thats been set to nil. Is this done purposefully?

#10

well, that was done purposefully, but it doesnt make any changes to the duplication problem