Why doesn't my UI load when this script runs?

Help and Feedback Scripting Support
,
1

So, I tried doing this script last night and it still didn’t work after I tried many times. Why won’t the script work/GUI load?

I’ve searched on the DevForum, I tried the Touched event, and ClickDetector, and now I’m doing ProximityPrompt. If I enable the GUI normally, it still loads… normally.

Here’s the script:

local prompt = script.Parent.ProximityPrompt

prompt.Triggered:Connect(function()
	game.StarterGui.dialogue.Frame.Visible = true
	game.StarterGui.dialogue.Frame.image.ImageLabel.Image = "0"
	game.StarterGui.dialogue.Frame.user.UserName.Text = "You"
	game.StarterGui.dialogue.Frame.desc.TheirDesc.Text = "Hello!"
end)

The script is also located in game.Workspace.[Part], same with the ProximityPrompt.

(the ProximityPrompt doesnt go away currently, ill fix that!!!)
(also this is my first DevForum post so if I missed something, sorry)

2

The starter GUI isn’t accessible once the game is running, you need to reference the player’s playerGui.
If you add the player argument into the function you should be able to use that to get the playerGui

2 Likes
3

UI cannot be accessed by the StarterGui, it is instead located in the LocalPlayer

local prompt = script.Parent.ProximityPrompt

prompt.Triggered:Connect(function(player)
	player.PlayerGui.dialogue.Frame.Visible = true
	player.PlayerGui.dialogue.Frame.image.ImageLabel.Image = "0"
	player.PlayerGui.dialogue.Frame.user.UserName.Text = "You"
	player.PlayerGui.dialogue.Frame.desc.TheirDesc.Text = "Hello!"
end)
4 Likes
4

Consider adding :WaitForChild methods into this, as it is replicated into PlayerGui from StarterGui (which takes a minimal but noticeable amount of time). If it is right at the start of script execution, it’ll most likely error out as it hasn’t finishing loading into the player.

5

This may sound complicated for now, but I think a better method would be to use a function provided by another script instead (using BindableEvents or ModuleScripts), so that the system is generally more efficient (No need to copy & paste all that code every time, and the code is situated in one script for easy maintenance).

Even better, just use the ProximityPromptService in a single server script (in ServerScriptService for security), along with CollectionService to use tags (using the Tag Editor) to identify if it’s a dialogue prompt, then use the prompt instance to search to get it’s relevant information, whether it’s through a dictionary, or through attributes.
It would be best to save this for future reference if you ever want to challenge yourself. c:

6

I’m not familiar with ProximityPromptService that well or anything like ModuleScripts lol. I can see if I can try copying the scripts on at least one of the pages but other than that, I’ve got no idea what I’m doing.

1 Like
7

Fortunately, I’m here to help. Unfortunately, I only have ~30min as of starting this.
If you want, I could quickly put together a model with all the things I’ve described to you just now, but I don’t think that’s a good way to learn.
I’d suggest setting your script up like this:

local PPS = game:GetService("ProximityPromptService")
local CS = game:GetService("CollectionService")

PPS.PromptTriggered:Connect(function(promptInstance, triggeringPlayer) -- Here, we connect to ProximityPromptService's .PromptTriggered event, which returns the prompt and the player who triggered it
	if CS:HasTag(promptInstance, "dialoguePrompt") then					-- We use CollectionService to check if the prompt has the tag "dialoguePrompt" (assign this in the Tag Editor window)
		local dialogueUI = triggeringPlayer.PlayerGui.dialogue:WaitForChild("Frame")
		dialogueUI.Visible = true
		dialogueUI.image.ImageLabel.Image = 0
		dialogueUI.user.UserName.Text = triggeringPlayer.Name				-- You can change this to any other string if you wanted to
		dialogueUI.desc.TheirDesc.Text = promptInstance:GetAttribute("desc") 	-- This will get the string stored in an attribute of the prompt named "desc"
	end
end)

I have included some comments to describe what the code is doing.
You should try figure the rest out from here. This code is based on what you provided in the original post.
One problem with this is that it only allows for one string to be shown at the moment. However, you could fix this by making a dictionary that contains all the strings for one prompt, with the key being the name of the prompt, or an attribute.
Had to rush this since I need to go now, lol.

HINT:

(All you need to do is add the “desc” attribute to the prompt, and give it the tag “dialoguePrompt” using the Tag Editor window, under the View tab c: )

8

try this:

local player = game.Players.PlayerAdded:Wait()

local prompt = script.Parent.ProximityPrompt

prompt.Triggered:Connect(function()
	player.PlayerGui.dialogue.Frame.Visible = true
	player.PlayerGui.dialogue.Frame.image.ImageLabel.Image = "0"
	player.PlayerGui.dialogue.Frame.user.UserName.Text = "You"
	player.PlayerGui.dialogue.Frame.desc.TheirDesc.Text = "Hello!"
end)
9

@Mister33j Has already given a straightforward answer

10

I̶ ̶d̶o̶n̶’̶t̶ ̶g̶e̶t̶ ̶t̶h̶i̶s̶ ̶p̶a̶r̶t̶.̶ ̶I̶ ̶s̶e̶a̶r̶c̶h̶e̶d̶ ̶i̶t̶ ̶u̶p̶,̶ ̶i̶s̶ ̶i̶t̶ ̶a̶ ̶p̶l̶u̶g̶i̶n̶ ̶o̶r̶ ̶s̶o̶m̶e̶w̶h̶e̶r̶e̶ ̶e̶l̶s̶e̶?̶ I found it, oopsy.

Also, I think I’m starting to get the other parts pretty well, so thanks for some help so far :smile:

1 Like
11

I have seen! But, since I am a quite new scripter, and I usually just watch a bunch of YouTube tutorials, I wanted to see if I could do anything different for a bit!