Data Isn't Saving When Value Changed

FaKeLoL2006 · July 11, 2023, 3:01pm

Hello, Does Anyone Know What’s Wrong With The Code?

The Script Doesn’t Output Anything In Console And Data Isn’t Saved
It’s Supposed To Print Something And Save Data When The Fuel Value Is Changed

Here Is Code:

local Settings = require(script.Parent.Fuel_Settings.Settings)
local PlayerDataHandler = require(game.ReplicatedStorage.PlayerDataHandler)

local Fuel = script.Fuel
local Seat = script.Parent

if Settings.Random_Fuel == true then
	Fuel.Value = math.random(25,60)
	wait(.5)
	while true do
		wait(0)
		if Seat.Throttle == 1 and Fuel.Value > 0 then
			wait(math.random(Settings.Min_Mpg, Settings.Max_Mpg))
			Fuel.Value = Fuel.Value - 1 
		end
	end
else if Settings.Random_Fuel == false then
		Fuel.Value = 15
		while true do 
			wait(0)
			if Seat.Throttle == 1 and Fuel.Value > 0 then
				wait(math.random(Settings.Min_Mpg,Settings.Max_Mpg))
				Fuel.Value = Fuel.Value - 1 
			end
		end
	end
end

Fuel.Value.Changed:Connect(function(player)
	print("Changed")
	PlayerDataHandler:Update(player, "Fuel", Fuel.Value)
end)

P1po666 · July 11, 2023, 3:09pm

maybe it’s because of the loop

normanthewarding · July 11, 2023, 3:10pm

yeah you might be right, the while loop might not be allowing the script to get to the end

P1po666 · July 11, 2023, 3:10pm

this should work

local Settings = require(script.Parent.Fuel_Settings.Settings)
local PlayerDataHandler = require(game.ReplicatedStorage.PlayerDataHandler)

local Fuel = script.Fuel
local Seat = script.Parent
task.spawn(function()
	if Settings.Random_Fuel == true then
		Fuel.Value = math.random(25,60)
		wait(.5)
		while true do
			wait(0)
			if Seat.Throttle == 1 and Fuel.Value > 0 then
				wait(math.random(Settings.Min_Mpg, Settings.Max_Mpg))
				Fuel.Value = Fuel.Value - 1 
			end
		end
	else if Settings.Random_Fuel == false then
			Fuel.Value = 15
			while true do 
				wait(0)
				if Seat.Throttle == 1 and Fuel.Value > 0 then
					wait(math.random(Settings.Min_Mpg,Settings.Max_Mpg))
					Fuel.Value = Fuel.Value - 1 
				end
			end
		end
	end
end)
Fuel.Value.Changed:Connect(function(player)
	print("Changed")
	PlayerDataHandler:Update(player, "Fuel", Fuel.Value)
end)

FaKeLoL2006 · July 11, 2023, 3:15pm

OK So I Tried The Code But Data Still Isn’t Saving And Console Doesn’t Output Anything

P1po666 · July 11, 2023, 3:18pm

By default, Settings.Random_Fuel is set to true?

normanthewarding · July 11, 2023, 3:19pm

P1po666:

local Settings = require(script.Parent.Fuel_Settings.Settings)
local PlayerDataHandler = require(game.ReplicatedStorage.PlayerDataHandler)

local Fuel = script.Fuel
local Seat = script.Parent

Fuel.Value.Changed:Connect(function(player)
	print("Changed")
	PlayerDataHandler:Update(player, "Fuel", Fuel.Value)
end)

task.spawn(function()
	if Settings.Random_Fuel == true then
		Fuel.Value = math.random(25,60)
		wait(.5)
		while true do
			wait(0)
			if Seat.Throttle == 1 and Fuel.Value > 0 then
				wait(math.random(Settings.Min_Mpg, Settings.Max_Mpg))
				Fuel.Value = Fuel.Value - 1 
			end
		end
	else if Settings.Random_Fuel == false then
			Fuel.Value = 15
			while true do 
				wait(0)
				if Seat.Throttle == 1 and Fuel.Value > 0 then
					wait(math.random(Settings.Min_Mpg,Settings.Max_Mpg))
					Fuel.Value = Fuel.Value - 1 
				end
			end
		end
	end
end)

try to see if this works??
\\\\\\\\\\\\\\\\

FaKeLoL2006 · July 11, 2023, 3:19pm

Here Is Fuel Settings Module

local Settings = {
	
	
	Random_Fuel = false; 
	
	
	Min_Mpg = 15; -- The minimum MPG a car will use. 
	Max_Mpg = 20; -- The maximum MPG a car will use. 
	
	Does_Refuel_Cost_Money = true;
	
	Min_Price_Gas = 6; -- Mininmum gas price
	Max_Price_gas = 15; -- Maximum gas price
}

return Settings

P1po666 · July 11, 2023, 3:23pm

change this

Fuel.Value.Changed:Connect(function(player)
	print("Changed")
	PlayerDataHandler:Update(player, "Fuel", Fuel.Value)
end)

to this

Fuel.Changed:Connect(function(value)
	print("Changed")
	PlayerDataHandler:Update(player, "Fuel", Fuel.Value)  --get the player in another way
end)

Morghuls · July 11, 2023, 3:26pm

Ah! -sees issue- The issue in the code is that the event connection for Fuel.Value.Changed is missing the parameter for the new value, and the else if statement should be replaced with elseif Xx

FaKeLoL2006 · July 11, 2023, 3:27pm

Thank You Guys For Helping Me. I Managed To Fix It. Here Is The Code:

local Settings = require(script.Parent.Fuel_Settings.Settings)
local PlayerDataHandler = require(game.ServerScriptService.PlayerDataHandler)

local Fuel = script.Fuel
local Seat = script.Parent

local Player = nil

local RealFuel = nil

Seat:GetPropertyChangedSignal("Occupant"):Connect(function()
	if Seat.Occupant then
		Player = game:GetService("Players"):GetPlayerFromCharacter(Seat.Occupant.Parent)
		Seat:SetAttribute("Player", Player.UserId)
	else
		Player = game:GetService("Players"):GetPlayerByUserId(Seat:GetAttribute("Player"))
	end
	RealFuel = PlayerDataHandler:Get(Player, "Fuel")
	Fuel.Value = RealFuel
end)

Seat.ChildAdded:Connect(function()
	Fuel.Changed:Connect(function()
		PlayerDataHandler:Update(Player, "Fuel", function(currentFuel)
			currentFuel = Fuel.Value
			return currentFuel
		end)
	end)
end)

task.spawn(function()
	if Settings.Random_Fuel == true then
		Fuel.Value = math.random(25,60)
		wait(.5)
		while true do
			wait(0)
			if Seat.Throttle == 1 and Fuel.Value > 0 then
				wait(math.random(Settings.Min_Mpg, Settings.Max_Mpg))
				Fuel.Value = Fuel.Value - 1
			end
		end
	else if Settings.Random_Fuel == false then
			while true do 
				wait(0)
				if Seat.Throttle == 1 and Fuel.Value > 0 then
					wait(math.random(Settings.Min_Mpg,Settings.Max_Mpg))
					Fuel.Value = Fuel.Value - 1
				end
			end
		end
	end
end)

normanthewarding · July 11, 2023, 4:53pm

what did you change may i ask?

FaKeLoL2006 · July 11, 2023, 6:12pm

So Basically I Moved The Fuel.Changed Function Above The Loops, Changed Method Of Getting Player and It Started Printing In Console And Saving Data Too. Here Is Finished Code:

local Settings = require(script.Parent.Fuel_Settings.Settings)
local PlayerDataHandler = require(game.ServerScriptService.PlayerDataHandler)

local Fuel = script.Fuel
local Seat = script.Parent

local Player = nil

local RealFuel = nil

Seat:GetPropertyChangedSignal("Occupant"):Connect(function()
	if Seat.Occupant then
		Player = game:GetService("Players"):GetPlayerFromCharacter(Seat.Occupant.Parent)
		Seat:SetAttribute("Player", Player.UserId)
	else
		Player = game:GetService("Players"):GetPlayerByUserId(Seat:GetAttribute("Player"))
	end
	RealFuel = PlayerDataHandler:Get(Player, "Fuel")
	Fuel.Value = RealFuel
end)

Seat.ChildAdded:Connect(function()
	Fuel.Changed:Connect(function()
		PlayerDataHandler:Update(Player, "Fuel", function(currentFuel)
			currentFuel = Fuel.Value
			return currentFuel
		end)
	end)
end)

task.spawn(function()
	if Settings.Random_Fuel == true then
		Fuel.Value = math.random(25,60)
		wait(.5)
		while true do
			wait(0)
			if Seat.Throttle == 1 and Fuel.Value > 0 then
				wait(math.random(Settings.Min_Mpg, Settings.Max_Mpg))
				Fuel.Value = Fuel.Value - 1
			end
		end
	else if Settings.Random_Fuel == false then
			while true do 
				wait(0)
				if Seat.Throttle == 1 and Fuel.Value > 0 then
					wait(math.random(Settings.Min_Mpg,Settings.Max_Mpg))
					Fuel.Value = Fuel.Value - 1
				end
			end
		end
	end
end)

normanthewarding · July 11, 2023, 6:13pm

yeah that was what I said to do but i dont think you saw

FaKeLoL2006 · July 11, 2023, 6:15pm

yeah idk lol i almost smashed my pc cuz the script didn’t work. i was trying to fix it for 2 days xd

system · July 25, 2023, 6:15pm

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.