How To Fix A Tag

Help and Feedback Scripting Support
, , ,
#1

I am trying to make a team changer where you hit the job and ui pop up. Then if you hit get tag it. switches your team to that job.

All of this works accept the tag does not change. How do I fix this?
This is what happens in the video

This script is a normal script in StarterCharacterScripts

local char = script.Parent
local plr = game.Players:GetPlayerFromCharacter(char)

local NameTagClone = game.ServerStorage.HeadUI:Clone()

NameTagClone.Parent = char.Head
NameTagClone.Adornee = char.Head

NameTagClone.UI.NameUI.NameName.Text = char.Name

if plr.Team == nil then
	NameTagClone.UI.RankUI.RankName.Text = "Player"
end

repeat wait() until plr.Team ~= nil

NameTagClone.UI.RankUI.RankName.Text = plr.Team.Name

char.Humanoid.DisplayDistanceType = "None"
8 Likes
#2

You have to update the tag after the team changes.
try using

player:GetPropertyChangedSignal("Team"):Connect(function()
   NameTagClone.UI.RankUI.RankName.Text = plr.Team.Name
end)
4 Likes
#3

That did not work

local char = script.Parent

local plr = game.Players:GetPlayerFromCharacter(char)

local NameTagClone = game.ServerStorage.HeadUI:Clone()

NameTagClone.Parent = char.Head
NameTagClone.Adornee = char.Head

NameTagClone.UI.NameUI.NameName.Text = char.Name

if plr.Team == nil then
	NameTagClone.UI.RankUI.RankName.Text = "Player"
end

repeat wait() until plr.Team ~= nil

NameTagClone.UI.RankUI.RankName.Text = plr.Team.Name

char.Humanoid.DisplayDistanceType = "None"

plr:GetPropertyChangedSignal("Team"):Connect(function()
	NameTagClone.UI.RankUI.RankName.Text = plr.Team.Name
end)
3 Likes
#4

You can just change it constantly then.
change

plr:GetPropertyChangedSignal("Team"):Connect(function()

with

game:GetService("RunService").Heartbeat:Connect(function()
2 Likes
#5

Here is what happens when I hit the spawn point it works but when I hit the UI the Tag does not change

1 Like
#6

Could you show us the code responsible of prompting the UI (the .touched event)?

1 Like
#7 
local TeamAN = "Animator"

local Job = script.Parent

local Animator = Job.AnimatorFrame

local AnimatorB = Job.AnimatorFrame.AcceptButton

AnimatorB.MouseButton1Down:Connect(function()
	Animator.Visible = not Animator.Visible
end)


AnimatorB.MouseButton1Down:Connect(function(h)
	local player = game.Players.LocalPlayer
	if player then
		player.Team = game:GetService("Teams")[TeamAN]
	end
end)
1 Like
#8

This is the touch script

local Animator = game.Workspace.Map.Jobs.HitBoxes:WaitForChild("Animator")

Animator.Touched:Connect(function(Hit)
	if Hit.Parent:FindFirstChild("Humanoid") then
		script.Parent.Parent.JobUI.AnimatorFrame.Visible = true
		repeat task.wait() until (Animator.Position - Hit.Parent.HumanoidRootPart.Position).magnitude >= 12
		script.Parent.Parent.JobUI.AnimatorFrame.Visible = false
	end
end)
1 Like
#9

Add after

player.Team = game:GetService("Teams")[TeamAN]

The following line:

player.HeadUI.UI.RankUI.RankName.Text = plr.Team.Name
1 Like
#10

That did not work--------------

1 Like
#11

Do you have any error on the output?

1 Like
#12

Ya
HeadUI is not a valid member of Player “Players.Cyber_Designer”

1 Like
#13

Modify that line with this one:

player.Head.HeadUI.UI.RankUI.RankName.Text = plr.Team.Name`
1 Like
#14

It said
Head is not a valid member of Player “Players.Cyber_Designer” -

1 Like
#15

I forgot it is the Player, not the Player’s character yet :sweat_smile:
This should be the final working line:

player.Character.Head.HeadUI.UI.RankUI.RankName.Text = plr.Team.Name`
1 Like
#16

Ok it work Thank You!!! but is

player.Character.Head.HeadUI.UI.RankUI.RankName.Text = player.Team.Name

not

player.Character.Head.HeadUI.UI.RankUI.RankName.Text = plr.Team.Name`
2 Likes
#17

Sorry if I was unable to help with this situation but, as I see you are changing the team and ui from the client and it will only appear on the client’s side, not for the whole server. Try using a remote event to fix this.

1 Like
#18

wait how do I do that----------

#19

You don’t need a remote event

game.Players.PlayerAdded:Connect(function(plr)
	plr.CharacterAdded:Connect(function(char)
		---> variables
		local NameTagClone = game.ServerStorage.HeadUI:Clone()

		---> main
		NameTagClone.Parent = char.Head
		NameTagClone.Adornee = char.Head

		NameTagClone.UI.NameUI.NameName.Text = char.Name

		if plr.Team == nil then
			NameTagClone.UI.RankUI.RankName.Text = "Player"
		end

		repeat wait() until plr.Team ~= nil

		NameTagClone.UI.RankUI.RankName.Text = plr.Team.Name

		char.Humanoid.DisplayDistanceType = "None"

		game:GetService("RunService").Heartbeat:Connect(function()
			NameTagClone.UI.RankUI.RankName.Text = plr.Team.Name
		end)
	end)
end)
#20

This is very inefficient, why don’t you use the code I gave you?
It is efficient and is also server side, meaning it will show the updated title to all players in the server