What kicks a "This is considered bad practice and should be avoided" warning?

InfinityDesign · October 10, 2023, 7:48pm

Never seen this warning before so I’m not quite sure what it’s in reference to. It just appeared in our logs over the weekend.

Dogekidd2012 · October 10, 2023, 8:18pm

I searched all of GitHub. It looks like this is from Flamework. This may help:

github.com

rbxts-flamework/core/blob/a7204578a17407cb6f2fab22f8e3864ecf7b845a/src/flamework.ts#L35


      
          	/** @hidden */
          	export function resolveDependency(id: string) {
          		if (isPreloading) {
          			const [source, line] = debug.info(2, "sl");
          			warn(`[Flamework] Attempting to load dependency '${id}' during preloading.`);
          			warn("This is prone to race conditions and is not guaranteed to succeed.");
          			warn(`Script '${source}', Line ${line}`);
          		} else if (!hasFlameworkIgnited && Metadata.gameConfig.disableDependencyWarnings !== true) {
          			const [source, line] = debug.info(2, "sl");
          			warn(`[Flamework] Dependency '${id}' was loaded before ignition.`);
          			warn("This is considered bad practice and should be avoided.");
          			warn("You can disable this warning in flamework.json");
          			warn(`Script '${source}', Line ${line}`);
          		}
          		return Modding.resolveDependency(ArtificialDependency, id, 0, {});
          	}
          
          
	/** @hidden */
          	export function _addPaths(paths: string[][]) {
          		const preloadPaths = new Array<Instance>();
          		for (const arg of paths) {

InfinityDesign · October 10, 2023, 8:22pm

Oh wow, thank you so much! It must have been injected.

system · October 24, 2023, 8:22pm

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.