How to change the parent of instances in a for loop

Help and Feedback Scripting Support
#1

I noticed that if you change the parent of a model being the subject of an iteration, the for loop breaks. Here’s an example:

for i, v in pairs (models) do --assume there are five models
print(i)
v.Parent = workspace
end

This for loop would only print once due to the interruption.

How would I get around this?

1 Like
#2

It shouldn’t be. Can I see your actual code so I can see how you’re initializing models? Maybe a bit more code for context? Maybe a bit more code for context? Are you saying that when you don’t run the v.parent code, it runs normally? Where is this script located?

#3 
for i, v in ipairs (game.ServerStorage:FindFirstChild(script:GetAttribute("TargetModuleFolder")):GetChildren()) do
v.Parent = workspace
task.wait()
v.Parent = game.ServerStorage:FindFirstChild(script:GetAttribute("TargetModuleFolder"))
end

Yes, it runs normally if the parent defining lines are removed. Apologies for the lack of context.

#4

Don’t think it would, but does putting it in a variable have any effect?

local initialParent = game.ServerStorage:FindFirstChild(script:GetAttribute("TargetModuleFolder"))
local children = initialParent:GetChildren())

for i, v in ipairs(children) do
    print(i)
    v.Parent = workspace
    task.wait()
    v.Parent = initialParent
end
#5

I did what you suggested, it only printed once. While I was awaiting a reply I tried to find a work around by looping without pairs (for i = 1,10) and serialized the instances so I could access them via variable, it still broke when I changed the parent, how bizzare!

#6

try it with a breakpoint and see what happens maybe. not quite sure what could be causing it.

#7

try pairs as well instead of ipairs

#8

So I figured out it only happens when I try to move a model to the workspace. Moving it anywhere else still works

#9

Ah, now I am beginning to understand why you guys want the code. It ended up being a rouge infinite yield loop in a function that I thought was irrelevant. Apologies for the inconvenience.

1 Like
#10

Nope, glad you figured it out!

#11

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.