Admin Command Not Working

Help and Feedback Scripting Support
#24

Nope didnt work :frowning: :frowning:

#25

Try printing the args before the line commands[cmdName](player,args). Tell me what was outputted.

#26

this is what was printed:

there you see now

#27

I changed it to local cmdName = cmd[2] and now it prints

but shows the x1 x2 etc.

#28

So cmd[2] works :grinning_face_with_smiling_eyes:

#29

It may not get the player and plus it only gets one I want to get all players in this:

function commandsModule.FindPlayer()
	for _, player in pairs(game.Players:GetPlayers()) do
		return player
	end
end
#30

And my command just will not get past FireAllClients

#31

I will show all of my new scripts I changed all of them except one

--script
local commands = {}

--local CommandsModule = require(script.Parent.CommandsModule)

local admins = {
	"FreeFlyHaker56"
}

local prefix = ":"

local function findPlayer(name)

	for i, player in pairs(game.Players:GetPlayers()) do
		if string.lower(player.Name) == name then
			return player
		end
	end

	return nil

end

local function isAdmin(player)
	for _, v in pairs(admins) do
		if v == player.Name then -- If their an admin
			return true
		end
	end

	return false

end

commands.m = function(sender, args)
	
	local message = args[1]
	
	if message then
		for _, player in pairs(game.Players:GetPlayers()) do
			script.Parent.ClientCommand:FireAllClients(player, message)
		end
	end
end

game.Players.PlayerAdded:Connect(function(player)
	player.Chatted:Connect(function(message,recipient)
		if isAdmin(player) then
			message = string.lower(message)

			local splitString = message:split(" ")

			local slashCommand = splitString[1]

			local cmd = slashCommand:split(prefix)

			local cmdName = cmd[2]

			if commands[cmdName] then

				local args = {}

				for i = 2, #splitString, 1 do
					table.insert(args,splitString[i])
				end
				print(commands[cmdName](player,args))

				commands[cmdName](player,args)
					
			end
		end
	end)
end)
--localscript
local CommandsModule = require(script.Parent.CommandsModule)

script.Parent:WaitForChild("ClientCommand").OnClientEvent:Connect(function(player, msg)
	
	CommandsModule.MessageCommand(player, msg)
	
end)
--modulescript
local commandsModule = {}

function commandsModule.FindPlayer()
	for _, player in pairs(game.Players:GetPlayers()) do
		return player
	end
end

function commandsModule.MessageCommand(player, result)
	local messageGui = script.MessageGui

	local messageClone = messageGui:Clone()
	messageClone.Parent = player:WaitForChild("PlayerGui")
	messageClone.MessageFrame.Message.Text = tostring(result)
end

return commandsModule
#32

Please work… If it doesn’t just tell me what is outputted.

--script
local commands = {}

--local CommandsModule = require(script.Parent.CommandsModule)

local admins = {
	"FreeFlyHaker56"
}

local prefix = ":"

local function findPlayer(name)

	for i, player in pairs(game.Players:GetPlayers()) do
		if string.lower(player.Name) == name then
			return player
		end
	end

	return nil

end

local function isAdmin(player)
	if table.find(admins,player.Name) then
		return true
	end
	return false
end

commands.m = function(sender, args)
	
	local message = args[1]
	
	if message then
		print("Message Found")
		script.Parent.ClientCommand:FireAllClients(message)
	end
end

game.Players.PlayerAdded:Connect(function(player)
	player.Chatted:Connect(function(message,recipient)
		if isAdmin(player) then
			message = string.lower(message)

			local splitString = message:split(" ")

			local slashCommand = splitString[1]

			local cmd = slashCommand:split(prefix)

			local cmdName = cmd[2]

			if commands[cmdName] then
				print("Found Function")

				local args = {}

				for i = 2, #splitString, 1 do
					table.insert(args,splitString[i])
				end
				print("Running Function")
				print(args) -- Arguments
				commands[cmdName](player,args)
			end
		end
	end)
end)
--localscript
local CommandsModule = require(script.Parent.CommandsModule)
local player = game.Players.LocalPlayer

script.Parent:WaitForChild("ClientCommand").OnClientEvent:Connect(function(msg)
	
	CommandsModule.MessageCommand(player, msg)
	
end)
--modulescript
local commandsModule = {}

function commandsModule.FindPlayer()
	for _, player in pairs(game.Players:GetPlayers()) do
		return player
	end
end

function commandsModule.MessageCommand(player, result)
	local messageGui = script.MessageGui

	local messageClone = messageGui:Clone()
	messageClone.Parent = player:WaitForChild("PlayerGui")
	messageClone.MessageFrame.Message.Text = tostring(result)
	
	print("Message Sent Successfully")
end

return commandsModule
#33

image
It did not summon in the gui for me

#34

The message did not send whatsoever

#35

I’m now thinking is it because your remote event couldn’t be found? Can you show me your studio hierarchy of where all your scripts and remote events are?

#36

:+1: ok bro why not :grinning_face_with_smiling_eyes:

#37

Ignore the model name it is a meme ok :grinning_face_with_smiling_eyes:
image

#38

I know how to spell lol :grinning_face_with_smiling_eyes:

#39

How about for the remote event in your server script define it with a WaitForChild at the top of the script. Like this:

local commands = {}

--local CommandsModule = require(script.Parent.CommandsModule)
local ClientCommand = script.Parent:WaitForChild("ClientCommand")

local admins = {
	"FreeFlyHaker56"
}

local prefix = ":"

local function findPlayer(name)

	for i, player in pairs(game.Players:GetPlayers()) do
		if string.lower(player.Name) == name then
			return player
		end
	end

	return nil

end

local function isAdmin(player)
	if table.find(admins,player.Name) then
		return true
	end
	return false
end

commands.m = function(sender, args)
	
	local message = args[1]
	
	if message then
		print("Message Found")
		ClientCommand:FireAllClients(message)
		print("Remote Event Fired")
	end
end

game.Players.PlayerAdded:Connect(function(player)
	player.Chatted:Connect(function(message,recipient)
		if isAdmin(player) then
			message = string.lower(message)

			local splitString = message:split(" ")

			local slashCommand = splitString[1]

			local cmd = slashCommand:split(prefix)

			local cmdName = cmd[2]

			if commands[cmdName] then
				print("Found Function")

				local args = {}

				for i = 2, #splitString, 1 do
					table.insert(args,splitString[i])
				end
				print("Running Function")
				print(args) -- Arguments
				commands[cmdName](player,args)
			end
		end
	end)
end)
#40

Still didnt print message sent :grinning_face_with_smiling_eyes:

#41

printed the same thing as before :grinning_face_with_smiling_eyes:

#42

For your local script try adding a print to see if the remote event fired successfully:

local CommandsModule = require(script.Parent.CommandsModule)
local player = game.Players.LocalPlayer

script.Parent:WaitForChild("ClientCommand").OnClientEvent:Connect(function(msg)
	print("Remote Event Fired To The Client")
	CommandsModule.MessageCommand(player, msg)
end)
#43

It was not fired it never passed the fireallclients