Any way to make this function shorter?

[sata5pa3da]

@NexoKami you should use @Inconcludable 's solution because it takes into account performance which I did take into account but didn’t implement because I was in a rush

[NexoKami]

That is true, but the main goal is to have fewer lines as possible.

[sata5pa3da]

Not sure why that is important but if it were, you could just compress all the code into one line:

local function AddItem(ClassName:string, Properties:{[string]: any})
   local obj = Instance.new(ClassName) for i,v in pairs(Properties) obj[i] = v end return obj
end

[NexoKami]

It’s really not important.
But I’ll keep it in mind about it.

[domboss37 (TSL)]

@domboss37

local function newObj(type, props)
    local obj = Instance.new(type)
    for PropName, Prop in props do
        if obj[PropName] then obj[PropName] = Prop end
    end
    return obj
end

local Part = newObj("Part", {
    ["Parent"] = workspace
})

12 Replies later we get what was marked solution…

@sata5pa3da

local function AddItem(ClassName:string, Properties:{[string]: any})
   local obj = Instance.new(ClassName)
   for i,v in pairs(Properties)
      obj[i] = v
   end
return obj
end

--Example usage
local Part = AddItem("Part", {Parent = workspace, Name = "Test"})

Ah yes, the exact same thing just with shorter variable names and type casting. Oh and I think the biggest reason: No new lines in the second argument. Anyways, have a good day to all of you

[NexoKami]

Unfortunately, I couldn’t figure that one out xD

[EliottENAnnoucement (EliottENDevForum)]

This should be at #help-and-feedback:code-review and not at #help-and-feedback:scripting-support.