Attempt to index nil with money, only happens in Local Server

[MagicLuau (Script)]

Basically the issue is not happening when loading in normal play test but it does happen in Local Server server. i don’t know what causing the issue and how i can fix it.

Normal play test:

Local Server:

Script:

local DataStoreService = game:GetService("DataStoreService")
local DataStore  = false

local success,errorm = pcall(function()
	DataStore = DataStoreService:GetDataStore("MoneyFtMiles")
end)

game.Players.PlayerAdded:Connect(function(player)
	local getsuccess,result = pcall(function()
		return DataStore:GetAsync(player.UserId)
	end)
	
	if not getsuccess and result then
		warn("Load failed for Money and miles : "..result)
		player:Kick("Something doesn't allow you're stats to properly load at the time. Please rejoin")
		return
	end
	
	local groupsuccess,grouperror = pcall(function()
		local group = player:IsInGroup(1)
	end)
	
	if not groupsuccess and grouperror then
		warn("Roblox might be down : "..grouperror)
		player:Kick("Roblox might be down at the moment, please join later to protect your progress.")
		return
	end
	
	local leaderstats = Instance.new("Folder",player)
	leaderstats.Name = "leaderstats"

	local Money = Instance.new("NumberValue",leaderstats)
	Money.Name = "Money"
	Money.Value = result.Money

	local Miles = Instance.new("NumberValue",leaderstats)
	Miles.Name = "Miles"
	Miles.Value = result.Miles
	
end)

game.Players.PlayerRemoving:Connect(function(player)
	if not player:FindFirstChild("leaderstats") then
		return
	end
	
	local Money = player.leaderstats:FindFirstChild("Money")
	local Miles = player.leaderstats:FindFirstChild("Miles")
	
	if not Money or not Miles then
		return
	end
	
	success,errorm = pcall(function()
		DataStore:SetAsync(player.UserId,{
			["Money"] = Money.Value;
			["Miles"] = Miles.Value;
		})
	end)
	
	if not success then
		warn("SAVING FAILLURE : "..errorm)
	end
	
end)

workspace.ChildAdded:Connect(function(child)
	local player = game.Players:GetPlayerFromCharacter(child)
	
	if not player then
		return
	end
	
	for _,part in child:GetDescendants() do
		if part:IsA("Part") or part:IsA("MeshPart") then
			part.CollisionGroup = "Players"
		end
	end
end)

[Ransomwavee (Ransomwave)]

This is because the script is attempting to find Money in an instance that is nil, which turns out to be leaderstats. Try waiting for the player’s character or do game.Loaded:Wait() at the top to see if it helps.

Another great trick, always set the attributes of an instance first before setting its parent, that way it’s more efficient.

-- Bad practice, setting parent before setting attributes meaning server has to connect and fire additonal events.
local Money = Instance.new("NumberValue",leaderstats)
Money.Name = "Money"
Money.Value = result.Money

-- Good practice, mitigates any unnecessary steps the server has to take.
local Money = Instance.new("NumberValue")
Money.Name = "Money"
Money.Value = result.Money
Money.Parent = leaderstats

PSA: Don't use Instance.new() with parent argument

I’ve discovered a pretty bad performance issue in one of top games that has to do with Instance.new and wanted to write about this, since this is not obvious unless you know the system inside out. Tthere are several ways to create a ROBLOX object in Lua: local obj = Instance.new(‘type’); fill obj fields local obj = Instance.new(‘type’, parent); fill obj fields local obj = util.Create(‘type’, { field1 = value1, … }) If you care at all about performance, please only use the first option - I wi…

[MagicLuau (Script)]

After modifying the script the issue seems to be happening and result.Money and result.Miles does exist

local DataStoreService = game:GetService("DataStoreService")
local DataStore  = false

local success,errorm = pcall(function()
	DataStore = DataStoreService:GetDataStore("MoneyFtMiles")
end)

game.Players.PlayerAdded:Connect(function(player)
	local getsuccess,result = pcall(function()
		return DataStore:GetAsync(player.UserId)
	end)
	
	task.wait(.05)
	
	if not getsuccess and result then
		warn("Load failed for Money and miles : "..result)
		player:Kick("Something doesn't allow you're stats to properly load at the time. Please rejoin")
		return
	end
	
	if getsuccess then
		if not result.Money or not result.Miles then
			
			for i,v in result do
				print(i,v)
			end
			
			warn("Something went wrong load money")
			
			return
		end
	end
	
	local groupsuccess,grouperror = pcall(function()
		local group = player:IsInGroup(1)
	end)
	
	if not groupsuccess and grouperror then
		warn("Roblox might be down : "..grouperror)
		player:Kick("Roblox might be down at the moment, please join later to protect your progress.")
		return
	end
	
	local leaderstats = Instance.new("Folder",player)
	leaderstats.Name = "leaderstats"

	local Money = Instance.new("NumberValue")
	Money.Name = "Money"
	Money.Value = result["Money"] or 0
	Money.Parent = leaderstats

	local Miles = Instance.new("NumberValue")
	Miles.Name = "Miles"
	Miles.Value = result["Miles"] or 0
	Miles.Parent = leaderstats
	
end)

game.Players.PlayerRemoving:Connect(function(player)
	if not player:FindFirstChild("leaderstats") then
		return
	end
	
	local Money = player.leaderstats:FindFirstChild("Money")
	local Miles = player.leaderstats:FindFirstChild("Miles")
	
	if not Money or not Miles then
		return
	end
	
	success,errorm = pcall(function()
		DataStore:SetAsync(player.UserId,{
			["Money"] = Money.Value;
			["Miles"] = Miles.Value;
		})
	end)
	
	if not success then
		warn("SAVING FAILLURE : "..errorm)
	end
	
end)

workspace.ChildAdded:Connect(function(child)
	local player = game.Players:GetPlayerFromCharacter(child)
	
	if not player then
		return
	end
	
	for _,part in child:GetDescendants() do
		if part:IsA("Part") or part:IsA("MeshPart") then
			part.CollisionGroup = "Players"
		end
	end
end)

[Ransomwavee (Ransomwave)]

Again, try waiting for the player’s character or game.Loaded.

If it still persists, look into the group check you’re doing (you’re checking for ID 1 which will always return false?)

[MagicLuau (Script)]

Load fail as always, even if the userid is -1 or -2, it find the data but doenst add the data to the value.

[Ransomwavee (Ransomwave)]

Is it the value instance that’s failing, or is it the datastore value you are retrieving? Print the datastore resuly you get and check if it’s nil.

[MagicLuau (Script)]

i get result as nil, which is pretty weird

[Ransomwavee (Ransomwave)]

This means somewhere else you are not correctly saving your data. Can I see how you save it to the datastore?

[hya123456h (KingBob)]

Try implementing a BindToClose function (don’t have the docs link atm) or check to see if the data is saving successfully

[MagicLuau (Script)]

actually i found the issue, look closely, the stat dont create because its empty, result is nil because player don’t have saved stats, solved by letting a new table handle the stat for players.